Fix MSTEST0001 (parallelization analyzer) to work with VSTest by @Youssef1313 in #6480 (backport to rel/3.10) (#6486)

Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>

Author: youssef-backport-bot

src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.props

@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <EnableMSTestV2CopyResources Condition=" '$(EnableMSTestV2CopyResources)' == '' ">true</EnableMSTestV2CopyResources>
+    <IsMSTestTestAdapterReferenced>true</IsMSTestTestAdapterReferenced>
   </PropertyGroup>
 
   <ItemGroup>

src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets

@@ -51,6 +51,10 @@
     <None Include="@(TestAdapterContent)" />
   </ItemGroup>
 
+  <ItemGroup>
+    <CompilerVisibleProperty Include="IsMSTestTestAdapterReferenced" />
+  </ItemGroup>
+
   <Choose>
     <!-- Avoid false warning about missing reference (msbuild bug) -->
     <!-- https://github.com/dotnet/msbuild/issues/9698#issuecomment-1945763467 -->

src/Adapter/MSTest.TestAdapter/buildTransitive/uwp/MSTest.TestAdapter.props

@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <EnableMSTestV2CopyResources Condition=" '$(EnableMSTestV2CopyResources)' == '' ">true</EnableMSTestV2CopyResources>
+    <IsMSTestTestAdapterReferenced>true</IsMSTestTestAdapterReferenced>
   </PropertyGroup>
 
 </Project>

src/Adapter/MSTest.TestAdapter/buildTransitive/uwp/MSTest.TestAdapter.targets

@@ -27,6 +27,10 @@
     <None Include="@(TestAdapterContent)" />
   </ItemGroup>
 
+  <ItemGroup>
+    <CompilerVisibleProperty Include="IsMSTestTestAdapterReferenced" />
+  </ItemGroup>
+
   <Target Name="GetMSTestV2CultureHierarchy">
     <!--
       Only traversing 5 levels in the culture hierarchy. This is the maximum length for all cultures and should be sufficient

src/Analyzers/MSTest.Analyzers/UseParallelizeAttributeAnalyzer.cs

@@ -45,7 +45,10 @@ public override void Initialize(AnalysisContext context)
 
     private static void AnalyzeCompilation(CompilationAnalysisContext context)
     {
-        bool hasTestAdapter = context.Compilation.ReferencedAssemblyNames.Any(asm => asm.Name == "Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter");
+        bool hasTestAdapter = context.Options.AnalyzerConfigOptionsProvider.GlobalOptions.TryGetValue("build_property.IsMSTestTestAdapterReferenced", out string? isAdapterReferenced) &&
+            bool.TryParse(isAdapterReferenced, out bool isAdapterReferencedValue) &&
+            isAdapterReferencedValue;
+
         if (!hasTestAdapter)
         {
             // We shouldn't produce a diagnostic if only the test framework is referenced, but not the adapter.

test/IntegrationTests/MSTest.Acceptance.IntegrationTests/AnalyzersTests.cs

@@ -9,6 +9,62 @@ namespace MSTest.Acceptance.IntegrationTests;
 [TestClass]
 public sealed class AnalyzersTests : AcceptanceTestBase<NopAssetFixture>
 {
+    [TestMethod]
+    [DataRow(false, false)]
+    [DataRow(false, true)]
+    [DataRow(true, false)]
+    [DataRow(true, true)]
+    public async Task MSTEST0001(bool isMTP, bool isAdapterReferenced)
+    {
+        string code = $$"""
+#file TestForMSTEST0001.csproj
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>$TargetFrameworks$</TargetFramework>
+    <RunAnalyzers>true</RunAnalyzers>
+    <MSTestAnalysisMode>all</MSTestAnalysisMode>
+
+    {{(isMTP ? """
+    <EnableMSTestRunner>true</EnableMSTestRunner>
+    <OutputType>Exe</OutputType>
+    """ : string.Empty)}}
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="$MicrosoftNETTestSdkVersion$" />
+    <PackageReference Include="MSTest.TestFramework" Version="$MSTestVersion$" />
+    {{(isAdapterReferenced ? "<PackageReference Include=\"MSTest.TestAdapter\" Version=\"$MSTestVersion$\" />" : string.Empty)}}
+  </ItemGroup>
+</Project>
+
+#file UnitTest1.cs
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[TestClass]
+public class UnitTest1
+{
+    [TestMethod]
+    public void TestMethod()
+    {
+    }
+}
+""".PatchTargetFrameworks(TargetFrameworks.NetCurrent)
+    .PatchCodeWithReplace("$MSTestVersion$", MSTestVersion)
+    .PatchCodeWithReplace("$MicrosoftNETTestSdkVersion$", MicrosoftNETTestSdkVersion);
+
+        using TestAsset testAsset = await TestAsset.GenerateAssetAsync("TestForMSTEST0001", code);
+        DotnetMuxerResult result = await DotnetCli.RunAsync($"build {testAsset.TargetAssetPath}", AcceptanceFixture.NuGetGlobalPackagesFolder.Path, warnAsError: false);
+        if (isAdapterReferenced)
+        {
+            result.AssertOutputContains("warning MSTEST0001");
+        }
+        else
+        {
+            result.AssertOutputDoesNotContain("warning MSTEST0001");
+        }
+    }
+
     [TestMethod]
     public async Task AnalyzersShouldBeEnabledWhenUsingMetapackage()
     {

test/UnitTests/MSTest.Analyzers.UnitTests/UseParallelizeAttributeAnalyzerTests.cs

@@ -1,9 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Testing;
-using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter;
 
 using VerifyCS = MSTest.Analyzers.Test.CSharpCodeFixVerifier<
     MSTest.Analyzers.UseParallelizeAttributeAnalyzer,
@@ -23,10 +21,13 @@ private static async Task VerifyAsync(string code, bool includeTestAdapter, para
 
         if (includeTestAdapter)
         {
-            // NOTE: Test constructor already adds TestFramework refs.
-#pragma warning disable CS0618 // Type or member is obsolete
-            test.TestState.AdditionalReferences.Add(MetadataReference.CreateFromFile(typeof(MSTestExecutor).Assembly.Location));
-#pragma warning restore CS0618 // Type or member is obsolete
+            test.TestState.AnalyzerConfigFiles.Add((
+                "/.globalconfig",
+                """
+                is_global = true
+
+                build_property.IsMSTestTestAdapterReferenced = true
+                """));
         }
 
         test.ExpectedDiagnostics.AddRange(expected);