fix: bugs where env deletion or creation are not recorded (#362)

Author: karthiknadig

src/extension.ts

@@ -95,17 +95,13 @@ export async function activate(context: ExtensionContext): Promise<PythonEnviron
     const terminalActivation = new TerminalActivationImpl();
     const shellEnvsProviders = createShellEnvProviders();
     const shellStartupProviders = createShellStartupProviders();
-    const shellStartupVarsMgr = new ShellStartupActivationVariablesManagerImpl(
-        context.environmentVariableCollection,
-        shellEnvsProviders,
-        envManagers,
-    );
+
     const terminalManager: TerminalManager = new TerminalManagerImpl(
         terminalActivation,
         shellEnvsProviders,
         shellStartupProviders,
     );
-    context.subscriptions.push(terminalActivation, terminalManager, shellStartupVarsMgr);
+    context.subscriptions.push(terminalActivation, terminalManager);
 
     const projectCreators: ProjectCreators = new ProjectCreatorsImpl();
     context.subscriptions.push(
@@ -125,8 +121,14 @@ export async function activate(context: ExtensionContext): Promise<PythonEnviron
     workspaceView.initialize();
 
     const monitoredTerminals = new Map<Terminal, PythonEnvironment>();
+    const shellStartupVarsMgr = new ShellStartupActivationVariablesManagerImpl(
+        context.environmentVariableCollection,
+        shellEnvsProviders,
+        api,
+    );
 
     context.subscriptions.push(
+        shellStartupVarsMgr,
         registerCompletionProvider(envManagers),
         registerTools('python_environment', new GetEnvironmentInfoTool(api, envManagers)),
         registerTools('python_install_package', new InstallPackageTool(api)),

src/features/views/projectView.ts

@@ -10,22 +10,22 @@ import {
     window,
 } from 'vscode';
 import { PythonEnvironment } from '../../api';
+import { ProjectViews } from '../../common/localize';
+import { createSimpleDebounce } from '../../common/utils/debounce';
+import { onDidChangeConfiguration } from '../../common/workspace.apis';
 import { EnvironmentManagers, PythonProjectManager } from '../../internal.api';
 import {
-    ProjectTreeItem,
-    ProjectItem,
-    ProjectEnvironment,
-    ProjectPackageRootTreeItem,
-    ProjectTreeItemKind,
+    GlobalProjectItem,
     NoProjectEnvironment,
+    ProjectEnvironment,
     ProjectEnvironmentInfo,
+    ProjectItem,
     ProjectPackage,
     ProjectPackageRootInfoTreeItem,
-    GlobalProjectItem,
+    ProjectPackageRootTreeItem,
+    ProjectTreeItem,
+    ProjectTreeItemKind,
 } from './treeViewItems';
-import { onDidChangeConfiguration } from '../../common/workspace.apis';
-import { createSimpleDebounce } from '../../common/utils/debounce';
-import { ProjectViews } from '../../common/localize';
 
 export class ProjectView implements TreeDataProvider<ProjectTreeItem> {
     private treeView: TreeView<ProjectTreeItem>;
@@ -171,7 +171,7 @@ export class ProjectView implements TreeDataProvider<ProjectTreeItem> {
                 ];
             }
 
-            const environment = await manager?.get(uri);
+            const environment = await this.envManagers.getEnvironment(uri);
             if (!environment) {
                 return [
                     new NoProjectEnvironment(

src/managers/builtin/venvManager.ts

@@ -1,4 +1,5 @@
-import { ProgressLocation, Uri, LogOutputChannel, EventEmitter, MarkdownString, ThemeIcon, l10n } from 'vscode';
+import * as path from 'path';
+import { EventEmitter, l10n, LogOutputChannel, MarkdownString, ProgressLocation, ThemeIcon, Uri } from 'vscode';
 import {
     CreateEnvironmentOptions,
     CreateEnvironmentScope,
@@ -17,6 +18,12 @@ import {
     ResolveEnvironmentContext,
     SetEnvironmentScope,
 } from '../../api';
+import { PYTHON_EXTENSION_ID } from '../../common/constants';
+import { VenvManagerStrings } from '../../common/localize';
+import { createDeferred, Deferred } from '../../common/utils/deferred';
+import { showErrorMessage, withProgress } from '../../common/window.apis';
+import { NativePythonFinder } from '../common/nativePythonFinder';
+import { getLatest, shortVersion, sortEnvironments } from '../common/utils';
 import {
     clearVenvCache,
     createPythonVenv,
@@ -32,13 +39,6 @@ import {
     setVenvForWorkspace,
     setVenvForWorkspaces,
 } from './venvUtils';
-import * as path from 'path';
-import { NativePythonFinder } from '../common/nativePythonFinder';
-import { PYTHON_EXTENSION_ID } from '../../common/constants';
-import { createDeferred, Deferred } from '../../common/utils/deferred';
-import { getLatest, shortVersion, sortEnvironments } from '../common/utils';
-import { showErrorMessage, withProgress } from '../../common/window.apis';
-import { VenvManagerStrings } from '../../common/localize';
 
 export class VenvManager implements EnvironmentManager {
     private collection: PythonEnvironment[] = [];
@@ -215,7 +215,7 @@ export class VenvManager implements EnvironmentManager {
         if (this.skipWatcherRefresh) {
             return;
         }
-        return this.internalRefresh(undefined, false, VenvManagerStrings.venvRefreshing);
+        return this.internalRefresh(undefined, true, VenvManagerStrings.venvRefreshing);
     }
 
     private async internalRefresh(