updates based on feedback

Author: eleanorjboyd

src/features/creators/creationHelpers.ts

@@ -1,8 +1,8 @@
 import { window, extensions, Uri } from 'vscode';
 import * as fs from 'fs-extra';
 import * as path from 'path';
-import { EnvironmentManagers } from '../../internal.api';
-import { CreateEnvironmentOptions, EnvironmentManager } from '../../api';
+import { EnvironmentManagers, InternalEnvironmentManager } from '../../internal.api';
+import { CreateEnvironmentOptions } from '../../api';
 import { traceVerbose } from '../../common/logging';
 
 /**
@@ -68,31 +68,32 @@ export async function removeCopilotInstructions(destFolder: string) {
 export async function quickCreateNewVenv(envManagers: EnvironmentManagers, destFolder: string) {
     try {
         // get the environment manager for venv
-        const envManager: EnvironmentManager | undefined = envManagers.managers.find(
+        const envManager: InternalEnvironmentManager | undefined = envManagers.managers.find(
             (m) => m.id === 'ms-python.python:venv',
         );
         const destUri = Uri.parse(destFolder);
-        if (envManager && envManager.create) {
+        if (envManager?.supportsQuickCreate) {
             // with quickCreate enabled, user will not be prompted when creating the environment
             const options: CreateEnvironmentOptions = { quickCreate: false };
-            if (envManager.quickCreateConfig) {
+            if (envManager.supportsQuickCreate) {
                 options.quickCreate = true;
             }
             const pyEnv = await envManager.create(destUri, options);
             // comes back as undefined if this doesn't work
             traceVerbose(`Created venv at: ${pyEnv?.environmentPath} using ${envManager.name}`);
         } else {
-            // find an environment manager that supports create
-            const envManager = envManagers.managers.find((m) => m.create);
-            if (envManager) {
-                const options: CreateEnvironmentOptions = { quickCreate: true, additionalPackages: [] };
-                const pyEnv = await envManager.create(destUri, options);
-                traceVerbose(`Created venv at: ${pyEnv?.environmentPath} using ${envManager.name}`);
-            }
-            // If no environment manager supports create, show an error message
-            window.showErrorMessage(
-                `No environment manager found that supports creating a new environment, skipping...`,
-            );
+            // // find an environment manager that supports create
+            // const envManager = envManagers.managers.find((m) => m.supportsCreate);
+            // if (envManager) {
+            //     const options: CreateEnvironmentOptions = { quickCreate: true, additionalPackages: [] };
+            //     const pyEnv = await envManager.create(destUri, options);
+            //     traceVerbose(`Created venv at: ${pyEnv?.environmentPath} using ${envManager.name}`);
+            // }
+            // // If no environment manager supports create, show an error message
+            // window.showErrorMessage(
+            //     `No environment manager found that supports creating a new environment, skipping...`,
+            // );
+            //TODO: just throw error
         }
     } catch (err) {
         window.showErrorMessage(`Failed to create virtual environment: ${err}`);

src/features/creators/newPackageProject.ts

@@ -23,7 +23,7 @@ export class NewPackageProject implements PythonProjectCreator {
     constructor(private readonly envManagers: EnvironmentManagers) {}
 
     async create(_options?: PythonProjectCreatorOptions): Promise<PythonProject | undefined> {
-        // Prompt for package name
+        // Prompt for package name (TODO: this doesn't make sense if the _options is already being passed in )
         const packageName = await window.showInputBox({
             prompt: 'What is the name of the package? (e.g. my_package)',
             ignoreFocusOut: true,

src/features/creators/templates/newPackageTemplate/.github/copilot-instructions.md

@@ -1,8 +1,10 @@
 # Copilot Instructions for package_name
 
--   This is a Python package named `package_name`.
--   Follow PEP8 style guidelines.
--   Use relative imports within the package.
--   Write clear docstrings for all public functions and classes.
--   Add or update tests in the `tests/` directory for new features or bug fixes and use pytest.
--   Use the provided `launch.json` for debugging configurations.
+-   The package `<package_name>` is a Python Project located in the folder `<package_name>-folder`.
+-   You need to call the `Get Python Environment Information` tool on the <package_name> path to get the Python executable details.
+-   Substitute the Python executable you get from the `Get Python Environment Information` tool anywhere you see <python> in these instructions.
+    -   Run command for `<package_name>`: `<python> -m <package_name>`
+    -   Command to run tests for `<package_name>`: `<python> -m pytest <package_name>/tests`
+-   To run an editable install for the package `<package_name>`, use the `Install Python Package` tool with the `<package_name>-folder` path and arguments ['-e', '.'].
+-   In the workspace `launch.json` file, configurations related to this package have the prefix `<package_name>`.
+-   The package `<package_name>` has a defined `pyproject.toml` file that you should use and keep up to date.