fix: ensure delete env message is modal

Author: karthiknadig

src/common/window.apis.ts

@@ -7,6 +7,8 @@ import {
     InputBox,
     InputBoxOptions,
     LogOutputChannel,
+    MessageItem,
+    MessageOptions,
     OpenDialogOptions,
     OutputChannel,
     Progress,
@@ -284,7 +286,19 @@ export async function showInputBoxWithButtons(
     }
 }
 
-export function showWarningMessage(message: string, ...items: string[]): Thenable<string | undefined> {
+export function showWarningMessage<T extends string>(message: string, ...items: T[]): Thenable<T | undefined>;
+export function showWarningMessage<T extends string>(
+    message: string,
+    options: MessageOptions,
+    ...items: T[]
+): Thenable<T | undefined>;
+export function showWarningMessage<T extends MessageItem>(message: string, ...items: T[]): Thenable<T | undefined>;
+export function showWarningMessage<T extends MessageItem>(
+    message: string,
+    options: MessageOptions,
+    ...items: T[]
+): Thenable<T | undefined>;
+export function showWarningMessage(message: string, ...items: any[]): Thenable<string | undefined> {
     return window.showWarningMessage(message, ...items);
 }
 

src/managers/builtin/venvUtils.ts

@@ -459,10 +459,13 @@ export async function removeVenv(environment: PythonEnvironment, log: LogOutputC
 
     const confirm = await showWarningMessage(
         l10n.t('Are you sure you want to remove {0}?', envPath),
-        Common.yes,
-        Common.no,
+        {
+            modal: true,
+        },
+        { title: Common.yes },
+        { title: Common.no, isCloseAffordance: true },
     );
-    if (confirm === Common.yes) {
+    if (confirm?.title === Common.yes) {
         await withProgress(
             {
                 location: ProgressLocation.Notification,