Skip to content

Commit b71a68e

Browse files
committed
update from comments
1 parent bbb6a07 commit b71a68e

5 files changed

Lines changed: 3 additions & 14 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
"type": "boolean",
133133
"description": "%python-envs.alwaysUseUv.description%",
134134
"default": true,
135-
"scope": "resource"
135+
"scope": "machine"
136136
}
137137
}
138138
},

src/managers/builtin/helpers.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ export function resetUvInstallationCache(): void {
1616
}
1717

1818
export async function isUvInstalled(log?: LogOutputChannel): Promise<boolean> {
19-
console.log('into isUvInstalled function');
2019
if (available.completed) {
21-
console.log('UV installation status already determined');
2220
return available.promise;
2321
}
2422
log?.info(`Running: uv --version`);
@@ -46,9 +44,6 @@ export async function shouldUseUv(log?: LogOutputChannel, envPath?: string): Pro
4644
if (envPath) {
4745
// always use uv if the given environment is stored as a uv env
4846
const uvEnvs = await getUvEnvironments();
49-
console.log(`UV Environments: ${uvEnvs.join(', ')}`);
50-
console.log(`Checking if envPath ${envPath} is in UV environments`);
51-
console.log(`isUVinstalled function: ${isUvInstalled(log)}`);
5247
if (uvEnvs.includes(envPath)) {
5348
return await isUvInstalled(log);
5449
}
@@ -58,12 +53,7 @@ export async function shouldUseUv(log?: LogOutputChannel, envPath?: string): Pro
5853
const config = getConfiguration('python-envs');
5954
const alwaysUseUv = config.get<boolean>('alwaysUseUv', true);
6055

61-
console.log(`alwaysUseUv setting is ${alwaysUseUv}`);
62-
console.log(config.inspect<boolean>('alwaysUseUv'));
63-
console.log(config.inspect<boolean>('alwaysUseUv')?.globalValue);
64-
6556
if (alwaysUseUv) {
66-
console.log(`alwaysUseUv is true, checking if UV is installed`);
6757
return await isUvInstalled(log);
6858
}
6959
return false;

src/managers/builtin/pipManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {
22
CancellationError,
3+
Disposable,
34
Event,
45
EventEmitter,
56
LogOutputChannel,
@@ -8,7 +9,6 @@ import {
89
ThemeIcon,
910
window,
1011
} from 'vscode';
11-
import { Disposable } from 'vscode-jsonrpc';
1212
import {
1313
DidChangePackagesEventArgs,
1414
IconPath,

src/managers/builtin/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ async function refreshPipPackagesRaw(environment: PythonEnvironment, log?: LogOu
149149
} catch (ex) {
150150
log?.error('Error running pip list', ex);
151151
log?.info(
152-
'Installation attempted using pip, action can be done with uv if installed and setting `alwaysUseUv` is enabled.',
152+
'Package list retrieval attempted using pip, action can be done with uv if installed and setting `alwaysUseUv` is enabled.',
153153
);
154154
throw ex;
155155
}

src/managers/builtin/venvUtils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,6 @@ export async function resolveVenvPythonEnvironmentPath(
476476

477477
if (resolved.kind === NativePythonEnvironmentKind.venv || resolved.kind === NativePythonEnvironmentKind.venvUv) {
478478
const envInfo = await getPythonInfo(resolved);
479-
// can't decide on if I need anything here....
480479
return api.createPythonEnvironmentItem(envInfo, manager);
481480
}
482481

0 commit comments

Comments
 (0)