Skip to content

Commit bb30e4f

Browse files
Copilotkarthiknadig
andcommitted
Address code review feedback: remove comment and simplify progress message
Co-authored-by: karthiknadig <3840081+karthiknadig@users.noreply.github.com>
1 parent 9861198 commit bb30e4f

2 files changed

Lines changed: 7 additions & 12 deletions

File tree

src/managers/builtin/venvManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export class VenvManager implements EnvironmentManager {
6666
public readonly onDidChangeEnvironments = this._onDidChangeEnvironments.event;
6767

6868
readonly name: string;
69-
displayName: string; // Made mutable to update with uv detection
69+
displayName: string;
7070
readonly preferredPackageManagerId: string;
7171
readonly description?: string | undefined;
7272
readonly tooltip?: string | MarkdownString | undefined;

src/managers/builtin/venvUtils.ts

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -306,17 +306,12 @@ async function createWithProgress(
306306
os.platform() === 'win32' ? path.join(envPath, 'Scripts', 'python.exe') : path.join(envPath, 'bin', 'python');
307307

308308
const useUv = await isUvInstalled(log);
309-
const progressTitle = useUv
310-
? l10n.t(
311-
'Creating virtual environment named {0} using python version {1} [uv].',
312-
path.basename(envPath),
313-
basePython.version,
314-
)
315-
: l10n.t(
316-
'Creating virtual environment named {0} using python version {1}.',
317-
path.basename(envPath),
318-
basePython.version,
319-
);
309+
const progressTitle = l10n.t(
310+
'Creating virtual environment named {0} using python version {1}{2}.',
311+
path.basename(envPath),
312+
basePython.version,
313+
useUv ? ' [uv]' : '',
314+
);
320315

321316
return await withProgress(
322317
{

0 commit comments

Comments
 (0)