Fire onDidChangeEnvironment for global and single-Uri scopes in set() (#1458)

Part of
#1454

## Bug

`CondaEnvManager.set()` only fires `_onDidChangeEnvironment` in the
`Uri[]` (multi-project) branch. The `scope === undefined` (global) and
`scope instanceof Uri` (single project) branches persist the selection
and update internal maps, but never fire the change event.

The `venvManager.ts` correctly fires the event in all three branches
(lines 413, 444, 477), so this is an inconsistency specific to the conda
manager.

## Why it's a bug

There are code paths that call `manager.set()` **directly**, bypassing
the orchestrator's `setEnvironment()`:

1. **`envCommands.ts:220`** — After creating a conda environment in the
"global" (no workspace) context, calls `manager.set(undefined, env)`
directly.
2. **`extension.ts:344`** — When removing a project, calls
`manager.set(uri, undefined)` directly.
3. **`envManagers.ts:404` and `:434`** — Batch operations that call
`manager.set()` directly for individual items.

When these code paths run, the orchestrator's `setEnvironment()` is
never involved, so it never fires its own
`_onDidChangeEnvironmentFiltered` event. The **only** way listeners can
be notified is through the manager-level `_onDidChangeEnvironment` —
which conda doesn't fire.

### Event chain that breaks

```
manager.set(undefined, env)              // called directly, not through orchestrator
  → conda persists to disk ✅
  → conda updates in-memory state ✅
  → conda fires _onDidChangeEnvironment ❌  (BUG)

envManagers._onDidChangeEnvironment      // relayed from manager event → never fires
  → extension.ts:511 updateViewsAndStatus  ❌
  → projectView.ts:62 tree refresh        ❌

pythonApi._onDidChangeEnvironment        // driven by _onDidChangeEnvironmentFiltered → never fires
  → shellStartupActivationVariablesManager ❌  (terminal activation not updated)
  → 3rd party extensions                   ❌
```

### What the orchestrator masks

When the user selects an environment through the normal UI picker, the
orchestrator's `setEnvironment()` calls `manager.set()` and then fires
`_onDidChangeEnvironmentFiltered` independently. This masks the missing
manager event for that specific flow. But the direct-call paths above
are not masked.

## Repro steps

**Primary repro (global create flow):**
1. Open VS Code with **no workspace folder open**.
2. Run "Python: Create Environment" from the command palette.
3. Select Conda, choose a name and Python version.
4. The environment is created successfully and `manager.set(undefined,
env)` is called at `envCommands.ts:220`.
5. **Bug:** The status bar still shows the old/no environment. The
project view doesn't update. Terminal activation doesn't change. The UI
appears frozen even though the environment was created and set
internally.

**Secondary repro (project removal):**
1. Open a multi-root workspace with a Python project using a conda
environment.
2. Remove the project from the workspace.
3. `manager.set(uri, undefined)` is called at `extension.ts:344` to
clear the environment.
4. **Bug:** Listeners don't know the environment was cleared — stale
state remains in views and terminal activation.

## Fix

1. **Global scope (`scope === undefined`)**: Capture the "before" state,
update `this.globalEnv`, persist, then fire `_onDidChangeEnvironment` if
the environment actually changed.
2. **Single Uri scope (`scope instanceof Uri`)**: Capture the "before"
state from the map before updating, then fire `_onDidChangeEnvironment`
if the environment actually changed.

Both branches now follow the same pattern as the `Uri[]` branch and the
`venvManager.ts` implementation.

Before:

https://github.com/user-attachments/assets/5ec01adc-caeb-4db6-9620-deb0662b92f8

After:

https://github.com/user-attachments/assets/08baeceb-e9b7-45d4-9e5c-83792641fda6


## Why this fix is correct

- Events are only fired when the environment actually changes
(`before?.envId.id !== checkedEnv?.envId.id`), preventing spurious
notifications.
- The in-memory `globalEnv` update ensures `get(undefined)` returns the
correct value immediately after `set()`.
- No change to the `Uri[]` branch, which was already working correctly.
- The change is purely additive — existing behavior is preserved,
missing behavior is added.
- For the normal picker flow (through the orchestrator), the manager
event is now fired in addition to the orchestrator's event. This is
consistent with venvManager and harmless — listeners that receive both
just get a redundant but correct notification.

## Tests added

- `condaEnvManager.setEvents.unit.test.ts`: 5 test cases covering:
  - Global scope fires event
  - Global scope does not fire event when unchanged
  - Single Uri scope fires event
  - Single Uri scope does not fire event when unchanged
  - Clearing an environment (set to undefined) fires event

Author: StellaHuang95

src/managers/conda/condaEnvManager.ts

@@ -311,7 +311,12 @@ export class CondaEnvManager implements EnvironmentManager, Disposable {
             : undefined;
 
         if (scope === undefined) {
+            const before = this.globalEnv;
+            this.globalEnv = checkedEnv;
             await setCondaForGlobal(checkedEnv?.environmentPath?.fsPath);
+            if (before?.envId.id !== checkedEnv?.envId.id) {
+                this._onDidChangeEnvironment.fire({ uri: undefined, old: before, new: checkedEnv });
+            }
         } else if (scope instanceof Uri) {
             const folder = this.api.getPythonProject(scope);
             const fsPath = folder?.uri?.fsPath ?? scope.fsPath;
@@ -327,12 +332,16 @@ export class CondaEnvManager implements EnvironmentManager, Disposable {
                 }
 
                 const normalizedFsPath = normalizePath(fsPath);
+                const before = this.fsPathToEnv.get(normalizedFsPath);
                 if (checkedEnv) {
                     this.fsPathToEnv.set(normalizedFsPath, checkedEnv);
                 } else {
                     this.fsPathToEnv.delete(normalizedFsPath);
                 }
                 await setCondaForWorkspace(fsPath, checkedEnv?.environmentPath.fsPath);
+                if (before?.envId.id !== checkedEnv?.envId.id) {
+                    this._onDidChangeEnvironment.fire({ uri: scope, old: before, new: checkedEnv });
+                }
             }
         } else if (Array.isArray(scope) && scope.every((u) => u instanceof Uri)) {
             const projects: PythonProject[] = [];

src/test/managers/conda/condaEnvManager.setEvents.unit.test.ts

@@ -0,0 +1,149 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+import assert from 'assert';
+import * as sinon from 'sinon';
+import { Uri } from 'vscode';
+import { DidChangeEnvironmentEventArgs, PythonEnvironment, PythonEnvironmentApi, PythonProject } from '../../../api';
+import { normalizePath } from '../../../common/utils/pathUtils';
+import { PythonEnvironmentImpl } from '../../../internal.api';
+import { CondaEnvManager } from '../../../managers/conda/condaEnvManager';
+import * as condaUtils from '../../../managers/conda/condaUtils';
+import { NativePythonFinder } from '../../../managers/common/nativePythonFinder';
+
+function makeEnv(name: string, envPath: string, version: string = '3.12.0'): PythonEnvironment {
+    return new PythonEnvironmentImpl(
+        { id: `${name}-test`, managerId: 'ms-python.python:conda' },
+        {
+            name,
+            displayName: `${name} (${version})`,
+            displayPath: envPath,
+            version,
+            environmentPath: Uri.file(envPath),
+            sysPrefix: envPath,
+            execInfo: {
+                run: { executable: 'python' },
+            },
+        },
+    );
+}
+
+function createManager(apiOverrides?: Partial<PythonEnvironmentApi>): CondaEnvManager {
+    const api = {
+        getPythonProject: sinon.stub().returns(undefined),
+        ...apiOverrides,
+    } as any as PythonEnvironmentApi;
+    const manager = new CondaEnvManager(
+        {} as NativePythonFinder,
+        api,
+        { info: sinon.stub(), error: sinon.stub(), warn: sinon.stub() } as any,
+    );
+    (manager as any)._initialized = { completed: true, promise: Promise.resolve() };
+    (manager as any).collection = [];
+    return manager;
+}
+
+suite('CondaEnvManager.set - onDidChangeEnvironment event firing', () => {
+    let checkNoPythonStub: sinon.SinonStub;
+
+    setup(() => {
+        sinon.stub(condaUtils, 'setCondaForGlobal').resolves();
+        sinon.stub(condaUtils, 'setCondaForWorkspace').resolves();
+        checkNoPythonStub = sinon.stub(condaUtils, 'checkForNoPythonCondaEnvironment');
+    });
+
+    teardown(() => {
+        sinon.restore();
+    });
+
+    test('set(undefined, env) fires onDidChangeEnvironment for global scope', async () => {
+        const manager = createManager();
+        const oldEnv = makeEnv('base', '/miniconda3', '3.11.0');
+        const newEnv = makeEnv('myenv', '/miniconda3/envs/myenv', '3.12.0');
+        (manager as any).globalEnv = oldEnv;
+        checkNoPythonStub.resolves(newEnv);
+
+        const events: DidChangeEnvironmentEventArgs[] = [];
+        manager.onDidChangeEnvironment((e) => events.push(e));
+
+        await manager.set(undefined, newEnv);
+
+        assert.strictEqual(events.length, 1, 'should fire exactly one event');
+        assert.strictEqual(events[0].uri, undefined, 'uri should be undefined for global scope');
+        assert.strictEqual(events[0].old, oldEnv);
+        assert.strictEqual(events[0].new, newEnv);
+    });
+
+    test('set(undefined, env) does not fire event when env is unchanged', async () => {
+        const manager = createManager();
+        const env = makeEnv('base', '/miniconda3', '3.11.0');
+        (manager as any).globalEnv = env;
+        checkNoPythonStub.resolves(env);
+
+        const events: DidChangeEnvironmentEventArgs[] = [];
+        manager.onDidChangeEnvironment((e) => events.push(e));
+
+        await manager.set(undefined, env);
+
+        assert.strictEqual(events.length, 0, 'should not fire event when env is unchanged');
+    });
+
+    test('set(Uri, env) fires onDidChangeEnvironment for single Uri scope', async () => {
+        const projectUri = Uri.file('/workspace/project');
+        const project = { uri: projectUri, name: 'project' } as PythonProject;
+        const manager = createManager({
+            getPythonProject: sinon.stub().returns(project) as any,
+        });
+        const newEnv = makeEnv('myenv', '/miniconda3/envs/myenv', '3.12.0');
+        checkNoPythonStub.resolves(newEnv);
+
+        const events: DidChangeEnvironmentEventArgs[] = [];
+        manager.onDidChangeEnvironment((e) => events.push(e));
+
+        await manager.set(projectUri, newEnv);
+
+        assert.strictEqual(events.length, 1, 'should fire exactly one event');
+        assert.strictEqual(events[0].uri, projectUri);
+        assert.strictEqual(events[0].old, undefined);
+        assert.strictEqual(events[0].new, newEnv);
+    });
+
+    test('set(Uri, env) does not fire event when env is unchanged', async () => {
+        const projectUri = Uri.file('/workspace/project');
+        const project = { uri: projectUri, name: 'project' } as PythonProject;
+        const manager = createManager({
+            getPythonProject: sinon.stub().returns(project) as any,
+        });
+        const env = makeEnv('myenv', '/miniconda3/envs/myenv', '3.12.0');
+        checkNoPythonStub.resolves(env);
+
+        // Pre-populate the map with the same env
+        (manager as any).fsPathToEnv.set(normalizePath(projectUri.fsPath), env);
+
+        const events: DidChangeEnvironmentEventArgs[] = [];
+        manager.onDidChangeEnvironment((e) => events.push(e));
+
+        await manager.set(projectUri, env);
+
+        assert.strictEqual(events.length, 0, 'should not fire event when env is unchanged');
+    });
+
+    test('set(Uri, undefined) fires event when clearing environment', async () => {
+        const projectUri = Uri.file('/workspace/project');
+        const project = { uri: projectUri, name: 'project' } as PythonProject;
+        const manager = createManager({
+            getPythonProject: sinon.stub().returns(project) as any,
+        });
+        const oldEnv = makeEnv('myenv', '/miniconda3/envs/myenv', '3.12.0');
+
+        // Pre-populate the map
+        (manager as any).fsPathToEnv.set(normalizePath(projectUri.fsPath), oldEnv);
+
+        const events: DidChangeEnvironmentEventArgs[] = [];
+        manager.onDidChangeEnvironment((e) => events.push(e));
+
+        await manager.set(projectUri, undefined);
+
+        assert.strictEqual(events.length, 1, 'should fire event when clearing');
+        assert.strictEqual(events[0].old, oldEnv);
+        assert.strictEqual(events[0].new, undefined);
+    });
+});