fix tests

Author: eleanorjboyd

src/test/managers/builtin/helpers.shouldUseUv.unit.test.ts

@@ -31,16 +31,12 @@ suite('Helpers - shouldUseUv', () => {
             clear: sinon.stub(),
         };
         getWorkspacePersistentStateStub.returns(Promise.resolve(mockPersistentState));
-        // By default, return empty UV environments list
-        mockPersistentState.get.resolves([]);
 
         // Mock UV-related functions
         isUvInstalledStub = sinon.stub(helpers, 'isUvInstalled');
         getUvEnvironmentsStub = sinon.stub(uvEnvironments, 'getUvEnvironments');
 
-        // Set default behaviors
-        isUvInstalledStub.resolves(false); // Default to UV not installed
-        getUvEnvironmentsStub.resolves([]); // Default to no UV environments
+        // No default behaviors set - each test configures what it needs
         // Create a more complete mock for LogOutputChannel
         mockLog = {
             info: sinon.stub(),
@@ -66,88 +62,93 @@ suite('Helpers - shouldUseUv', () => {
     });
 
     test('should return true when alwaysUseUv is true and UV is installed', async () => {
-        // Arrange: alwaysUseUv is true and UV is installed
+        // Mock - alwaysUseUv is true and UV is installed
         mockConfig.get.withArgs('alwaysUseUv', true).returns(true);
         isUvInstalledStub.resolves(true);
+        getUvEnvironmentsStub.resolves([]);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog);
 
-        // Assert: Should return true when setting is true and UV is installed
+        // Assert - Should return true when setting is true and UV is installed
         assert.strictEqual(result, true);
     });
 
     test('should return false when alwaysUseUv is false', async () => {
-        // Arrange: alwaysUseUv is false
+        // Mock - alwaysUseUv is false
         mockConfig.get.withArgs('alwaysUseUv', true).returns(false);
+        getUvEnvironmentsStub.resolves([]);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog);
 
-        // Assert: Should not use UV when setting is false
+        // Assert - Should not use UV when setting is false
         assert.strictEqual(result, false);
     });
 
     test('should return true for UV environment path when UV is installed', async () => {
-        // Arrange: Mock UV environments list with test path and UV is installed
+        // Mock - UV environments list with test path and UV is installed
         const uvEnvPath = '/path/to/uv/env';
-        getUvEnvironmentsStub.resolves([uvEnvPath]); // Mock the UV env in the list
-        isUvInstalledStub.resolves(true); // Mock UV as installed
+        getUvEnvironmentsStub.resolves([uvEnvPath]);
+        isUvInstalledStub.resolves(true);
         mockConfig.get.withArgs('alwaysUseUv', true).returns(false);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog, uvEnvPath);
 
-        // Assert: Should return true for UV environments when UV is installed
+        // Assert - Should return true for UV environments when UV is installed
         assert.strictEqual(result, true);
     });
 
     test('should return false for non-UV environment when alwaysUseUv is false', async () => {
-        // Arrange: Non-UV environment, alwaysUseUv is false
+        // Mock - Non-UV environment, alwaysUseUv is false
         const nonUvEnvPath = '/path/to/regular/env';
         mockConfig.get.withArgs('alwaysUseUv', true).returns(false);
+        getUvEnvironmentsStub.resolves([]);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog, nonUvEnvPath);
 
-        // Assert: Should not use UV for non-UV environments when setting is false
+        // Assert - Should not use UV for non-UV environments when setting is false
         assert.strictEqual(result, false);
     });
 
     test('should check setting when alwaysUseUv is true for non-UV environment', async () => {
-        // Arrange: Non-UV environment, alwaysUseUv is true, UV is installed
+        // Mock - Non-UV environment, alwaysUseUv is true, UV is installed
         const nonUvEnvPath = '/path/to/regular/env';
         mockConfig.get.withArgs('alwaysUseUv', true).returns(true);
-        isUvInstalledStub.resolves(true); // UV is installed
-        getUvEnvironmentsStub.resolves([]); // No UV environments (so path is not UV)
+        isUvInstalledStub.resolves(true);
+        getUvEnvironmentsStub.resolves([]);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog, nonUvEnvPath);
 
-        // Assert: Should return true when alwaysUseUv is true and UV is installed
+        // Assert - Should return true when alwaysUseUv is true and UV is installed
         assert.strictEqual(result, true);
     });
 
     test('should use default value true when alwaysUseUv setting is not configured', async () => {
-        // Arrange: Setting not configured, should use default of true, UV is installed
+        // Mock - Setting not configured, should use default of true, UV is installed
         mockConfig.get.withArgs('alwaysUseUv', true).returns(true);
         isUvInstalledStub.resolves(true);
+        getUvEnvironmentsStub.resolves([]);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog);
 
-        // Assert: Should return true with default setting when UV is installed
+        // Assert - Should return true with default setting when UV is installed
         assert.strictEqual(result, true);
     });
 
     test('should respect alwaysUseUv setting when no environment path provided', async () => {
-        // Arrange: No environment path specified, alwaysUseUv is false
+        // Mock - No environment path specified, alwaysUseUv is false
         mockConfig.get.withArgs('alwaysUseUv', true).returns(false);
+        getUvEnvironmentsStub.resolves([]);
 
-        // Act
+        // Run
         const result = await shouldUseUv(mockLog);
 
-        // Assert: Should not use UV when setting is false
+        // Assert - Should not use UV when setting is false
         assert.strictEqual(result, false);
     });
 });