Merge pull request #312243 from microsoft/revert-311606-dev/mjbvz/advisory-swallow

Revert "Use main eslint config for copilot extension too"

Author: mjbvz

.eslint-ignore

@@ -1,25 +1,9 @@
 **/build/*/**/*.js
-**/dist/**/*
+**/dist/**/*.js
 **/extensions/**/*.d.ts
 **/extensions/**/build/**
 **/extensions/**/colorize-fixtures/**
-**/extensions/copilot/coverage/**
-**/extensions/copilot/.esbuild/**
-**/extensions/copilot/.simulation/**
-**/extensions/copilot/.eslintplugin/**
-**/extensions/copilot/chat-lib/**
-**/extensions/copilot/test/simulation/fixtures/**
-**/extensions/copilot/test/scenarios/**
-**/extensions/copilot/test/aml/out/**
-**/extensions/copilot/src/util/vs/**
-**/extensions/copilot/src/platform/parser/test/node/fixtures/**
-**/extensions/copilot/src/extension/test/node/fixtures/**
-**/extensions/copilot/src/extension/prompts/node/test/fixtures/**
-**/extensions/copilot/src/extension/typescriptContext/serverPlugin/fixtures/**
-**/extensions/copilot/src/extension/typescriptContext/serverPlugin/lib/**
-**/extensions/copilot/src/extension/typescriptContext/serverPlugin/dist/**
-**/extensions/copilot/src/extension/completions-core/**/testdata/*
-**/extensions/copilot/.vscode/extensions/test-extension/dist/**
+**/extensions/copilot/**
 **/extensions/css-language-features/server/test/pathCompletionFixtures/**
 **/extensions/html-language-features/server/lib/jquery.d.ts
 **/extensions/html-language-features/server/src/test/pathCompletionFixtures/**
@@ -52,5 +36,4 @@
 **/test/automation/out/**
 **/typings/**
 **/.build/**
-**/.vscode-test/**
 !.vscode

.github/workflows/pr.yml

@@ -288,6 +288,10 @@ jobs:
         working-directory: extensions/copilot
         run: npm run typecheck
 
+      - name: Lint
+        working-directory: extensions/copilot
+        run: npm run lint
+
       - name: Compile
         working-directory: extensions/copilot
         run: npm run compile
@@ -383,6 +387,10 @@ jobs:
         working-directory: extensions/copilot
         run: npm run typecheck
 
+      - name: Lint
+        working-directory: extensions/copilot
+        run: npm run lint
+
       - name: Compile
         working-directory: extensions/copilot
         run: npm run compile

build/filters.ts

@@ -233,8 +233,10 @@ export const tsFormattingFilter = Object.freeze<string[]>([
 ]);
 
 export const eslintFilter = Object.freeze<string[]>([
-	'**/*.{js,cjs,mjs}',
-	'**/*.{ts,tsx,mts,cts}',
+	'**/*.js',
+	'**/*.cjs',
+	'**/*.mjs',
+	'**/*.ts',
 	'.eslint-plugin-local/**/*.ts',
 	...readFileSync(join(import.meta.dirname, '..', '.eslint-ignore'))
 		.toString()

build/hygiene.ts

@@ -314,6 +314,20 @@ if (import.meta.main) {
 						}
 					}
 
+					// Run copilot pre-commit checks if copilot files are staged
+					if (some.some(f => f.startsWith('extensions/copilot/'))) {
+						console.log('Running copilot pre-commit checks...');
+						const result = cp.spawnSync('npx', ['lint-staged'], {
+							cwd: path.join(process.cwd(), 'extensions', 'copilot'),
+							stdio: 'inherit',
+							shell: true,
+						});
+						if (result.status !== 0) {
+							console.error('Copilot pre-commit checks failed.');
+							process.exit(1);
+						}
+					}
+
 					console.log('Reading git index versions...');
 
 					createGitIndexVinyls(some)