update

Author: pwang347

.github/workflows/chat-perf.yml

@@ -32,6 +32,11 @@ on:
         required: false
         type: number
         default: 0.2
+      skip_leak_check:
+        description: 'Skip the memory leak check step'
+        required: false
+        type: boolean
+        default: true
 
 permissions:
   contents: read
@@ -132,6 +137,7 @@ jobs:
 
       - name: Run memory leak check
         id: leak
+        if: inputs.skip_leak_check != true
         run: |
           LEAK_ARGS="--verbose"
           if [[ -n "$TEST_COMMIT" ]]; then
@@ -154,7 +160,7 @@ jobs:
             echo "⚠️ No summary file generated. Check perf-output.log artifact." >> "$GITHUB_STEP_SUMMARY"
           fi
 
-          if [[ -f .chat-simulation-data/chat-simulation-leak-results.json ]]; then
+          if [[ "${{ inputs.skip_leak_check }}" != "true" && -f .chat-simulation-data/chat-simulation-leak-results.json ]]; then
             echo "" >> "$GITHUB_STEP_SUMMARY"
             echo "## Memory Leak Check" >> "$GITHUB_STEP_SUMMARY"
             echo "" >> "$GITHUB_STEP_SUMMARY"
@@ -192,12 +198,12 @@ jobs:
           retention-days: 30
 
       - name: Fail on regression
-        if: steps.perf.outcome == 'failure' || steps.leak.outcome == 'failure'
+        if: steps.perf.outcome == 'failure' || (inputs.skip_leak_check != true && steps.leak.outcome == 'failure')
         run: |
           if [[ "${{ steps.perf.outcome }}" == "failure" ]]; then
             echo "::error::Chat performance regression detected. See job summary for details."
           fi
-          if [[ "${{ steps.leak.outcome }}" == "failure" ]]; then
+          if [[ "${{ inputs.skip_leak_check }}" != "true" && "${{ steps.leak.outcome }}" == "failure" ]]; then
             echo "::error::Chat memory leak detected. See leak-output.log for details."
           fi
           exit 1

scripts/chat-simulation/test-chat-perf-regression.js

@@ -244,7 +244,7 @@ async function runOnce(electronPath, scenario, mockServer, verbose, runIndex, ru
 			await extHostInspector.send('Profiler.enable');
 			await extHostInspector.send('Profiler.start');
 			extHostHeapBefore = await extHostInspector.send('Runtime.getHeapUsage');
-			if (verbose) {
+			if (verbose && extHostHeapBefore) {
 				console.log(`  [ext-host] Heap before: ${Math.round(extHostHeapBefore.usedSize / 1024 / 1024)}MB`);
 			}
 		} catch (err) {
@@ -417,27 +417,32 @@ async function runOnce(electronPath, scenario, mockServer, verbose, runIndex, ru
 				await window.locator(actualInputSelector).pressSequentially(userTurn.message, { delay: 0 });
 			}
 
-			// Note current response count before submitting
-			const responseCountBefore = await window.evaluate((sel) => {
-				return document.querySelectorAll(sel).length;
-			}, responseSelector);
-
 			// Submit follow-up
 			const utCompBefore = mockServer.completionCount();
 			await window.keyboard.press('Enter');
 
 			// Wait for mock server to serve the response for this turn
 			try { await mockServer.waitForCompletion(utCompBefore + 1, 60_000); } catch { }
 
-			// Wait for a new response element to appear and settle
+			// Wait for the new response to finish rendering.
+			// The chat list is virtualized — old response elements are
+			// recycled out of the DOM as new ones appear, so we cannot
+			// rely on counting DOM elements. Instead, scroll to the
+			// bottom and wait for no response to be in loading state.
 			await dismissDialog();
+			await window.evaluate((chatViewSel) => {
+				const input = document.querySelector(chatViewSel + ' .interactive-input-part');
+				if (input) { input.scrollIntoView({ block: 'end' }); }
+			}, CHAT_VIEW);
+			await new Promise(r => setTimeout(r, 200));
+
 			await window.waitForFunction(
-				({ sel, prevCount }) => {
+				(sel) => {
 					const responses = document.querySelectorAll(sel);
-					if (responses.length <= prevCount) { return false; }
+					if (responses.length === 0) { return false; }
 					return !responses[responses.length - 1].classList.contains('chat-response-loading');
 				},
-				{ sel: responseSelector, prevCount: responseCountBefore },
+				responseSelector,
 				{ timeout: 30_000 },
 			);
 			responseCompleteTime = Date.now();