Fix for completing response if needed (#282336)

Author: osortega

src/vs/workbench/contrib/chat/common/chatModel.ts

@@ -1077,6 +1077,12 @@ export class ChatResponseModel extends Disposable implements IChatResponseModel
 		this._onDidChange.fire({ reason: 'completedRequest' });
 	}
 
+	completeResponseIfNeeded() {
+		if (!this.isComplete) {
+			this.complete();
+		}
+	}
+
 	cancel(): void {
 		this._modelState.set({ value: ResponseModelState.Cancelled, completedAt: Date.now() }, undefined);
 		this._onDidChange.fire({ reason: 'completedRequest' });

src/vs/workbench/contrib/chat/common/chatServiceImpl.ts

@@ -656,7 +656,7 @@ export class ChatService extends Disposable implements IChatService {
 		for (const message of providedSession.history) {
 			if (message.type === 'request') {
 				if (lastRequest) {
-					lastRequest.response?.complete();
+					lastRequest.response?.completeResponseIfNeeded();
 				}
 
 				const requestText = message.prompt;
@@ -698,7 +698,7 @@ export class ChatService extends Disposable implements IChatService {
 		}
 
 		if (providedSession.isCompleteObs?.get()) {
-			lastRequest?.response?.complete();
+			lastRequest?.response?.completeResponseIfNeeded();
 		}
 
 		if (providedSession.progressObs && lastRequest && providedSession.interruptActiveResponseCallback) {
@@ -737,15 +737,15 @@ export class ChatService extends Disposable implements IChatService {
 
 				// Handle completion
 				if (isComplete) {
-					lastRequest.response?.complete();
+					lastRequest.response?.completeResponseIfNeeded();
 					cancellationListener.clear();
 				}
 			}));
 		} else {
 			if (lastRequest && model.editingSession) {
 				// wait for timeline to load so that a 'changes' part is added when the response completes
 				await chatEditingSessionIsReady(model.editingSession);
-				lastRequest.response?.complete();
+				lastRequest.response?.completeResponseIfNeeded();
 			}
 		}