Merge pull request #2036 from mintlayer/add_version_response_to_binaries

App-version-related improvements

Author: ImplOfAnImpl

Cargo.lock

@@ -63,6 +63,7 @@ members = [
   "test-utils",                          # Various utilities for tests.
   "tokens-accounting",                   # Tokens accounting
   "utils",                               # Various utilities.
+  "utils/build_utils",                   # Build-related utilities.
   "utils/networking",                    # Various async/tokio utilities.
   "utxo",                                # Utxo and related utilities (cache, undo, etc.).
   "wallet",                              # Wallet primitives.
@@ -251,6 +252,7 @@ socket2 = "0.5"
 sscanf = "0.4"
 static_assertions = "1.1"
 strum = { version = "0.26", default-features = false, features = ["derive"] }
+substrate-build-script-utils = "11.0"
 syn = "2.0"
 tap = "1.0"
 tempfile = "3.3"

Cargo.toml

@@ -19,3 +19,6 @@ utils-networking = { path = "../../utils/networking" }
 clap = { workspace = true, features = ["derive"] }
 thiserror.workspace = true
 tokio = { workspace = true, features = ["full"] }
+
+[build-dependencies]
+build_utils = { path = "../../utils/build_utils" }

api-server/scanner-daemon/Cargo.toml

@@ -0,0 +1,18 @@
+// Copyright (c) 2026 RBB S.r.l
+// opensource@mintlayer.org
+// SPDX-License-Identifier: MIT
+// Licensed under the MIT License;
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// https://github.com/mintlayer/mintlayer-core/blob/master/LICENSE
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+fn main() {
+    build_utils::emit_git_env_vars();
+}

api-server/scanner-daemon/build.rs

@@ -16,11 +16,12 @@
 use clap::Parser;
 
 use api_server_common::{Network, PostgresConfig};
-use utils::clap_utils;
+use utils::{app_version_with_git_info, clap_utils};
 use utils_networking::NetworkAddressWithPort;
 
 #[derive(Parser, Debug)]
 #[clap(mut_args(clap_utils::env_adder("API_SCANNER_DAEMON")))]
+#[clap(version(app_version_with_git_info!().to_pretty_string()))]
 pub struct ApiServerScannerArgs {
     /// Network
     #[arg(long, value_enum, default_value_t = Network::Mainnet)]

api-server/scanner-daemon/src/config.rs

@@ -27,3 +27,6 @@ serde_json.workspace = true
 thiserror.workspace = true
 tokio = { workspace = true }
 tower-http = { workspace = true, features = ["cors"] }
+
+[build-dependencies]
+build_utils = { path = "../../utils/build_utils" }

api-server/web-server/Cargo.toml

@@ -0,0 +1,18 @@
+// Copyright (c) 2026 RBB S.r.l
+// opensource@mintlayer.org
+// SPDX-License-Identifier: MIT
+// Licensed under the MIT License;
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// https://github.com/mintlayer/mintlayer-core/blob/master/LICENSE
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+fn main() {
+    build_utils::emit_git_env_vars();
+}

api-server/web-server/build.rs

@@ -19,13 +19,14 @@ use clap::Parser;
 
 use api_server_common::{Network, PostgresConfig};
 use tokio::net::TcpListener;
-use utils::clap_utils;
+use utils::{app_version_with_git_info, clap_utils};
 use utils_networking::NetworkAddressWithPort;
 
 const LISTEN_ADDRESS: &str = "127.0.0.1:3000";
 
 #[derive(Debug, Parser)]
 #[clap(mut_args(clap_utils::env_adder("API_WEB_SRV")))]
+#[clap(version(app_version_with_git_info!().to_pretty_string()))]
 pub struct ApiServerWebServerConfig {
     /// Network
     /// Default: `testnet`

api-server/web-server/src/config.rs

@@ -4,10 +4,13 @@
 import fnmatch
 import itertools
 import os
+import pathlib
 import re
 import sys
 import tomllib
 
+PROJECT_ROOT_DIR = pathlib.Path(__file__).resolve().parent.parent.parent
+
 SCALECODEC_RE = r'\bparity_scale_codec(_derive)?::'
 JSONRPSEE_RE = r'\bjsonrpsee[_a-z0-9]*::'
 
@@ -145,6 +148,32 @@ def check_workspace_and_package_versions_equal():
     return result
 
 
+# Ensure that each crate's Cargo.toml has a version field and it's always "version.workspace = true".
+def check_crate_version_inherits_workspace_version():
+    print("==== Ensuring that each crate's version inherits its value from the workspace")
+
+    result = True
+
+    for path in cargo_config_files():
+        path = pathlib.Path(path).resolve()
+        if path.name == "Cargo.toml" and not path.parent == PROJECT_ROOT_DIR:
+            with open(path, "rb") as file:
+                rel_path = path.relative_to(PROJECT_ROOT_DIR)
+                toml_file = tomllib.load(file)
+                version = toml_file["package"].get("version")
+
+                if version is None:
+                    print(f"{rel_path}: missing 'package.version', the version defaults to 0.0.0")
+                    result = False
+                elif not isinstance(version, dict) or version.get("workspace") != True:
+                    print(f"{rel_path}: the package version must be inherited from the workspace (use 'version.workspace = true')")
+                    result = False
+
+    print()
+
+    return result
+
+
 # Retrieve an item from arbitrarily nested dicts given a list of keys.
 # E.g. get_from_nested_dicts({'a': {'b': 1, 'c': 2}}, ['a', 'b']) will
 # return 1.
@@ -385,6 +414,7 @@ def run_checks():
         check_local_licenses(),
         check_crate_versions(),
         check_workspace_and_package_versions_equal(),
+        check_crate_version_inherits_workspace_version(),
         check_dependency_versions_patch_version(),
         check_todos(),
         check_trailing_whitespaces(),
@@ -393,5 +423,8 @@ def run_checks():
 
 
 if __name__ == '__main__':
+    # Note: this script expects the current directory to be the project root.
+    os.chdir(PROJECT_ROOT_DIR)
+
     if not run_checks():
         sys.exit(1)

build-tools/codecheck/codecheck.py

@@ -18,6 +18,11 @@ use std::str::FromStr;
 use serde::Serialize;
 use serialization::{Decode, Encode};
 
+// Note: this is not a real "semantic version" because it lacks the prerelease and build metadata
+// parts. However it's not easy to change, since it's part of the p2p protocol, namely the Hello
+// and HelloAck messages (also, it's probably not a good idea to send the additional info over
+// the network anyway).
+// TODO: perhaps it should be renamed at least.
 #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Encode, Decode, Copy, Clone, Serialize)]
 pub struct SemVer {
     pub major: u8,