Noah + Copilot feedback

Author: aclark4life

test/test_ocsp_support.py

@@ -171,9 +171,9 @@ def test_other_key_type(self):
         self.assertEqual(len(result), 20)
 
 
-class TestGetCertsByKeyHash(unittest.TestCase):
+class TestGetCerts(unittest.TestCase):
     @patch("pymongo.ocsp_support._public_key_hash")
-    def test_match(self, mock_hash):
+    def test_by_key_hash_match(self, mock_hash):
         issuer = Mock()
         issuer.subject = "issuer_subject"
         cert1 = Mock()
@@ -186,7 +186,7 @@ def test_match(self, mock_hash):
         self.assertEqual(result, [cert1])
 
     @patch("pymongo.ocsp_support._public_key_hash")
-    def test_no_match(self, mock_hash):
+    def test_by_key_hash_no_match(self, mock_hash):
         issuer = Mock()
         issuer.subject = "issuer_subject"
         cert = Mock()
@@ -196,9 +196,7 @@ def test_no_match(self, mock_hash):
         result = _get_certs_by_key_hash([cert], issuer, b"expected_hash")
         self.assertEqual(result, [])
 
-
-class TestGetCertsByName(unittest.TestCase):
-    def test_match(self):
+    def test_by_name_match(self):
         issuer = Mock()
         issuer.subject = "issuer"
         cert1 = Mock()
@@ -211,7 +209,7 @@ def test_match(self):
         result = _get_certs_by_name([cert1, cert2], issuer, "responder")
         self.assertEqual(result, [cert1])
 
-    def test_no_match(self):
+    def test_by_name_no_match(self):
         issuer = Mock()
         issuer.subject = "issuer"
         cert = Mock()
@@ -222,7 +220,7 @@ def test_no_match(self):
         self.assertEqual(result, [])
 
 
-class TestBuildOcspRequest(unittest.TestCase):
+class TestVerifyResponseSignature(unittest.TestCase):
     @patch("pymongo.ocsp_support._OCSPRequestBuilder")
     def test_builds_request(self, mock_builder_class):
         mock_builder = Mock()
@@ -237,8 +235,6 @@ def test_builds_request(self, mock_builder_class):
         mock_builder.add_certificate.assert_called_once()
         mock_builder.build.assert_called_once()
 
-
-class TestVerifyResponseSignature(unittest.TestCase):
     @patch("pymongo.ocsp_support._verify_signature")
     def test_responder_is_issuer_by_name(self, mock_verify_sig):
         mock_verify_sig.return_value = 1