feat: add 15 substitute players to database seed data

Added GetSubstitutes() and GetSubstitutesWithId() methods to
PlayerData utility, following the same pattern as Starting 11.
Created SeedSubstitutes migration to seed 15 substitute players with
squad numbers 1, 2, 4, 5, 6, 8, 12, 14, 15, 16, 17, 18, 21, 22, 25.

Database now contains 26 total players: 11 starting
(Starting11=true) and 15 substitutes (Starting11=false). All squad
numbers verified conflict-free.

Additional improvements:
- Fixed run-migrations-and-copy-database.sh to use storage/ path
- Updated copilot-instructions.md with correct database paths
- Removed obsolete Data/players-sqlite3.db file

Closes #332

Author: nanotaboada

.github/copilot-instructions.md

@@ -297,7 +297,7 @@ dotnet ef database update --project src/Dotnet.Samples.AspNetCore.WebApi
 **Important**: The `run-migrations-and-copy-database.sh` script:
 - Resets the placeholder database file
 - Runs all migrations
-- Copies the generated database from `bin/Debug/net8.0/Data/` to `Data/`
+- Copies the generated database from `bin/Debug/net8.0/storage/` to `storage/`
 - Requires `dotnet ef` CLI tool installed globally
 
 ### Docker Operations
@@ -325,9 +325,9 @@ docker compose down -v
 ## 🚨 Common Issues & Workarounds
 
 ### Database Path Issues
-- **SQLite database location**: `storage/players-sqlite3.db` relative to binary output
-- **Container storage**: `/storage/players-sqlite3.db` (mounted volume)
-- **Environment variable**: `STORAGE_PATH` can override the default path in containers
+- **Development**: `storage/players-sqlite3.db` (source, copied to `bin/Debug/net8.0/storage/` during build)
+- **Container**: Pre-seeded database copied from image `/app/hold/` to volume `/storage/` on first run
+- **Runtime**: Application uses `AppContext.BaseDirectory/storage/players-sqlite3.db`
 
 ### Validation Patterns
 - **FluentValidation** runs in the validator class for input format/structure

scripts/run-migrations-and-copy-database.sh

@@ -5,8 +5,8 @@ DATA_FILE="players-sqlite3.db"
 PROJECT_ROOT_PATH="src/Dotnet.Samples.AspNetCore.WebApi"
 PROJECT_BASE_PATH="$PROJECT_ROOT_PATH/bin/Debug/net8.0"
 
-SOURCE_FILE_PATH="$PROJECT_BASE_PATH/Data/$DATA_FILE"
-TARGET_FILE_PATH="$PROJECT_ROOT_PATH/Data/$DATA_FILE"
+SOURCE_FILE_PATH="$PROJECT_BASE_PATH/storage/$DATA_FILE"
+TARGET_FILE_PATH="$PROJECT_ROOT_PATH/storage/$DATA_FILE"
 
 log() {
     local emoji=$1

src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.Designer.cs

@@ -0,0 +1,62 @@
+using Dotnet.Samples.AspNetCore.WebApi.Utilities;
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Dotnet.Samples.AspNetCore.WebApi.Migrations
+{
+    /// <inheritdoc />
+    public partial class SeedSubstitutes : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            var substitutes = PlayerData.GetSubstitutesWithId();
+
+            foreach (var player in substitutes)
+            {
+                migrationBuilder.InsertData(
+                    table: "Players",
+                    columns:
+                    [
+                        "Id",
+                        "FirstName",
+                        "MiddleName",
+                        "LastName",
+                        "DateOfBirth",
+                        "SquadNumber",
+                        "Position",
+                        "AbbrPosition",
+                        "Team",
+                        "League",
+                        "Starting11"
+                    ],
+                    values: new object[]
+                    {
+                        player.Id,
+                        player.FirstName,
+                        player.MiddleName,
+                        player.LastName,
+                        player.DateOfBirth,
+                        player.SquadNumber,
+                        player.Position,
+                        player.AbbrPosition,
+                        player.Team,
+                        player.League,
+                        player.Starting11
+                    }
+                );
+            }
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            var substitutes = PlayerData.GetSubstitutesWithId();
+            foreach (var player in substitutes)
+            {
+                migrationBuilder.DeleteData(table: "Players", keyColumn: "Id", keyValue: player.Id);
+            }
+        }
+    }
+}

src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.cs

@@ -15,7 +15,7 @@ partial class PlayerDbContextModelSnapshot : ModelSnapshot
         protected override void BuildModel(ModelBuilder modelBuilder)
         {
 #pragma warning disable 612, 618
-            modelBuilder.HasAnnotation("ProductVersion", "9.0.4");
+            modelBuilder.HasAnnotation("ProductVersion", "9.0.11");
 
             modelBuilder.Entity("Dotnet.Samples.AspNetCore.WebApi.Models.Player", b =>
                 {