examples review

Author: neu-rah

examples/Button/platformio.ini

@@ -9,7 +9,7 @@
 
 
 [platformio]
-src_dir=Blink
+src_dir=Button
 ; lib_dir=~/Arduino/Libraries
 
 [env:nanoatmega328]

examples/Confirm/platformio.ini

@@ -18,7 +18,6 @@ board = nanoatmega328
 framework = arduino
 upload_port=/dev/ttyUSB*
 upload_flags=-V
-build_flags = -Wno-comment -Wno-reorder -Wno-strict-aliasing -Wno-builtin-macro-redefined
 
 ; [env:teensy31]
 ; platform = teensy

examples/ESP32/ClickEncoderTFT.ino …SP32/ClickEncoderTFT/ClickEncoderTFT.inoexamples/ESP32/ClickEncoderTFT.ino renamed to examples/ESP32/ClickEncoderTFT/ClickEncoderTFT.ino examples/ESP32/ClickEncoderTFT.ino renamed to examples/ESP32/ClickEncoderTFT/ClickEncoderTFT.ino

@@ -82,6 +82,7 @@ result adjustBrightness() {
     int pwm = int(2.55 * float(brightnessValue));
     analogWrite(LED_PIN, pwm);
   }
+  return proceed;
 }
 
 
@@ -147,7 +148,7 @@ MENU(mainMenu, "Main menu", doNothing, noEvent, wrapStyle
 
 //describing a menu output device without macros
 //define at least one panel for menu output
-const panel panels[] MEMMODE = {{0, 0, 128 / fontW, 64 / fontH}};
+constMEM panel panels[] MEMMODE = {{0, 0, 128 / fontW, 64 / fontH}};
 navNode* nodes[sizeof(panels) / sizeof(panel)]; //navNodes to store navigation status
 panelsList pList(panels, nodes, 1); //a list of panels and nodes
 idx_t tops[MAX_DEPTH] = {0, 0}; //store cursor positions for each level

examples/LCDs/PCF8574/include/readme.txt

@@ -9,8 +9,8 @@
 ; http://docs.platformio.org/page/projectconf.html
 
 [platformio]
-; src_dir=Button_Navigation
-src_dir=SSD1306Ascii
+src_dir=Button_Navigation
+; src_dir=SSD1306Ascii
 
 [env:adafruit_crickit_m0]
 board=adafruit_crickit_m0

examples/SSD1306Ascii/Button_Navigation/Button_Navigation.ino

@@ -249,8 +249,8 @@ altMENU(menu,birthDate,"Birth",doNothing,noEvent,noStyle,(systemStyles)(_asPad|M
   ,FIELD(day,"","",1,31,1,0,doNothing,noEvent,wrapStyle)
 );
 
-char* constMEM hexDigit MEMMODE="0123456789ABCDEF";
-char* constMEM hexNr[] MEMMODE={"0","x",hexDigit,hexDigit};
+const char* constMEM hexDigit MEMMODE="0123456789ABCDEF";
+const char* constMEM hexNr[] MEMMODE={"0","x",hexDigit,hexDigit};
 char buf1[]="0x11";
 
 MENU(mainMenu,"Main menu",doNothing,noEvent,wrapStyle

examples/SSD1306Ascii/platformio.ini

@@ -41,7 +41,7 @@ board = nanoatmega328
 framework = arduino
 ; upload_port=/dev/ttyUSB1
 upload_flags=-V
-build_flags = -DNO_MENU_DEBUG -Wno-strict-aliasing -Wno-sign-compare -Wno-write-strings
+build_flags = -DNO_MENU_DEBUG
 ;
 ; [env:teensy31]
 ; platform = teensy

examples/Serial/ansiSerial/ansiSerial/ansiSerial.ino

@@ -101,12 +101,12 @@ PADMENU(birthDate,"Birth",doNothing,noEvent,noStyle
   ,FIELD(day,"","",1,31,1,0,doNothing,noEvent,wrapStyle)
 );
 
-char* constMEM hexDigit MEMMODE="0123456789ABCDEF";
-char* constMEM hexNr[] MEMMODE={"0","x",hexDigit,hexDigit};
+const char* constMEM hexDigit MEMMODE="0123456789ABCDEF";
+const char* constMEM hexNr[] MEMMODE={"0","x",hexDigit,hexDigit};
 char buf1[]="0x11";
 
-char* constMEM alphaNum MEMMODE=" 0123456789.ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz,\\|!\"#$%&/()=?~*^+-{}[]€";
-char* constMEM alphaNumMask[] MEMMODE={alphaNum};
+const char* constMEM alphaNum MEMMODE=" 0123456789.ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz,\\|!\"#$%&/()=?~*^+-{}[]€";
+const char* constMEM alphaNumMask[] MEMMODE={alphaNum};
 char name[]="                                                  ";
 
 MENU(mainMenu,"Main menu",zZz,noEvent,wrapStyle

examples/Serial/serialio/platformio.ini

@@ -13,6 +13,7 @@ MCU: see TFT library compatibility
 
 #include <TFT.h> // Hardware-specific library
 #include <SPI.h>
+#include <menu.h>
 #include <menuIO/serialOut.h>
 #include <menuIO/serialIn.h>
 #include <menuIO/tftOut.h>
@@ -33,8 +34,8 @@ using namespace Menu;
 
 TFT tft(CS, DC, RST);
 
-char* constMEM hexDigit MEMMODE="0123456789ABCDEF";
-char* constMEM hexNr[] MEMMODE={"0","x",hexDigit,hexDigit};
+const char* constMEM hexDigit MEMMODE="0123456789ABCDEF";
+const char* constMEM hexNr[] MEMMODE={"0","x",hexDigit,hexDigit};
 char buf1[]="0x11";//<-- menu will edit this text
 
 MENU(mainMenu,"Main menu",doNothing,noEvent,wrapStyle