From 1b11197e4d630086b161de41c8e17248d4f4a547 Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 16 Apr 2026 20:05:52 +0530 Subject: [PATCH 1/2] fix: update settings shortcut key from ',' to 's' --- app/components/AppHeader.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/components/AppHeader.vue b/app/components/AppHeader.vue index e90464ca5b..62dcf09979 100644 --- a/app/components/AppHeader.vue +++ b/app/components/AppHeader.vue @@ -32,7 +32,7 @@ const desktopLinks = computed(() => [ name: 'Settings', label: $t('nav.settings'), to: { name: 'settings' }, - keyshortcut: ',', + keyshortcut: 's', type: 'link', external: false, iconClass: 'i-lucide:settings', @@ -201,8 +201,8 @@ function handleSearchFocus() { } useShortcuts({ - 'c': () => ({ name: 'compare' }), - ',': () => ({ name: 'settings' }), + c: () => ({ name: 'compare' }), + s: () => ({ name: 'settings' }), }) From 6eae931a545284b8e64a04001551efc26eeb4354 Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 16 Apr 2026 20:39:42 +0530 Subject: [PATCH 2/2] fix: failed e2e test --- test/e2e/interactions.spec.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/e2e/interactions.spec.ts b/test/e2e/interactions.spec.ts index 4a1a582fb9..42e085477e 100644 --- a/test/e2e/interactions.spec.ts +++ b/test/e2e/interactions.spec.ts @@ -282,30 +282,30 @@ test.describe('Keyboard Shortcuts', () => { await expect(page).toHaveURL(/\/vue/) }) - test('"," navigates to /settings', async ({ page, goto }) => { + test('"s" navigates to /settings', async ({ page, goto }) => { await goto('/compare', { waitUntil: 'hydration' }) - await page.keyboard.press(',') + await page.keyboard.press('s') await expect(page).toHaveURL(/\/settings/) }) - test('"," does not navigate when any modifier key is pressed', async ({ page, goto }) => { + test('"s" does not navigate when any modifier key is pressed', async ({ page, goto }) => { await goto('/settings', { waitUntil: 'hydration' }) const searchInput = page.locator('#header-search') await searchInput.focus() await expect(searchInput).toBeFocused() - await page.keyboard.press('Shift+,') + await page.keyboard.press('Shift+s') await expect(page).toHaveURL(/\/settings/) - await page.keyboard.press('Control+,') + await page.keyboard.press('Control+s') await expect(page).toHaveURL(/\/settings/) - await page.keyboard.press('Alt+,') + await page.keyboard.press('Alt+s') await expect(page).toHaveURL(/\/settings/) - await page.keyboard.press('Meta+,') + await page.keyboard.press('Meta+s') await expect(page).toHaveURL(/\/settings/) - await page.keyboard.press('ControlOrMeta+Shift+,') + await page.keyboard.press('ControlOrMeta+Shift+s') await expect(page).toHaveURL(/\/settings/) }) }) @@ -317,13 +317,13 @@ test.describe('Keyboard Shortcuts disabled', () => { }) }) - test('"," (header) does not navigate to /settings when shortcuts are disabled', async ({ + test('"s" (header) does not navigate to /settings when shortcuts are disabled', async ({ page, goto, }) => { await goto('/compare', { waitUntil: 'hydration' }) - await page.keyboard.press(',') + await page.keyboard.press('s') await expect(page).toHaveURL(/\/compare/) })