Skip to content

Commit d411dee

Browse files
meysholdtona-agent
andcommitted
Make verify step generic: discover build/test tools from repo config
Co-authored-by: Ona <no-reply@ona.com>
1 parent 7c4f459 commit d411dee

2 files changed

Lines changed: 18 additions & 18 deletions

File tree

.ona/fix-codescan-alert.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ action:
5151
prompt: |
5252
Verify the fix from the previous step:
5353
54-
1. Run `./mvnw compile test` to compile and run all tests.
55-
2. If compilation or tests fail:
56-
a. Read the error output carefully.
57-
b. Identify whether the failure is caused by the fix or a pre-existing issue.
58-
c. If caused by the fix, adjust the code and retry.
59-
d. Rerun `./mvnw compile test`.
60-
e. Repeat until all tests pass.
61-
3. Once tests pass, confirm the fix is complete.
54+
1. Identify the project's build tool, test runner, and linter from the
55+
repo config files.
56+
2. Compile the project. If it fails, read the errors, fix them, and retry.
57+
3. Find all test suites and verification commands that could exercise the
58+
modified code. Run them.
59+
4. If any check fails, determine whether the failure is caused by your
60+
change or is pre-existing. Fix what you broke and rerun.
61+
5. Repeat until all checks pass.
6262
6363
- pullRequest:
6464
branch: codescan-fix/

.ona/fix-dependabot-alert.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,16 @@ action:
5050
prompt: |
5151
Verify the fix from the previous step:
5252
53-
1. Run `./mvnw compile test` to compile and run all tests.
54-
2. If compilation or tests fail:
55-
a. Read the error output carefully.
56-
b. Identify whether the failure is caused by the upgrade or a pre-existing issue.
57-
c. If caused by the upgrade, check for breaking API changes and adapt the code.
58-
d. Rerun `./mvnw compile test`.
59-
e. Repeat until all tests pass.
60-
3. Run `./mvnw dependency:tree -Dincludes=<groupId>:<artifactId>` to confirm
61-
the vulnerable version is no longer in the dependency tree.
62-
4. Once tests pass and the old version is gone, confirm the fix is complete.
53+
1. Identify the project's build tool, test runner, and linter from the
54+
repo config files.
55+
2. Compile the project. If it fails, read the errors, fix them, and retry.
56+
3. Find all test suites and verification commands that could exercise the
57+
modified code. Run them.
58+
4. If any check fails, determine whether the failure is caused by your
59+
change or is pre-existing. Fix what you broke and rerun.
60+
5. Repeat until all checks pass.
61+
6. For dependency upgrades, confirm the vulnerable version is no longer
62+
in the resolved dependency tree.
6363
6464
- pullRequest:
6565
branch: dependabot-fix/

0 commit comments

Comments
 (0)