ensures that RequirementsMet condition always reflects BootTime value

Author: zszabo-rh

controllers/imageclusterinstall_controller.go

@@ -150,6 +150,13 @@ func (r *ImageClusterInstallReconciler) Reconcile(ctx context.Context, req ctrl.
 	}
 	// Nothing to do if the installation process started and the config.iso exists
 	if !ici.Status.BootTime.IsZero() {
+		cond := findCondition(ici.Status.Conditions, hivev1.ClusterInstallRequirementsMet)
+		if cond != nil && cond.Status == corev1.ConditionFalse {
+			r.setRequirementsMetCondition(ctx, ici,
+				corev1.ConditionTrue,
+				v1alpha1.HostConfigurationSucceededReason,
+				"configuration image is attached to the referenced host")
+		}
 		clusterConfigDir := GetClusterConfigDir(filepath.Join(r.Options.DataDir, "namespaces"), ici.Namespace, string(ici.UID))
 		if verifyIsoAndAuthExists(clusterConfigDir) {
 			return ctrl.Result{}, nil

controllers/imageclusterinstall_controller_test.go

@@ -1792,6 +1792,54 @@ var _ = Describe("Reconcile", func() {
 			Expect(res).To(Equal(ctrl.Result{}))
 		})
 	})
+	// Generated by Cursor
+	It("ensures RequirementsMet condition is True when BootTime is set after reconcile", func() {
+		// Create BMH in the correct state (StateExternallyProvisioned)
+		bmh := bmhInState(bmh_v1alpha1.StateExternallyProvisioned)
+		Expect(c.Create(ctx, bmh)).To(Succeed())
+
+		clusterInstall.Spec.BareMetalHostRef = &v1alpha1.BareMetalHostReference{
+			Name:      bmh.Name,
+			Namespace: bmh.Namespace,
+		}
+
+		// Simulate the bug scenario: Set a stale condition that shows False status
+		// This simulates what could happen if the condition was set in a previous reconcile cycle
+		clusterInstall.Status.Conditions = []hivev1.ClusterInstallCondition{
+			{
+				Type:               hivev1.ClusterInstallRequirementsMet,
+				Status:             corev1.ConditionFalse,
+				Reason:             v1alpha1.HostConfigurationPendingReason,
+				Message:            "waiting for BMH provisioning state to be StateAvailable or StateExternallyProvisioned, current state is: registering",
+				LastTransitionTime: metav1.Now(),
+			},
+		}
+
+		Expect(c.Create(ctx, clusterInstall)).To(Succeed())
+		Expect(c.Create(ctx, clusterDeployment)).To(Succeed())
+
+		key := types.NamespacedName{
+			Namespace: clusterInstallNamespace,
+			Name:      clusterInstallName,
+		}
+		installerSuccess()
+		res, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: key})
+		Expect(err).NotTo(HaveOccurred())
+		Expect(res).To(Equal(ctrl.Result{}))
+
+		// Verify the reconcile result
+		Expect(c.Get(ctx, key, clusterInstall)).To(Succeed())
+
+		// The critical test: BootTime is set and RequirementsMet MUST be True after successful reconcile
+		Expect(clusterInstall.Status.BootTime).ToNot(BeZero(), "BootTime should be set after successful reconcile")
+		cond := findCondition(clusterInstall.Status.Conditions, hivev1.ClusterInstallRequirementsMet)
+		Expect(cond).NotTo(BeNil())
+		Expect(cond.Status).To(Equal(corev1.ConditionTrue),
+			"RequirementsMet condition must be True when BootTime is set. Found: status=%s, reason=%s, message=%s",
+			cond.Status, cond.Reason, cond.Message)
+		Expect(cond.Reason).To(Equal(v1alpha1.HostConfigurationSucceededReason))
+		Expect(cond.Message).To(Equal("configuration image is attached to the referenced host"))
+	})
 })
 
 var _ = Describe("Reconcile with DataImageCoolDownPeriod set to 1 second", func() {