fix(tests): address CodeRabbit review findings

- waitUntil timeout: add one extra interval to avoid off-by-one
  where the last poll fires 2 min before timeout expires
- 03-04.reg_e2e_firing_alerts: add missing warmUpForPlugin() call
  that all other regression specs already have
- incidents-page.ts: extract _resetSearchState() helper and use it
  on both success and error paths so _quietSearch and
  _findIncidentSearchStart don't leak across specs on failure

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Claude Agent

web/cypress/e2e/incidents/00.coo_incidents_e2e.cy.ts

@@ -52,7 +52,7 @@ describe('BVT: Incidents - e2e', { tags: ['@smoke', '@slow', '@incidents', '@e2e
     // This makes it safe to poll for the full 30-minute window.
     cy.waitUntil(() => incidentsPage.findIncidentWithAlert(currentAlertName), {
       interval: 2 * intervalMs,
-      timeout: 30 * intervalMs,
+      timeout: 30 * intervalMs + 2 * intervalMs,
     });
 
     cy.log('1.3 Verify custom alert appears in alerts table');

web/cypress/e2e/incidents/regression/03-04.reg_e2e_firing_alerts.cy.ts

@@ -41,6 +41,7 @@ describe(
 
     before(() => {
       cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
+      incidentsPage.warmUpForPlugin();
 
       // Reset the search timeout so this spec gets a fresh 35-minute window
       incidentsPage.resetSearchTimeout();

web/cypress/views/incidents-page.ts

@@ -13,6 +13,11 @@ const _FIND_INCIDENT_HARD_TIMEOUT_MS = 35 * 60 * 1000; // 35 minutes
 let _quietSearch = false;
 const _qLog = (): { log: false } | Record<string, never> => (_quietSearch ? { log: false } : {});
 
+const _resetSearchState = () => {
+  _findIncidentSearchStart = null;
+  _quietSearch = false;
+};
+
 export const incidentsPage = {
   // Centralized element selectors - all selectors defined in one place
   elements: {
@@ -637,7 +642,7 @@ export const incidentsPage = {
   },
 
   resetSearchTimeout: () => {
-    _findIncidentSearchStart = null;
+    _resetSearchState();
   },
 
   // Constants for search configuration
@@ -840,8 +845,7 @@ export const incidentsPage = {
     }
     const elapsed = Date.now() - _findIncidentSearchStart;
     if (elapsed > _FIND_INCIDENT_HARD_TIMEOUT_MS) {
-      _findIncidentSearchStart = null;
-      _quietSearch = false;
+      _resetSearchState();
       const mins = Math.round(elapsed / 60000);
       throw new Error(`findIncidentWithAlert: hard timeout after ${mins} min for "${alertName}"`);
     }
@@ -867,9 +871,10 @@ export const incidentsPage = {
         return incidentsPage.traverseAllIncidentsBars(alertName, totalPaths);
       })
       .then((found: boolean) => {
-        _quietSearch = false;
         if (found) {
-          _findIncidentSearchStart = null;
+          _resetSearchState();
+        } else {
+          _quietSearch = false;
         }
         return found;
       });