fix loop

Author: etmurasaki

web/cypress/support/monitoring/03.reg_legacy_dashboards.cy.ts

@@ -1,6 +1,6 @@
 import { nav } from '../../views/nav';
 import { legacyDashboardsPage } from '../../views/legacy-dashboards';
-import { API_PERFORMANCE_DASHBOARD_PANELS, LegacyDashboardsDashboardDropdown, MetricsPageQueryInput, WatchdogAlert } from '../../fixtures/monitoring/constants';
+import { LegacyDashboardsDashboardDropdown, MetricsPageQueryInput, WatchdogAlert } from '../../fixtures/monitoring/constants';
 import { Classes, LegacyDashboardPageTestIDs, DataTestIDs } from '../../../src/components/data-test';
 import { metricsPage } from '../../views/metrics';
 import { alertingRuleDetailsPage } from '../../views/alerting-rule-details-page';
@@ -35,9 +35,7 @@ export function testLegacyDashboardsRegression(perspective: PerspectiveConfig) {
     legacyDashboardsPage.clickDashboardDropdown('API_PERFORMANCE');
 
     cy.log('1.5 Dashboard API Performance panels');
-    for (const panel of Object.values(API_PERFORMANCE_DASHBOARD_PANELS)) {
-      legacyDashboardsPage.dashboardAPIPerformancePanelAssertion(panel);
-    }
+    legacyDashboardsPage.dashboardAPIPerformancePanelAssertion();
 
     cy.log('1.6 Inspect - API Request Duration by Verb - 99th Percentile');
     cy.byTestID(LegacyDashboardPageTestIDs.Inspect).eq(0).scrollIntoView().should('be.visible').click();

web/cypress/support/monitoring/06.reg_legacy_dashboards_namespace.cy.ts

@@ -1,6 +1,6 @@
 import { nav } from '../../views/nav';
 import { legacyDashboardsPage } from '../../views/legacy-dashboards';
-import { KUBERNETES_COMPUTE_RESOURCES_NAMESPACE_PODS_PANELS, LegacyDashboardsDashboardDropdownNamespace, MetricsPageQueryInputByNamespace, WatchdogAlert } from '../../fixtures/monitoring/constants';
+import { LegacyDashboardsDashboardDropdownNamespace, MetricsPageQueryInputByNamespace, WatchdogAlert } from '../../fixtures/monitoring/constants';
 import { Classes, LegacyDashboardPageTestIDs, DataTestIDs } from '../../../src/components/data-test';
 import { metricsPage } from '../../views/metrics';
 import { alertingRuleDetailsPage } from '../../views/alerting-rule-details-page';
@@ -34,9 +34,7 @@ export function testLegacyDashboardsRegressionNamespace(perspective: Perspective
     legacyDashboardsPage.dashboardDropdownAssertion(LegacyDashboardsDashboardDropdownNamespace);
 
     cy.log('1.5 Dashboard Kubernetes Compute Resources Namespace Pods panels');
-    for (const panel of Object.values(KUBERNETES_COMPUTE_RESOURCES_NAMESPACE_PODS_PANELS)) {
-      legacyDashboardsPage.dashboardKubernetesComputeResourcesNamespacePodsPanelAssertion(panel);
-    }
+    legacyDashboardsPage.dashboardKubernetesComputeResourcesNamespacePodsPanelAssertion();
 
     cy.log('1.6 Inspect - CPU Utilisation (from requests)');
     cy.byTestID(LegacyDashboardPageTestIDs.Inspect).eq(0).scrollIntoView().should('be.visible').click();

web/cypress/views/legacy-dashboards.ts

@@ -77,25 +77,25 @@ export const legacyDashboardsPage = {
     cy.byTestID(LegacyDashboardPageTestIDs.DashboardDropdown).find('button').should('be.visible').click();
   },
 
-  dashboardAPIPerformancePanelAssertion: (panel: API_PERFORMANCE_DASHBOARD_PANELS) => {
+  dashboardAPIPerformancePanelAssertion: () => {
     cy.log('legacyDashboardsPage.dashboardAPIPerformancePanelAssertion');
     function formatDataTestID(panel: API_PERFORMANCE_DASHBOARD_PANELS): string {
       return panel.toLowerCase().replace(/\s+/g, '-').concat('-chart');
     }
-    const dataTestID = Object.values(API_PERFORMANCE_DASHBOARD_PANELS).map(formatDataTestID);
-    dataTestID.forEach((dataTestID) => {
+    const dataTestIDs = Object.values(API_PERFORMANCE_DASHBOARD_PANELS).map(formatDataTestID);
+    dataTestIDs.forEach((dataTestID) => {
       cy.log('Data test ID: ' + dataTestID);
       cy.byTestID(dataTestID).scrollIntoView().should('be.visible');
     });
   },
 
-  dashboardKubernetesComputeResourcesNamespacePodsPanelAssertion: (panel: KUBERNETES_COMPUTE_RESOURCES_NAMESPACE_PODS_PANELS) => {
+  dashboardKubernetesComputeResourcesNamespacePodsPanelAssertion: () => {
     cy.log('legacyDashboardsPage.dashboardKubernetesComputeResourcesNamespacePodsPanelAssertion');
     function formatDataTestID(panel: KUBERNETES_COMPUTE_RESOURCES_NAMESPACE_PODS_PANELS): string {
       return panel.toLowerCase().replace(/\s+/g, '-').concat('-chart');
     }
-    const dataTestID = Object.values(KUBERNETES_COMPUTE_RESOURCES_NAMESPACE_PODS_PANELS).map(formatDataTestID);
-    dataTestID.forEach((dataTestID) => {
+    const dataTestIDs = Object.values(KUBERNETES_COMPUTE_RESOURCES_NAMESPACE_PODS_PANELS).map(formatDataTestID);
+    dataTestIDs.forEach((dataTestID) => {
       cy.log('Data test ID: ' + dataTestID);
       cy.byTestID(dataTestID).scrollIntoView().should('be.visible');
     });