Merge pull request #693 from PeterYurkovich/ou-1131

OU-1131: Merge main into release-4.19

Author: openshift-merge-bot[bot]

.ci-operator.yaml

@@ -1,4 +1,4 @@
 build_root_image:
   name: release
   namespace: openshift
-  tag: rhel-9-release-golang-1.23-openshift-4.19
+  tag: rhel-9-release-golang-1.24-openshift-4.21

.claude/commands/run-perses-dev.md

@@ -0,0 +1,50 @@
+---
+name: run-perses-dev
+description: Setup a development environment for monitoring-console-plugin + perses
+parameters:
+  - name: perses_path
+  - description: The path on the local machine that points to a clone of https://github.com/perses/perses (e.g. /Users/bob/git_repos/perses)
+  - required: true
+allowed-tools: Read, Grep, tmux, which, ls, lsof, oc 
+---
+
+0. perses_path 
+- Go to the root and cd .claude/commands/configs/run-perses-dev-config.yaml
+- If not defined, create the file and fill out the perses path 
+
+1. Create a tmux session called 'monitoring-perses-dev' with 8 panes =  4 columns x 2 rows 
+Split horitzontally, then split verically.
+Then go clockwise and split horitzontally. 
+- Pane 0
+    - Path: monitoring-plugin (root of this repo)
+    - Label: monitoring-console-plugin-frontend 
+    - Run:  make start-frontend
+- Pane 2
+    - Path: monitoring-plugin (root of this repo)
+    - Label: monitoring-console-plugin-console  
+    - Run: make start-feature-console
+- Pane 4
+    - Path: monitoring-plugin (root of this repo)
+    - Label: monitoring-console-plugin-backend 
+    - Run: make start-feature-backend
+- Pane 6
+    - Path: monitoring-plugin (root of this repo)
+    - Label: port-forward-promtheus-operator
+    - Run: oc port-forward -n openshift-monitoring service/prometheus-operated 9090:9090
+- Pane 1
+    - Path: `{perses_path}`
+    - Label: perses-backend
+    - Run: ./scripts/api_backend_dev.sh
+- Pane 3
+    - Path: `{perses_path}/ui`
+    - Label: perses-ui
+    - Run: npm run start
+
+2. Final checks 
+- Check if all the processes in each pane is running without error. If there is a error diagnose and fix it. 
+- In bold output, tell the user the name of the session and tmux session tips like how to attach to sessions, how to move around the panels using prefix + arrows, how to delete a session, how to list session
+- Navigate to `{perses_path}/dev/config.yaml`. The spec `security.enable_auth` should be `false`. 
+- Tell user that openshift console platform is located at  http://localhost:9000
+- Tell user that perses is located at http://localhost:3000 
+ 
+

.cursor/commands/fixture-schema-reference.md

@@ -0,0 +1,188 @@
+# Fixture Schema Reference
+
+## Overview
+Quick reference for the YAML fixture schema structure, valid values, and common patterns.
+
+## Schema Structure
+
+```yaml
+name: string                    # Required: Human-readable scenario name
+description: string             # Required: Detailed description
+incidents: array                # Required: Array of incident objects
+  - id: string                  # Required: Unique incident identifier
+    component: string           # Required: Component affected
+    layer: string              # Required: Layer (core/Others)
+    timeline: object           # Optional: Timeline information
+      start: string            # Required: When incident started
+      end: string              # Optional: When incident ended
+      severityChanges: array   # Optional: Severity changes over time
+    alerts: array              # Required: Array of alert objects
+      - name: string           # Required: Alert name
+        namespace: string      # Required: Alert namespace
+        severity: string       # Required: Alert severity
+        firing: boolean        # Optional: Firing state
+    managed_cluster: string    # Optional: Managed cluster ID
+```
+
+## Valid Values
+
+### Components
+- `monitoring` - Monitoring infrastructure
+- `storage` - Storage systems
+- `network` - Network components
+- `compute` - Compute resources
+- `api-server` - Kubernetes API server
+- `etcd` - etcd cluster
+- `version` - Cluster version
+- `Others` - Other components
+
+### Layers
+- `core` - Core OpenShift components
+- `Others` - Non-core components
+
+### Severities
+- `critical` - Critical alerts
+- `warning` - Warning alerts
+- `info` - Informational alerts
+
+### Duration Format
+- Pattern: `^\d+[smhd]$`
+- Examples: `"30m"`, `"2h"`, `"7d"`, `"1h"`
+- Units: `s` (seconds), `m` (minutes), `h` (hours), `d` (days)
+
+## Common Alert Names
+
+### Monitoring Component
+```yaml
+- name: "AlertmanagerReceiversNotConfigured"
+  namespace: "openshift-monitoring"
+  severity: "warning"
+
+- name: "KubeDeploymentReplicasMismatch"
+  namespace: "openshift-monitoring"
+  severity: "critical"
+
+- name: "KubePodCrashLooping"
+  namespace: "openshift-monitoring"
+  severity: "warning"
+
+- name: "PrometheusConfigReloadFailure"
+  namespace: "openshift-monitoring"
+  severity: "warning"
+
+- name: "Watchdog"
+  namespace: "openshift-monitoring"
+  severity: "info"
+```
+
+### Storage Component
+```yaml
+- name: "KubePersistentVolumeFillingUp"
+  namespace: "openshift-storage"
+  severity: "critical"
+
+- name: "DiskSpaceRunningLow"
+  namespace: "openshift-storage"
+  severity: "critical"
+
+- name: "VolumeReadOnly"
+  namespace: "openshift-storage"
+  severity: "critical"
+```
+
+### Network Component
+```yaml
+- name: "NetworkLatencyHigh"
+  namespace: "openshift-network"
+  severity: "warning"
+
+- name: "EtcdMemberCommunicationSlow"
+  namespace: "openshift-etcd"
+  severity: "warning"
+```
+
+### Compute Component
+```yaml
+- name: "NodeNotReady"
+  namespace: "openshift-machine-api"
+  severity: "critical"
+
+- name: "KubeNodeUnreachable"
+  namespace: "openshift-machine-api"
+  severity: "critical"
+```
+
+## Timeline Patterns
+
+### Simple Ongoing Incident
+```yaml
+timeline:
+  start: "2h"  # Started 2 hours ago
+```
+
+### Resolved Incident
+```yaml
+timeline:
+  start: "4h"   # Started 4 hours ago
+  end: "1h"     # Resolved 1 hour ago
+```
+
+### Severity Escalation
+```yaml
+timeline:
+  start: "3h"   # Started 3 hours ago
+  severityChanges:
+    - time: "3h"   # Started as warning
+      severity: "warning"
+    - time: "1h"   # Escalated to critical 1 hour ago
+      severity: "critical"
+```
+
+## Validation Rules
+
+### Required Fields
+- Root: `name`, `description`, `incidents`
+- Incident: `id`, `component`, `layer`, `alerts`
+- Alert: `name`, `namespace`, `severity`
+- Timeline: `start`
+
+### Format Constraints
+- Incident ID: Pattern `^[a-zA-Z0-9-_]+$`
+- Duration: Pattern `^\d+[smhd]$`
+- Component/Layer/Severity: Must be valid enum values
+
+### Array Constraints
+- Incidents: `minItems: 0`
+- Alerts: `minItems: 1` per incident
+
+## Usage in Tests
+
+```typescript
+// Load YAML fixture
+cy.mockIncidentFixture('cypress/fixtures/incident-scenarios/critical-monitoring-issues.yaml');
+
+// Load JSON fixture (backward compatibility)
+cy.mockIncidentFixture('cypress/fixtures/incident-scenarios/some-scenario.json');
+```
+
+## Validation Tools
+
+### CLI Validation
+```bash
+cd web/cypress/support/incidents_prometheus_query_mocks
+node validate-fixtures.js --all
+node validate-fixtures.js specific-file.yaml
+```
+
+### Schema Files
+- Schema: `web/cypress/support/incidents_prometheus_query_mocks/fixture-schema.json`
+- Validator: `web/cypress/support/incidents_prometheus_query_mocks/schema-validator.ts`
+- CLI Tool: `web/cypress/support/incidents_prometheus_query_mocks/validate-fixtures.js`
+
+## Best Practices
+
+1. **Naming**: Use descriptive, specific names
+2. **Comments**: Add helpful comments for timeline values
+3. **Realistic Data**: Use actual OpenShift alert names
+4. **Consistent Format**: Follow established patterns
+5. **Validation**: Always validate before committing

.cursor/commands/generate-incident-fixture.md

@@ -0,0 +1,71 @@
+---
+description: Generate valid YAML incident fixtures for Cypress testing
+---
+
+# Generate Incident Fixture
+
+Generate valid YAML fixtures for incident scenarios based on text descriptions or UI screenshots.
+
+## Process
+
+### 1. Analyze Input
+- **Text Description**: Extract incident components, alert names, severities, and timeline
+- **Screenshot**: Identify visible incidents, alerts, and timeline - **CONVERT ALL DATES TO RELATIVE TIME**. There will be usually one chart 'Incident Timeline' displaying the incident timelines and second one 'Alert Timelines' which displays alerts for **a single particular incident**. When the Alert timeline is visible, include timestamps for the individual alerts within the incident, which may differ from the incident one.
+- Focus on capturing the precise start and end dates for incidents and individual alerts so that the variability from the screenshot is preserved.
+
+### 2. Generate YAML Structure
+Create fixture following the schema in [fixture-schema.json](mdc:web/cypress/support/incidents_prometheus_query_mocks/fixture-schema.json). Prefer this schema over existing fixtures.
+
+```yaml
+name: "[Scenario Name]"
+description: "[Detailed description]"
+incidents:
+  - id: "[unique-incident-id]"
+    component: "[component-name]"
+    layer: "[core|Others]"
+    timeline:
+      start: "[duration]"
+      # end: "[duration]" # Only if resolved
+    alerts:
+      - name: "[alert-name]"
+        namespace: "[namespace]"
+        severity: "[critical|warning|info]"
+        firing: [true|false]
+        timeline:
+          start: "[duration]"
+```
+
+### 3. Apply Constraints
+- **Name and Description**: Use generic name capturing the essence of the scenario
+- **File name**: Use generic name capturing the essence of the scenario
+- **Components**: `monitoring`, `storage`, `network`, `compute`, `api-server`, `etcd`, `version`, `Others`
+- **Layers**: `core`, `Others`
+- **Severities**: `critical`, `warning`, `info`
+- **Duration Format**: `<number><unit>` (e.g., `"2h"`, `"30m"`, `"7d"`)
+- **Alert Names**: Use descriptive, artificial names with unique indices (e.g., `"MonitoringAlertmanagerReceiversCritical001"`)
+
+### 4. Time Conversion Rules
+- **NEVER use absolute dates/timestamps**
+- Convert screenshot dates to relative durations from the end of the chart
+- Example: If screenshot shows "2024-01-15 14:30" and current time is "2024-01-15 16:30", use `"2h"`
+
+### 5. Run validation
+- run the validation using [fixture-schema.json](mdc:web/cypress/support/incident_prometheus_query_mocks/validate_fixture.js)
+
+```yaml
+
+## Validation Checklist
+- [ ] All required fields present (name, description, incidents)
+- [ ] Incident IDs are unique and follow naming convention
+- [ ] Components and layers use valid enum values from schema
+- [ ] Duration format matches pattern `^\d+[smhd]$`
+- [ ] **NO absolute dates or timestamps used - only relative durations**
+- [ ] Alert names are descriptive and artificial with unique indices
+- [ ] Alerts have timelines if different when the incidents
+- [ ] Namespaces follow OpenShift conventions
+- [ ] Severity levels are valid (critical, warning, info)
+- [ ] YAML syntax is correct with proper indentation
+- [ ] Schema validation passes against [fixture-schema.json](mdc:web/cypress/support/incidents_prometheus_query_mocks/fixture-schema.json)
+
+## Output
+Provide complete YAML fixture ready for use with `cy.mockIncidentFixture()` in Cypress tests.