Merge pull request #30953 from jaypoulz/OCPBUGS-81340-pacemaker-status-collector-events

OCPBUGS-81340: openshift-tests: allow duplicate pacemaker status collector CronJob events

Author: openshift-merge-bot[bot]

pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

@@ -537,6 +537,20 @@ func NewUniversalPathologicalEventMatchers(kubeConfig *rest.Config, finalInterva
 	twoNodeEtcdEndpointsMatcher := newTwoNodeEtcdEndpointsConfigMissingEventMatcher(finalIntervals)
 	registry.AddPathologicalEventMatcherOrDie(twoNodeEtcdEndpointsMatcher)
 
+	// cluster-etcd-operator (TNF): the pacemaker status collector CronJob runs on a short schedule; the
+	// kube-controller-manager cronjob-controller emits SuccessfulCreate and SawCompletedJob on the CronJob
+	// InvolvedObject. Long openshift-tests runs can exceed the duplicate-event threshold.
+	// SuccessfulDelete churn is reduced by CEO Job TTL / history tuning (see OCPBUGS-81340).
+	registry.AddPathologicalEventMatcherOrDie(&SimplePathologicalEventMatcher{
+		name: "PacemakerStatusCollectorCronJobEvents",
+		locatorKeyRegexes: map[monitorapi.LocatorKey]*regexp.Regexp{
+			monitorapi.LocatorNamespaceKey:   regexp.MustCompile(`^openshift-etcd-operator$`),
+			monitorapi.LocatorKey("cronjob"): regexp.MustCompile(`^pacemaker-status-collector$`),
+		},
+		messageReasonRegex: regexp.MustCompile(`^(SuccessfulCreate|SawCompletedJob)$`),
+		jira:               "https://issues.redhat.com/browse/OCPBUGS-81340",
+	})
+
 	newConfigDriftMonitorStoppedTooOftenEventMatcher := newConfigDriftMonitorStoppedTooOftenEventMatcher(finalIntervals)
 	registry.AddPathologicalEventMatcherOrDie(newConfigDriftMonitorStoppedTooOftenEventMatcher)
 

pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_test.go

@@ -211,6 +211,18 @@ func TestAllowedRepeatedEvents(t *testing.T) {
 				Reason("MultipleVersions").Build(),
 			expectedAllowName: "OperatorMultipleVersions",
 		},
+		{
+			name: "pacemaker status collector cronjob successful create (KCM cronjob-controller)",
+			locator: monitorapi.Locator{
+				Keys: map[monitorapi.LocatorKey]string{
+					monitorapi.LocatorNamespaceKey:   "openshift-etcd-operator",
+					monitorapi.LocatorKey("cronjob"): "pacemaker-status-collector",
+				},
+			},
+			msg: monitorapi.NewMessage().HumanMessage("Created job pacemaker-status-collector-29035215").
+				Reason("SuccessfulCreate").Build(),
+			expectedAllowName: "PacemakerStatusCollectorCronJobEvents",
+		},
 	}
 	for _, test := range tests {
 		registry := NewUpgradePathologicalEventMatchers(nil, nil)