Skip to content

Commit 2d55966

Browse files
committed
Adding reference to issues which prevent a no-copy implementation
1 parent 3d71e80 commit 2d55966

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

cpp/sequel.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@ SequelResult sequel_execute(jsi::Runtime &rt, string const dbName, string const
329329
jsi::Function array_buffer_ctor = rt.global().getPropertyAsFunction(rt, "ArrayBuffer");
330330
jsi::Object o = array_buffer_ctor.callAsConstructor(rt, blob_size).getObject(rt);
331331
jsi::ArrayBuffer buf = o.getArrayBuffer(rt);
332+
// It's a shame we have to copy here: see https://github.com/facebook/hermes/pull/419 and https://github.com/facebook/hermes/issues/564.
332333
memcpy(buf.data(rt), blob, blob_size);
333334
entry.setProperty(rt, column_name.c_str(), o);
334335
break;

0 commit comments

Comments
 (0)