Throw error when incorrect number of args is passed to asyncExecuteSQL call

Oscar Franco · Oscar Franco · commit 33ad8c2ab885 · 2022-03-14T18:43:40.000+01:00
diff --git a/cpp/installer.cpp b/cpp/installer.cpp
@@ -405,8 +405,10 @@ void install(jsi::Runtime &rt, std::shared_ptr<react::CallInvoker> jsCallInvoker
       {
         if (count < 4)
         {
-          LOGW("NOT ENOUGH PARAMS PASSED");
+          jsi::detail::throwJSError(rt, "[react-native-quick-sqlite] Incorrect arguments for asyncExecuteSQL");
+          return {};
         }
+        
         const string dbName = args[0].asString(rt).utf8(rt);
         const string query = args[1].asString(rt).utf8(rt);
         const jsi::Value &originalParams = args[2];

Original file line number	Diff line number	Diff line change
`@@ -405,8 +405,10 @@ void install(jsi::Runtime &rt, std::shared_ptr<react::CallInvoker> jsCallInvoker`
`405`	`405`	`{`
`406`	`406`	`if (count < 4)`
`407`	`407`	`{`
`408`		`- LOGW("NOT ENOUGH PARAMS PASSED");`
	`408`	`+ jsi::detail::throwJSError(rt, "[react-native-quick-sqlite] Incorrect arguments for asyncExecuteSQL");`
	`409`	`+ return {};`
`409`	`410`	`}`
	`411`	`+`
`410`	`412`	`const string dbName = args[0].asString(rt).utf8(rt);`
`411`	`413`	`const string query = args[1].asString(rt).utf8(rt);`
`412`	`414`	`const jsi::Value &originalParams = args[2];`