test/behavior/cast: check error-set membership not @typeinfo order

Under parallel sema, error-name InternPool indices (and thus the
index-sorted @typeinfo order) depend on which thread interns first.
The language does not specify error-set @typeinfo ordering; check
membership instead.

Author: alii

test/behavior/cast.zig

@@ -8,6 +8,11 @@ const mem = std.mem;
 const maxInt = std.math.maxInt;
 const native_endian = builtin.target.cpu.arch.endian();
 
+fn errorSetContains(set: []const std.builtin.Type.Error, name: []const u8) bool {
+    for (set) |e| if (mem.eql(u8, e.name, name)) return true;
+    return false;
+}
+
 test "int to ptr cast" {
     if (builtin.zig_backend == .stage2_spirv) return error.SkipZigTest;
 
@@ -885,8 +890,8 @@ test "peer type resolution: error set supersets" {
         const error_set_info = @typeInfo(ty);
         try expect(error_set_info == .error_set);
         try expect(error_set_info.error_set.?.len == 2);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
     }
 
     // B superset of A
@@ -895,8 +900,8 @@ test "peer type resolution: error set supersets" {
         const error_set_info = @typeInfo(ty);
         try expect(error_set_info == .error_set);
         try expect(error_set_info.error_set.?.len == 2);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
     }
 }
 
@@ -913,19 +918,19 @@ test "peer type resolution: disjoint error sets" {
         const error_set_info = @typeInfo(ty);
         try expect(error_set_info == .error_set);
         try expect(error_set_info.error_set.?.len == 3);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[2].name, "Three"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Three"));
     }
 
     {
         const ty = @TypeOf(b, a);
         const error_set_info = @typeInfo(ty);
         try expect(error_set_info == .error_set);
         try expect(error_set_info.error_set.?.len == 3);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[2].name, "Three"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Three"));
     }
 }
 
@@ -944,9 +949,9 @@ test "peer type resolution: error union and error set" {
 
         const error_set_info = @typeInfo(info.error_union.error_set);
         try expect(error_set_info.error_set.?.len == 3);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[2].name, "Three"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Three"));
     }
 
     {
@@ -956,9 +961,9 @@ test "peer type resolution: error union and error set" {
 
         const error_set_info = @typeInfo(info.error_union.error_set);
         try expect(error_set_info.error_set.?.len == 3);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[2].name, "Three"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Three"));
     }
 }
 
@@ -978,8 +983,8 @@ test "peer type resolution: error union after non-error" {
 
         const error_set_info = @typeInfo(info.error_union.error_set);
         try expect(error_set_info.error_set.?.len == 2);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
     }
 
     {
@@ -990,8 +995,8 @@ test "peer type resolution: error union after non-error" {
 
         const error_set_info = @typeInfo(info.error_union.error_set);
         try expect(error_set_info.error_set.?.len == 2);
-        try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-        try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
+        try expect(errorSetContains(error_set_info.error_set.?, "One"));
+        try expect(errorSetContains(error_set_info.error_set.?, "Two"));
     }
 }
 

test/behavior/type_info.zig

@@ -9,6 +9,11 @@ const assert = std.debug.assert;
 const expect = std.testing.expect;
 const expectEqualStrings = std.testing.expectEqualStrings;
 
+fn errorSetContains(set: []const Type.Error, name: []const u8) bool {
+    for (set) |e| if (mem.eql(u8, e.name, name)) return true;
+    return false;
+}
+
 test "type info: integer, floating point type info" {
     try testIntFloat();
     try comptime testIntFloat();
@@ -176,7 +181,9 @@ fn testErrorSet() !void {
     const error_set_info = @typeInfo(TestErrorSet);
     try expect(error_set_info == .error_set);
     try expect(error_set_info.error_set.?.len == 3);
-    try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "First"));
+    try expect(errorSetContains(error_set_info.error_set.?, "First"));
+    try expect(errorSetContains(error_set_info.error_set.?, "Second"));
+    try expect(errorSetContains(error_set_info.error_set.?, "Third"));
 
     const error_union_info = @typeInfo(TestErrorSet!usize);
     try expect(error_union_info == .error_union);
@@ -211,9 +218,9 @@ test "type info: error set merged" {
     const error_set_info = @typeInfo(TestSet);
     try expect(error_set_info == .error_set);
     try expect(error_set_info.error_set.?.len == 3);
-    try expect(mem.eql(u8, error_set_info.error_set.?[0].name, "One"));
-    try expect(mem.eql(u8, error_set_info.error_set.?[1].name, "Two"));
-    try expect(mem.eql(u8, error_set_info.error_set.?[2].name, "Three"));
+    try expect(errorSetContains(error_set_info.error_set.?, "One"));
+    try expect(errorSetContains(error_set_info.error_set.?, "Two"));
+    try expect(errorSetContains(error_set_info.error_set.?, "Three"));
 }
 
 test "type info: enum info" {