Address #247

Author: daveshanley

parameters/validate_parameter.go

@@ -96,7 +96,7 @@ func ValidateParameterSchema(
 	var validationErrors []*errors.ValidationError
 
 	// 1. build a JSON render of the schema.
-	renderCtx := base.NewInlineRenderContext()
+	renderCtx := base.NewInlineRenderContextForValidation()
 	renderedSchema, _ := schema.RenderInlineWithContext(renderCtx)
 	jsonSchema, _ := utils.ConvertYAMLtoJSON(renderedSchema)
 
@@ -238,7 +238,7 @@ func formatJsonSchemaValidationError(schema *base.Schema, scErrs *jsonschema.Val
 			OriginalJsonSchemaError: scErrs,
 		}
 		if schema != nil {
-			renderCtx := base.NewInlineRenderContext()
+			renderCtx := base.NewInlineRenderContextForValidation()
 			rendered, err := schema.RenderInlineWithContext(renderCtx)
 			if err == nil && rendered != nil {
 				renderedBytes, _ := json.Marshal(rendered)

requests/validate_request.go

@@ -79,7 +79,7 @@ func ValidateRequestSchema(input *ValidateRequestSchemaInput) (bool, []*errors.V
 
 	// Cache miss or no cache - render and compile
 	if compiledSchema == nil {
-		renderCtx := base.NewInlineRenderContext()
+		renderCtx := base.NewInlineRenderContextForValidation()
 		var renderErr error
 		renderedSchema, renderErr = input.Schema.RenderInlineWithContext(renderCtx)
 		referenceSchema = string(renderedSchema)

responses/validate_response.go

@@ -81,7 +81,7 @@ func ValidateResponseSchema(input *ValidateResponseSchemaInput) (bool, []*errors
 
 	// Cache miss or no cache - render and compile
 	if compiledSchema == nil {
-		renderCtx := base.NewInlineRenderContext()
+		renderCtx := base.NewInlineRenderContextForValidation()
 		var renderErr error
 		renderedSchema, renderErr = input.Schema.RenderInlineWithContext(renderCtx)
 		referenceSchema = string(renderedSchema)

strict/types.go

@@ -330,7 +330,7 @@ func NewValidator(options *config.ValidationOptions, version float32) *Validator
 		logger:       logger,
 		localCache:   make(map[string]*jsonschema.Schema),
 		patternCache: make(map[string]*regexp.Regexp),
-		renderCtx:    base.NewInlineRenderContext(),
+		renderCtx:    base.NewInlineRenderContextForValidation(),
 		version:      version,
 	}
 

validator.go

@@ -492,7 +492,7 @@ func warmMediaTypeSchema(mediaType *v3.MediaType, schemaCache cache.SchemaCache,
 		if _, exists := schemaCache.Load(hash); !exists {
 			schema := mediaType.Schema.Schema()
 			if schema != nil {
-				renderCtx := base.NewInlineRenderContext()
+				renderCtx := base.NewInlineRenderContextForValidation()
 				renderedInline, _ := schema.RenderInlineWithContext(renderCtx)
 				referenceSchema := string(renderedInline)
 				renderedJSON, _ := utils.ConvertYAMLtoJSON(renderedInline)
@@ -545,7 +545,7 @@ func warmParameterSchema(param *v3.Parameter, schemaCache cache.SchemaCache, opt
 
 		if schema != nil {
 			if _, exists := schemaCache.Load(hash); !exists {
-				renderCtx := base.NewInlineRenderContext()
+				renderCtx := base.NewInlineRenderContextForValidation()
 				renderedInline, _ := schema.RenderInlineWithContext(renderCtx)
 				referenceSchema := string(renderedInline)
 				renderedJSON, _ := utils.ConvertYAMLtoJSON(renderedInline)

validator_test.go

@@ -2657,3 +2657,94 @@ paths:
 	assert.True(t, validB)
 	assert.Len(t, errsB, 0)
 }
+
+// TestValidateHttpResponse_DiscriminatorOneOf tests that response validation works correctly
+// when the response schema uses oneOf with a discriminator and $ref to component schemas.
+// This is a regression test for https://github.com/pb33f/libopenapi-validator/issues/247
+// where the validator would fail with "json-pointer not found" because discriminator refs
+// were preserved (Bundle mode) instead of fully inlined (Validation mode).
+func TestValidateHttpResponse_DiscriminatorOneOf(t *testing.T) {
+	spec := `openapi: 3.1.0
+info:
+  title: Discriminator OneOf Response Test
+  version: 1.0.0
+paths:
+  /fields:
+    get:
+      responses:
+        '200':
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Field'
+components:
+  schemas:
+    BooleanField:
+      type: object
+      required:
+        - field_type
+        - default_value
+      properties:
+        field_type:
+          type: string
+          const: boolean
+        default_value:
+          type: boolean
+    StringField:
+      type: object
+      required:
+        - field_type
+        - max_length
+      properties:
+        field_type:
+          type: string
+          const: string
+        max_length:
+          type: integer
+          minimum: 1
+    Field:
+      oneOf:
+        - $ref: '#/components/schemas/BooleanField'
+        - $ref: '#/components/schemas/StringField'
+      discriminator:
+        propertyName: field_type`
+
+	doc, err := libopenapi.NewDocument([]byte(spec))
+	require.NoError(t, err)
+
+	v, errs := NewValidator(doc)
+	require.Empty(t, errs)
+
+	// Valid BooleanField response
+	body, _ := json.Marshal(map[string]interface{}{
+		"field_type":    "boolean",
+		"default_value": true,
+	})
+	request, _ := http.NewRequest(http.MethodGet, "https://example.com/fields", nil)
+	response := &http.Response{
+		StatusCode: 200,
+		Header:     http.Header{"Content-Type": []string{"application/json"}},
+		Body:       io.NopCloser(bytes.NewBuffer(body)),
+	}
+
+	valid, validationErrors := v.ValidateHttpResponse(request, response)
+	assert.True(t, valid, "response validation should pass for valid discriminator oneOf payload")
+	assert.Empty(t, validationErrors, "no validation errors expected")
+
+	// Valid StringField response
+	body2, _ := json.Marshal(map[string]interface{}{
+		"field_type": "string",
+		"max_length": 255,
+	})
+	request2, _ := http.NewRequest(http.MethodGet, "https://example.com/fields", nil)
+	response2 := &http.Response{
+		StatusCode: 200,
+		Header:     http.Header{"Content-Type": []string{"application/json"}},
+		Body:       io.NopCloser(bytes.NewBuffer(body2)),
+	}
+
+	valid2, validationErrors2 := v.ValidateHttpResponse(request2, response2)
+	assert.True(t, valid2, "response validation should pass for valid StringField payload")
+	assert.Empty(t, validationErrors2, "no validation errors expected for StringField")
+}