do not perform the same check twice

Author: pirafrank

github.js

@@ -3,7 +3,7 @@ const CURRENT_VERSION = require("./package.json").version;
 
 const {
   init,
-  extractChangedOrDeletedFiles,
+  checkChangedOrDeletedFiles,
   createCommitOnBranch,
   checkIfBranchExists,
 } = require("./index");
@@ -58,8 +58,7 @@ yargs
               "Missing required argument: either specify changed or deleted files."
             );
           }
-          extractChangedOrDeletedFiles(argv.changed, argv.deleted);
-          return true;
+          return checkChangedOrDeletedFiles(argv.changed, argv.deleted);
         });
     },
     (argv) => {

index.js

@@ -37,21 +37,29 @@ function init(token, apiUrl) {
   });
 }
 
+function arrayIsArray(array) {
+  return !!array && Array.isArray(array);
+}
+
 function arrayHasElements(array) {
-  return array && Array.isArray(array) && array.length > 0;
+  return arrayIsArray(array) && array.length > 0;
 }
 
-function extractChangedOrDeletedFiles(changedFiles, deletedFiles) {
+function checkChangedOrDeletedFiles(changedFiles, deletedFiles) {
   const changedFilesExist = arrayHasElements(changedFiles);
   const deletedFilesExist = arrayHasElements(deletedFiles);
 
   if (!changedFilesExist && !deletedFilesExist) {
     throw new Error("No files specified as changed or deleted. Quitting.");
   }
 
+  return true;
+}
+
+function extractChangedOrDeletedFiles(changedFiles, deletedFiles) {
   return {
-    changedFiles: changedFilesExist ? changedFiles : [],
-    deletedFiles: deletedFilesExist ? deletedFiles : [],
+    changedFiles: arrayIsArray(changedFiles) ? changedFiles : [],
+    deletedFiles: arrayIsArray(deletedFiles) ? deletedFiles : [],
   };
 }
 
@@ -181,6 +189,7 @@ async function createCommitOnBranch(
 
 module.exports = {
   init,
+  checkChangedOrDeletedFiles,
   extractChangedOrDeletedFiles,
   createCommitOnBranch,
   checkIfBranchExists,