feat: load imports from another repo

Author: dominykas

lib/travis/index.js

@@ -1,11 +1,18 @@
 'use strict';
 
+const Debug = require('debug');
 const Nv = require('@pkgjs/nv');
 const Yaml = require('js-yaml');
 
+const Loader = require('./loader');
+
 
 const internals = {};
 
+
+internals.log = Debug('detect-node-support');
+
+
 internals.nodeAliases = {
     latest: 'active',
     node: 'active',
@@ -49,7 +56,31 @@ internals.normalizeImports = (travisYaml, { relativeTo }) => {
 };
 
 
-internals.applyImports = async (yaml, { loadFile, relativeTo }) => {
+internals.loadSource = async (source, { loadFile, cache }) => {
+
+    if (cache[source]) {
+        internals.log('Returning cached %s', source);
+        return cache[source];
+    }
+
+    let path = source;
+
+    if (source.includes(':')) {
+        const [repository, fileName] = source.split(':');
+        const loader = await Loader.create({ repository: `https://github.com/${repository}` });
+
+        path = fileName;
+        loadFile = loader.loadFile;
+    }
+
+    internals.log('Loading %s', source);
+    const result = await loadFile(path);
+    cache[source] = result;
+    return result;
+};
+
+
+internals.applyImports = async (yaml, { loadFile, relativeTo, cache = new Map() }) => {
 
     if (!yaml.import) {
         return;
@@ -59,14 +90,14 @@ internals.applyImports = async (yaml, { loadFile, relativeTo }) => {
 
     for (const entry of imports) {
 
-        const buffer = await loadFile(entry.source);
+        const buffer = await internals.loadSource(entry.source, { loadFile, cache });
 
         const imported = Yaml.safeLoad(buffer, {
             schema: Yaml.FAILSAFE_SCHEMA,
             json: true
         });
 
-        await internals.applyImports(imported, { loadFile, relativeTo: entry });
+        await internals.applyImports(imported, { loadFile, relativeTo: entry, cache });
 
         for (const key in imported) {
 

test/fixtures/travis-ymls/testing-imports/another-repo.yml

@@ -0,0 +1,4 @@
+language: node_js
+import:
+  - source: pkgjs/detect-node-support:test/fixtures/travis-ymls/testing-imports/partials/indirect-node-14.yml
+  - source: pkgjs/detect-node-support:test/fixtures/travis-ymls/testing-imports/partials/node-14.yml # cache hit

test/travis.js

@@ -1,5 +1,9 @@
 'use strict';
 
+const Fs = require('fs');
+const Nock = require('nock');
+const Path = require('path');
+
 const NodeSupport = require('..');
 
 const TestContext = require('./fixtures');
@@ -125,4 +129,32 @@ describe('.travis.yml parsing', () => {
         });
     });
 
+    it('resolves from another repo', async () => {
+
+        Nock('https://raw.githubusercontent.com')
+            .get('/pkgjs/detect-node-support/HEAD/test/fixtures/travis-ymls/testing-imports/partials/indirect-node-14.yml')
+            .reply(200, Fs.readFileSync(Path.join(__dirname, 'fixtures', 'travis-ymls', 'testing-imports', 'partials', 'indirect-node-14.yml')))
+            .get('/pkgjs/detect-node-support/HEAD/test/fixtures/travis-ymls/testing-imports/partials/node-14.yml')
+            .reply(200, Fs.readFileSync(Path.join(__dirname, 'fixtures', 'travis-ymls', 'testing-imports', 'partials', 'node-14.yml')));
+
+        await fixture.setupRepoFolder({
+            partials: true,
+            travisYml: `testing-imports/another-repo.yml`
+        });
+
+        const result = await NodeSupport.detect({ path: fixture.path });
+
+        internals.assertCommit(result);
+
+        expect(result).to.equal({
+            name: 'test-module',
+            version: '0.0.0-development',
+            timestamp: 1580673602000,
+            travis: {
+                raw: ['14'],
+                resolved: { '14': '14.3.0' }
+            }
+        });
+    });
+
 });