Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Commit b9e84cb

Browse files
authored
Merge pull request #659 from lukaszstolarczuk/skip-pmdk-and-valgrind-when-not-needed
Add skip flags for additional artifacts built/installed in dockerimages
2 parents f3d66e8 + 1ebf265 commit b9e84cb

4 files changed

Lines changed: 22 additions & 4 deletions

File tree

utils/docker/images/Dockerfile.fedora-30

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright 2016-2019, Intel Corporation
2+
# Copyright 2016-2020, Intel Corporation
33
#
44
# Redistribution and use in source and binary forms, with or without
55
# modification, are permitted provided that the following conditions
@@ -38,6 +38,10 @@
3838
FROM fedora:30
3939
MAINTAINER marcin.slusarz@intel.com
4040

41+
# Additional parameters to build docker without building components
42+
ARG SKIP_VALGRIND_BUILD
43+
ARG SKIP_PMDK_BUILD
44+
4145
# Install basic tools
4246
RUN dnf update -y \
4347
&& dnf install -y \

utils/docker/images/Dockerfile.ubuntu-19.04

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright 2016-2019, Intel Corporation
2+
# Copyright 2016-2020, Intel Corporation
33
#
44
# Redistribution and use in source and binary forms, with or without
55
# modification, are permitted provided that the following conditions
@@ -38,6 +38,10 @@
3838
FROM ubuntu:19.04
3939
MAINTAINER marcin.slusarz@intel.com
4040

41+
# Additional parameters to build docker without building components
42+
ARG SKIP_VALGRIND_BUILD
43+
ARG SKIP_PMDK_BUILD
44+
4145
ENV DEBIAN_FRONTEND noninteractive
4246

4347
# Update the Apt cache and install basic tools

utils/docker/images/install-pmdk.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22
#
3-
# Copyright 2018-2019, Intel Corporation
3+
# Copyright 2018-2020, Intel Corporation
44
#
55
# Redistribution and use in source and binary forms, with or without
66
# modification, are permitted provided that the following conditions
@@ -36,6 +36,11 @@
3636

3737
set -e
3838

39+
if [ "${SKIP_PMDK_BUILD}" ]; then
40+
echo "Variable 'SKIP_PMDK_BUILD' is set; skipping building PMDK"
41+
exit
42+
fi
43+
3944
git clone https://github.com/pmem/pmdk
4045
cd pmdk
4146
# stable-1.6: common: fix typo

utils/docker/images/install-valgrind.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22
#
3-
# Copyright 2016-2019, Intel Corporation
3+
# Copyright 2016-2020, Intel Corporation
44
#
55
# Redistribution and use in source and binary forms, with or without
66
# modification, are permitted provided that the following conditions
@@ -36,6 +36,11 @@
3636

3737
set -e
3838

39+
if [ "${SKIP_VALGRIND_BUILD}" ]; then
40+
echo "Variable 'SKIP_VALGRIND_BUILD' is set; skipping building valgrind (pmem's fork)"
41+
exit
42+
fi
43+
3944
git clone --recursive https://github.com/pmem/valgrind.git
4045
cd valgrind
4146
# pmem-3.14: fix memcheck failure on Ubuntu-19.04

0 commit comments

Comments
 (0)