cmake: fix finding proper version of pmreorder

version comparison should be used, instead of string comparison.
Simplify the function, by the way.

Author: lukaszstolarczuk

tests/ctest_helpers.cmake

@@ -70,22 +70,21 @@ function(find_pmreorder)
 		return()
 	endif()
 
-	if((NOT(PMEMCHECK_VERSION LESS 1.0)) AND PMEMCHECK_VERSION LESS 2.0)
+	if((NOT(PMEMCHECK_VERSION VERSION_LESS 1.0)) AND PMEMCHECK_VERSION VERSION_LESS 2.0)
 		find_program(PMREORDER names pmreorder HINTS ${LIBPMEMOBJ_PREFIX}/bin)
-		get_program_version_major_minor(${PMREORDER} PMREORDER_VERSION)
-		message(STATUS "pmreorder found: ${PMREORDER}, in version: ${PMREORDER_VERSION}")
 
-		if(PMREORDER_VERSION EQUAL PMREORDER_REQUIRED_VERSION OR PMREORDER_VERSION GREATER PMREORDER_REQUIRED_VERSION)
-			set(PROPER_PMREORDER_VERSION 1)
-		endif()
+		if(PMREORDER)
+			get_program_version_major_minor(${PMREORDER} PMREORDER_VERSION)
+			message(STATUS "pmreorder found: ${PMREORDER}, in version: ${PMREORDER_VERSION}")
 
-		if(PMREORDER AND PROPER_PMREORDER_VERSION)
-			set(ENV{PATH} ${LIBPMEMOBJ_PREFIX}/bin:$ENV{PATH})
-			set(PMREORDER_SUPPORTED true CACHE INTERNAL "pmreorder support")
-		elseif(NOT PMREORDER)
+			if(PMREORDER_VERSION VERSION_EQUAL PMREORDER_REQUIRED_VERSION OR PMREORDER_VERSION VERSION_GREATER PMREORDER_REQUIRED_VERSION)
+				set(ENV{PATH} ${LIBPMEMOBJ_PREFIX}/bin:$ENV{PATH})
+				set(PMREORDER_SUPPORTED true CACHE INTERNAL "pmreorder support")
+			else()
+				message(WARNING "Pmreorder should be in version >= ${PMREORDER_REQUIRED_VERSION} - pmreorder tests will not be performed.")
+			endif()
+		else()
 			message(WARNING "Pmreorder not found - pmreorder tests will not be performed.")
-		elseif(NOT PROPER_PMREORDER_VERSION)
-			message(WARNING "Pmreorder should be in version >= ${PMREORDER_REQUIRED_VERSION} - pmreorder tests will not be performed.")
 		endif()
 	else()
 		message(WARNING "Pmemcheck must be installed in version 1.X for pmreorder to work - pmreorder tests will not be performed.")