Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Commit e3a46cb

Browse files
cmake: change default CMAKE_BUILD_TYPE to RelWithDebInfo
in the past some users run e.g. benchmarks and was surprised with the results. Using release version should omit that problem. Documentation is updated as well to point users with proper CMake parameter.
1 parent a10ad3b commit e3a46cb

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ set(TEST_DIR ${CMAKE_CURRENT_BINARY_DIR}/test CACHE STRING "working directory fo
4141
message(STATUS "TEST_DIR set to: \"${TEST_DIR}\"")
4242

4343
if(NOT CMAKE_BUILD_TYPE)
44-
set(CMAKE_BUILD_TYPE "Debug")
44+
set(CMAKE_BUILD_TYPE "RelWithDebInfo")
4545
endif()
4646

4747
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${LIBPMEMOBJCPP_ROOT_DIR}/cmake)

ChangeLog

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ XXX Igor Chorążewicz <igor.chorazewicz@intel.com>
99
-
1010

1111
Other changes:
12+
- Switched default CMake's build type from "Debug" to "RelWithDebInfo"
13+
it's relevant for a GitHub users (who may e.g. run some benchmarks)
1214
-
1315

1416
Mon Feb 15 2021 Igor Chorążewicz <igor.chorazewicz@intel.com>

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ You will need the following packages for compilation:
8686
```
8787
$ mkdir build
8888
$ cd build
89-
$ cmake .. [-DCMAKE_INSTALL_PREFIX=<path_to_installation_dir>]
89+
$ cmake .. [-DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=<path_to_installation_dir>]
9090
$ make
9191
# make install
9292
```

0 commit comments

Comments
 (0)