Skip to content

Commit 3fa1ace

Browse files
committed
Unpacker.Try* throw IOException if stream ends
Previously they would sometimes return false, sometimes throw. It's more consistent this way.
1 parent 678d9e4 commit 3fa1ace

2 files changed

Lines changed: 254 additions & 276 deletions

File tree

Dasher.Tests/DeserialiserTests.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,11 +189,10 @@ public void ThrowsOnEmptyData()
189189
var bytes = new byte[0];
190190

191191
var deserialiser = new Deserialiser<UserScore>();
192-
var ex = Assert.Throws<DeserialisationException>(
192+
var ex = Assert.Throws<IOException>(
193193
() => deserialiser.Deserialise(bytes));
194194

195-
Assert.Equal(typeof(UserScore), ex.TargetType);
196-
Assert.Equal("Data stream empty", ex.Message);
195+
Assert.Equal("End of stream reached.", ex.Message);
197196
}
198197

199198
[Fact]

0 commit comments

Comments
 (0)