Merge pull request #533 from neutrinoceros/bug/520-leak

neutrinoceros · web-flow · commit b1cd15a93df8 · 2026-03-31T09:44:20.000+02:00
diff --git a/bottleneck/src/nonreduce_axis_template.c b/bottleneck/src/nonreduce_axis_template.c
@@ -61,6 +61,7 @@ NRA(partition, DTYPE0) {
         PyErr_Format(PyExc_ValueError,
                      "`n` (=%d) must be between 0 and %zd, inclusive.",
                      n, LENGTH - 1);
+        Py_DECREF(a);
         return NULL;
     }
 
@@ -172,6 +173,7 @@ NRA(argpartition, DTYPE0) {
         PyErr_Format(PyExc_ValueError,
                      "`n` (=%d) must be between 0 and %zd, inclusive.",
                      n, LENGTH - 1);
+        Py_DECREF(y);
         return NULL;
     }
     BN_BEGIN_ALLOW_THREADS

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ NRA(partition, DTYPE0) {`
`61`	`61`	`PyErr_Format(PyExc_ValueError,`
`62`	`62`	"`n` (=%d) must be between 0 and %zd, inclusive.",
`63`	`63`	`n, LENGTH - 1);`
	`64`	`+ Py_DECREF(a);`
`64`	`65`	`return NULL;`
`65`	`66`	`}`
`66`	`67`
`@@ -172,6 +173,7 @@ NRA(argpartition, DTYPE0) {`
`172`	`173`	`PyErr_Format(PyExc_ValueError,`
`173`	`174`	"`n` (=%d) must be between 0 and %zd, inclusive.",
`174`	`175`	`n, LENGTH - 1);`
	`176`	`+ Py_DECREF(y);`
`175`	`177`	`return NULL;`
`176`	`178`	`}`
`177`	`179`	`BN_BEGIN_ALLOW_THREADS`