Skip to content

Commit b348ef2

Browse files
authored
Rename job.core -> job.base in static strings (#1906)
This was missing in #1862 and broke job.refresh_job_status for job paths.
1 parent 9bf6880 commit b348ef2

3 files changed

Lines changed: 22 additions & 22 deletions

File tree

pyiron_base/jobs/job/extension/server/queuestatus.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ def validate_que_request(
414414
que_id = item.server.queue_id
415415
else:
416416
raise ValueError("This job does not have a queue ID.")
417-
elif static_isinstance(item.__class__, "pyiron_base.jobs.job.core.JobCore"):
417+
elif static_isinstance(item.__class__, "pyiron_base.jobs.job.base.JobCore"):
418418
if "server" in item.project_hdf5.list_nodes():
419419
server_hdf_dict = item.project_hdf5["server"]
420420
if "qid" in server_hdf_dict.keys():

pyiron_base/jobs/job/generic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ def _internal_copy_to(
664664

665665
# Reload object from HDF5 file
666666
if not static_isinstance(
667-
obj=project.__class__, obj_type="pyiron_base.jobs.job.core.JobCore"
667+
obj=project.__class__, obj_type="pyiron_base.jobs.job.base.JobCore"
668668
):
669669
_job_reload_after_copy(
670670
job=new_job_core, delete_file_after_copy=delete_file_after_copy

pyiron_base/jobs/job/util.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ def _copy_to_delete_existing(
9797

9898

9999
def _get_project_for_copy(
100-
job: "pyiron_base.jobs.job.core.JobCore",
100+
job: "pyiron_base.jobs.job.base.JobCore",
101101
project: Optional[
102102
Union[
103103
"pyiron_base.project.generic.Project",
104-
"pyiron_base.jobs.job.core.JobCore",
104+
"pyiron_base.jobs.job.base.JobCore",
105105
"pyiron_base.storage.hdfio.ProjectHDFio",
106106
]
107107
],
@@ -124,7 +124,7 @@ def _get_project_for_copy(
124124
Project, ProjectHDFio
125125
"""
126126
if static_isinstance(
127-
obj=project.__class__, obj_type="pyiron_base.jobs.job.core.JobCore"
127+
obj=project.__class__, obj_type="pyiron_base.jobs.job.base.JobCore"
128128
):
129129
file_project = project.project
130130
hdf5_project = project.project_hdf5.open(new_job_name)
@@ -193,7 +193,7 @@ def round_(value, ndigits=ndigits):
193193

194194
def _rename_job(
195195
job: Union[
196-
"pyiron_base.jobs.job.generic.GenericJob", "pyiron_base.jobs.job.core.JobCore"
196+
"pyiron_base.jobs.job.generic.GenericJob", "pyiron_base.jobs.job.base.JobCore"
197197
],
198198
new_job_name: str,
199199
) -> None:
@@ -275,7 +275,7 @@ def _copy_restart_files(job: "pyiron_base.jobs.job.generic.GenericJob") -> None:
275275
)
276276

277277

278-
def _kill_child(job: "pyiron_base.jobs.job.core.JobCore") -> None:
278+
def _kill_child(job: "pyiron_base.jobs.job.base.JobCore") -> None:
279279
"""
280280
Internal helper function to kill a child process.
281281
@@ -302,13 +302,13 @@ def _kill_child(job: "pyiron_base.jobs.job.core.JobCore") -> None:
302302
job_process.kill()
303303

304304

305-
def _job_compressed_name(job: "pyiron_base.jobs.job.core.JobCore") -> str:
305+
def _job_compressed_name(job: "pyiron_base.jobs.job.base.JobCore") -> str:
306306
"""Return the canonical file name of a compressed job."""
307307
return _get_compressed_job_name(working_directory=job.working_directory)
308308

309309

310310
def _get_compressed_job_name(
311-
working_directory: "pyiron_base.jobs.job.core.JobCore",
311+
working_directory: "pyiron_base.jobs.job.base.JobCore",
312312
) -> str:
313313
"""Return the canonical file name of a compressed job from the working directory."""
314314
return os.path.join(
@@ -317,7 +317,7 @@ def _get_compressed_job_name(
317317

318318

319319
def _job_compress(
320-
job: "pyiron_base.jobs.job.core.JobCore",
320+
job: "pyiron_base.jobs.job.base.JobCore",
321321
files_to_compress: list = [],
322322
files_to_remove: list = [],
323323
) -> None:
@@ -359,7 +359,7 @@ def delete_file_or_folder(fullname):
359359
logger.info("The files are already compressed!")
360360

361361

362-
def _job_decompress(job: "pyiron_base.jobs.job.core.JobCore") -> None:
362+
def _job_decompress(job: "pyiron_base.jobs.job.base.JobCore") -> None:
363363
"""
364364
Decompress the output files of a compressed job object.
365365
@@ -391,7 +391,7 @@ def _working_directory_is_compressed(working_directory: str) -> bool:
391391
return compressed_name in os.listdir(working_directory)
392392

393393

394-
def _job_is_compressed(job: "pyiron_base.jobs.job.core.JobCore") -> bool:
394+
def _job_is_compressed(job: "pyiron_base.jobs.job.base.JobCore") -> bool:
395395
"""
396396
Check if the job is already compressed or not.
397397
@@ -438,7 +438,7 @@ def _working_directory_list_files(
438438
return []
439439

440440

441-
def _job_list_files(job: "pyiron_base.jobs.job.core.JobCore") -> list:
441+
def _job_list_files(job: "pyiron_base.jobs.job.base.JobCore") -> list:
442442
"""
443443
Returns list of files in the jobs working directory.
444444
@@ -515,7 +515,7 @@ def _working_directory_read_file(
515515

516516

517517
def _job_read_file(
518-
job: "pyiron_base.jobs.job.core.JobCore", file_name: str, tail: Optional[int] = None
518+
job: "pyiron_base.jobs.job.base.JobCore", file_name: str, tail: Optional[int] = None
519519
) -> list:
520520
"""
521521
Return list of lines of the given file.
@@ -537,7 +537,7 @@ def _job_read_file(
537537
)
538538

539539

540-
def _job_archive(job: "pyiron_base.jobs.job.core.JobCore") -> None:
540+
def _job_archive(job: "pyiron_base.jobs.job.base.JobCore") -> None:
541541
"""
542542
Compress HDF5 file of the job object to tar-archive
543543
@@ -566,7 +566,7 @@ def _job_archive(job: "pyiron_base.jobs.job.core.JobCore") -> None:
566566
os.chdir(cwd)
567567

568568

569-
def _job_unarchive(job: "pyiron_base.jobs.job.core.JobCore") -> None:
569+
def _job_unarchive(job: "pyiron_base.jobs.job.base.JobCore") -> None:
570570
"""
571571
Decompress HDF5 file of the job object from tar-archive
572572
@@ -583,7 +583,7 @@ def _job_unarchive(job: "pyiron_base.jobs.job.core.JobCore") -> None:
583583
pass
584584

585585

586-
def _job_is_archived(job: "pyiron_base.jobs.job.core.JobCore") -> bool:
586+
def _job_is_archived(job: "pyiron_base.jobs.job.base.JobCore") -> bool:
587587
"""
588588
Check if the HDF5 file of the Job is compressed as tar-archive
589589
@@ -598,7 +598,7 @@ def _job_is_archived(job: "pyiron_base.jobs.job.core.JobCore") -> bool:
598598
)
599599

600600

601-
def _job_delete_hdf(job: "pyiron_base.jobs.job.core.JobCore") -> None:
601+
def _job_delete_hdf(job: "pyiron_base.jobs.job.base.JobCore") -> None:
602602
"""
603603
Delete HDF5 file of job object
604604
@@ -609,7 +609,7 @@ def _job_delete_hdf(job: "pyiron_base.jobs.job.core.JobCore") -> None:
609609
os.remove(job.project_hdf5.file_name)
610610

611611

612-
def _job_delete_files(job: "pyiron_base.jobs.job.core.JobCore") -> None:
612+
def _job_delete_files(job: "pyiron_base.jobs.job.base.JobCore") -> None:
613613
"""
614614
Delete files in the working directory of job object
615615
@@ -623,7 +623,7 @@ def _job_delete_files(job: "pyiron_base.jobs.job.core.JobCore") -> None:
623623
job._import_directory = None
624624

625625

626-
def _job_remove_folder(job: "pyiron_base.jobs.job.core.JobCore") -> None:
626+
def _job_remove_folder(job: "pyiron_base.jobs.job.base.JobCore") -> None:
627627
"""
628628
Delete the working directory of the job object
629629
@@ -635,7 +635,7 @@ def _job_remove_folder(job: "pyiron_base.jobs.job.core.JobCore") -> None:
635635
shutil.rmtree(working_directory)
636636

637637

638-
def _job_store_before_copy(job: "pyiron_base.jobs.job.core.JobCore") -> bool:
638+
def _job_store_before_copy(job: "pyiron_base.jobs.job.base.JobCore") -> bool:
639639
"""
640640
Store job in HDF5 file for copying
641641
@@ -654,7 +654,7 @@ def _job_store_before_copy(job: "pyiron_base.jobs.job.core.JobCore") -> bool:
654654

655655

656656
def _job_reload_after_copy(
657-
job: "pyiron_base.jobs.job.core.JobCore", delete_file_after_copy: bool
657+
job: "pyiron_base.jobs.job.base.JobCore", delete_file_after_copy: bool
658658
) -> None:
659659
"""
660660
Reload job from HDF5 file after copying

0 commit comments

Comments
 (0)