Only run the slurm jobs on PRs (#725)

* Only run the slurm jobs on PRs

Not on pushes to main. On pushing to main I have no chance to re-run the job, and koesterlab/setup-slurm-action fails by timing out annoyingly often (>10% of the time?)

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Don't assume there's still a future

The task is so fast, on some machines there's already no future left.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

---------

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

Author: liamhuber

.github/workflows/push-pull.yml

@@ -28,11 +28,13 @@ jobs:
       do-mypy: true
 
   slurm-interruption:
+    if: github.event_name == 'pull_request'
     uses: ./.github/workflows/slurm-test.yml
     with:
       mode: interrupt
 
   slurm-discovery:
+    if: github.event_name == 'pull_request'
     uses: ./.github/workflows/slurm-test.yml
     with:
       mode: discover

tests/unit/test_workflow.py

@@ -543,9 +543,9 @@ def test_pickle(self):
     def test_repeated_thread_runs(self):
         wf = Workflow("wf")
         wf.n = demo_nodes.AddThree(x=0)
-        f = wf.run_in_thread()
+        wf.run_in_thread()
 
-        self.assertEqual(f.result(), wf, msg="Background run should complete")
+        sleep(0.1)
         self.assertEqual(wf.n.outputs.add_three.value, 3, msg="Sanity check")
         max_waits = 10
         while wf.executor is not None: