Add missing samples

Author: pablogsal

Lib/profiling/sampling/flamegraph.js

@@ -76,7 +76,7 @@ function toggleSidebar() {
   const sidebar = document.getElementById('sidebar');
   if (sidebar) {
     const isCollapsing = !sidebar.classList.contains('collapsed');
-    
+
     if (isCollapsing) {
       // Save current width before collapsing
       const currentWidth = sidebar.offsetWidth;
@@ -89,7 +89,7 @@ function toggleSidebar() {
         sidebar.style.width = savedWidth + 'px';
       }
     }
-    
+
     sidebar.classList.toggle('collapsed');
     localStorage.setItem('flamegraph-sidebar', sidebar.classList.contains('collapsed') ? 'collapsed' : 'expanded');
 
@@ -558,11 +558,11 @@ function initSidebarResize() {
       isResizing = false;
       resizeHandle.classList.remove('resizing');
       document.body.classList.remove('resizing-sidebar');
-      
+
       // Save the new width
       const width = sidebar.offsetWidth;
       localStorage.setItem('flamegraph-sidebar-width', width);
-      
+
       // Resize chart after sidebar resize
       setTimeout(() => {
         resizeChart();
@@ -666,6 +666,7 @@ function populateProfileSummary(data) {
   const duration = stats.duration_sec || 0;
   const sampleRate = stats.sample_rate || (duration > 0 ? totalSamples / duration : 0);
   const errorRate = stats.error_rate || 0;
+  const missedSamples= stats.missed_samples || 0;
 
   const samplesEl = document.getElementById('stat-total-samples');
   if (samplesEl) samplesEl.textContent = formatNumber(totalSamples);
@@ -701,6 +702,19 @@ function populateProfileSummary(data) {
     const efficiencyFill = document.getElementById('efficiency-fill');
     if (efficiencyFill) efficiencyFill.style.width = efficiency + '%';
   }
+  // MissedSamples bar
+  if (missedSamples !== undefined && missedSamples !== null) {
+    const sampleEfficiency = Math.max(0, missedSamples);
+
+    const efficiencySection = document.getElementById('efficiency-section');
+    if (efficiencySection) efficiencySection.style.display = 'block';
+
+    const sampleEfficiencyValue = document.getElementById('stat-missed-samples');
+    if (sampleEfficiencyValue) sampleEfficiencyValue.textContent = sampleEfficiency.toFixed(1) + '%';
+
+    const sampleEfficiencyFill = document.getElementById('missed-samples-fill');
+    if (sampleEfficiencyFill) sampleEfficiencyFill.style.width = sampleEfficiency + '%';
+  }
 }
 
 // ============================================================================

Lib/profiling/sampling/flamegraph_template.html

@@ -123,6 +123,14 @@ <h3 class="section-title">Profile Summary</h3>
                   <div class="efficiency-bar">
                     <div class="efficiency-fill" id="efficiency-fill"></div>
                   </div>
+                  <div class="missed-samples-header">
+                    <span class="efficiency-label">Missed samples</span>
+                    <span class="efficiency-value" id="stat-missed-samples">--</span>
+                  </div>
+                  <div class="efficiency-bar">
+                    <div class="efficiency-fill" id="missed-samples-fill"></div>
+                  </div>
+ 
                 </div>
               </div>
             </section>

Lib/profiling/sampling/sample.py

@@ -108,6 +108,8 @@ def sample(self, collector, duration_sec=10):
 
         sample_rate = num_samples / running_time
         error_rate = (errors / num_samples) * 100 if num_samples > 0 else 0
+        expected_samples = int(duration_sec / sample_interval_sec)
+        missed_samples = (expected_samples - num_samples) / expected_samples * 100
 
         # Don't print stats for live mode (curses is handling display)
         is_live_mode = LiveStatsCollector is not None and isinstance(collector, LiveStatsCollector)
@@ -118,9 +120,8 @@ def sample(self, collector, duration_sec=10):
 
         # Pass stats to flamegraph collector if it's the right type
         if hasattr(collector, 'set_stats'):
-            collector.set_stats(self.sample_interval_usec, running_time, sample_rate, error_rate, mode=self.mode)
+            collector.set_stats(self.sample_interval_usec, running_time, sample_rate, error_rate, missed_samples, mode=self.mode)
 
-        expected_samples = int(duration_sec / sample_interval_sec)
         if num_samples < expected_samples and not is_live_mode:
             print(
                 f"Warning: missed {expected_samples - num_samples} samples "

Lib/profiling/sampling/stack_collector.py

@@ -113,13 +113,15 @@ def collect(self, stack_frames, skip_idle=False):
         # Call parent collect to process frames
         super().collect(stack_frames, skip_idle=skip_idle)
 
-    def set_stats(self, sample_interval_usec, duration_sec, sample_rate, error_rate=None, mode=None):
+    def set_stats(self, sample_interval_usec, duration_sec, sample_rate,
+                  error_rate=None, missed_samples=None, mode=None):
         """Set profiling statistics to include in flamegraph data."""
         self.stats = {
             "sample_interval_usec": sample_interval_usec,
             "duration_sec": duration_sec,
             "sample_rate": sample_rate,
             "error_rate": error_rate,
+            "missed_samples": missed_samples,
             "mode": mode
         }