Skip to content

Commit 64834a9

Browse files
committed
gh-89520: IDLE - Preserve public API parameter names in config.py
Restore the original extensionName parameter name on GetExtensionKeys and GetExtensionBindings to avoid breaking callers using keyword arguments.
1 parent 0a8ae1a commit 64834a9

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

Lib/idlelib/config.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -469,14 +469,14 @@ def GetExtnNameForEvent(self, virtualEvent):
469469
extName = extn # TODO return here?
470470
return extName
471471

472-
def GetExtensionKeys(self, extension_name):
472+
def GetExtensionKeys(self, extensionName):
473473
"""Return dict: {configurable extensionName event : active keybinding}.
474474
475475
Events come from default config extension_cfgBindings section.
476476
Keybindings come from GetCurrentKeySet() active key dict,
477477
where previously used bindings are disabled.
478478
"""
479-
bindings_section = f'{extension_name}_cfgBindings'
479+
bindings_section = f'{extensionName}_cfgBindings'
480480
current_keyset = self.GetCurrentKeySet()
481481
extension_keys = {}
482482

@@ -529,15 +529,15 @@ def __GetRawExtensionKeys(self, extension_name):
529529
extension_keys[event] = binding
530530
return extension_keys
531531

532-
def GetExtensionBindings(self, extension_name):
532+
def GetExtensionBindings(self, extensionName):
533533
"""Return dict {extensionName event : active or defined keybinding}.
534534
535535
Augment self.GetExtensionKeys(extensionName) with mapping of non-
536536
configurable events (from default config) to GetOption splits,
537537
as in self.__GetRawExtensionKeys.
538538
"""
539-
bindings_section = f'{extension_name}_bindings'
540-
extension_keys = self.GetExtensionKeys(extension_name)
539+
bindings_section = f'{extensionName}_bindings'
540+
extension_keys = self.GetExtensionKeys(extensionName)
541541

542542
# add the non-configurable bindings
543543
event_names = set()

0 commit comments

Comments
 (0)