gh-142438: Added missing GIL release in _PySSL_keylog_callback when keylog_bio is unset

LumioseSil · LumioseSil · commit 6af3c8bb4573 · 2025-12-08T18:13:04.000-05:00
In the early return, threadstate is leaked.

We have to release it.
diff --git a/Misc/NEWS.d/next/Library/2025-12-08-18-12-44.gh-issue-142438.UF_0nd.rst b/Misc/NEWS.d/next/Library/2025-12-08-18-12-44.gh-issue-142438.UF_0nd.rst
@@ -0,0 +1,2 @@
+Added a missing GIL release in _PySSL_keylog_callback when keylog_bio is
+unset, preventing a leaked GIL in that early-return path.
diff --git a/Modules/_ssl/debughelpers.c b/Modules/_ssl/debughelpers.c
@@ -131,6 +131,7 @@ _PySSL_keylog_callback(const SSL *ssl, const char *line)
     PyThread_type_lock lock = get_state_sock(ssl_obj)->keylog_lock;
     assert(lock != NULL);
     if (ssl_obj->ctx->keylog_bio == NULL) {
+        PyGILState_Release(threadstate);
         return;
     }
     /*

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Added a missing GIL release in _PySSL_keylog_callback when keylog_bio is`
	`2`	`+unset, preventing a leaked GIL in that early-return path.`
Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ _PySSL_keylog_callback(const SSL ssl, const char line)`
`131`	`131`	`PyThread_type_lock lock = get_state_sock(ssl_obj)->keylog_lock;`
`132`	`132`	`assert(lock != NULL);`
`133`	`133`	`if (ssl_obj->ctx->keylog_bio == NULL) {`
	`134`	`+ PyGILState_Release(threadstate);`
`134`	`135`	`return;`
`135`	`136`	`}`
`136`	`137`	`/*`