Lock both so and otherset when setting a symmetric difference

LumioseSil · LumioseSil · commit 711a5c0101bb · 2025-12-07T23:37:42.000-05:00
diff --git a/Objects/setobject.c b/Objects/setobject.c
@@ -2005,9 +2005,9 @@ set_symmetric_difference_update_impl(PySetObject *so, PyObject *other)
             return NULL;
         }
 
-        Py_BEGIN_CRITICAL_SECTION(so);
+        Py_BEGIN_CRITICAL_SECTION2(so, otherset);
         rv = set_symmetric_difference_update_set(so, otherset);
-        Py_END_CRITICAL_SECTION();
+        Py_END_CRITICAL_SECTION2();
 
         Py_DECREF(otherset);
     }

Original file line number	Diff line number	Diff line change
`@@ -2005,9 +2005,9 @@ set_symmetric_difference_update_impl(PySetObject so, PyObject other)`
`2005`	`2005`	`return NULL;`
`2006`	`2006`	`}`
`2007`	`2007`
`2008`		`- Py_BEGIN_CRITICAL_SECTION(so);`
	`2008`	`+ Py_BEGIN_CRITICAL_SECTION2(so, otherset);`
`2009`	`2009`	`rv = set_symmetric_difference_update_set(so, otherset);`
`2010`		`- Py_END_CRITICAL_SECTION();`
	`2010`	`+ Py_END_CRITICAL_SECTION2();`
`2011`	`2011`
`2012`	`2012`	`Py_DECREF(otherset);`
`2013`	`2013`	`}`