Skip to content

Commit 81185df

Browse files
committed
Raise ValueError instead of TypeError for empty names
1 parent 5d9aa6a commit 81185df

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

Lib/test/test_import/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1262,10 +1262,9 @@ class Spec:
12621262
_imp.create_builtin(spec)
12631263

12641264
spec.name = ""
1265-
spec = Spec()
12661265

12671266
# gh-142029
1268-
with self.assertRaisesRegex(TypeError,'name must not be empty'):
1267+
with self.assertRaisesRegex(ValueError, 'name must not be empty'):
12691268
_imp.create_builtin(spec)
12701269

12711270
def test_filter_syntax_warnings_by_module(self):

Python/import.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4421,7 +4421,7 @@ _imp_create_builtin(PyObject *module, PyObject *spec)
44214421
}
44224422

44234423
if (PyUnicode_GetLength(name) == 0) {
4424-
PyErr_Format(PyExc_TypeError,
4424+
PyErr_Format(PyExc_ValueError,
44254425
"name must not be empty");
44264426
Py_DECREF(name);
44274427
return NULL;

0 commit comments

Comments
 (0)