Apply suggestions from review

- Add `base_delay` for retries
- use a for loop instead of while loop
- rename retries to max_retries

Author: emmatyping

Tools/build/generate_sbom.py

@@ -164,17 +164,16 @@ def get_externals() -> list[str]:
 
 
 def download_with_retries(download_location: str,
-                          retries: int = 5) -> typing.Any:
+                          max_retries: int = 5,
+                          base_delay: float = 2.0) -> typing.Any:
     """Download a file with exponential backoff retry."""
-    attempt = 0
-    while attempt < retries:
-        attempt += 1
+    for attempt in range(max_retries):
         try:
             resp = urllib.request.urlopen(download_location)
         except urllib.error.URLError as ex:
-            if attempt == retries:
+            if attempt == max_retries:
                 raise ex
-            time.sleep(2**attempt)
+            time.sleep(base_delay**attempt)
         else:
             return resp