Skip to content

Commit 9ccc906

Browse files
committed
Add HANDSHAKE_TIMEOUT constant
1 parent ba23731 commit 9ccc906

1 file changed

Lines changed: 16 additions & 23 deletions

File tree

Lib/test/test_asyncio/test_ssl.py

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
MACOS = (sys.platform == 'darwin')
2929
BUF_MULTIPLIER = 1024 if not MACOS else 64
30+
HANDSHAKE_TIMEOUT = support.LONG_TIMEOUT
3031

3132

3233
def tearDownModule():
@@ -257,15 +258,12 @@ def prog(sock):
257258
await fut
258259

259260
async def start_server():
260-
extras = {}
261-
extras = dict(ssl_handshake_timeout=support.LONG_TIMEOUT)
262-
263261
srv = await asyncio.start_server(
264262
handle_client,
265263
'127.0.0.1', 0,
266264
family=socket.AF_INET,
267265
ssl=sslctx,
268-
**extras)
266+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
269267

270268
try:
271269
srv_socks = srv.sockets
@@ -322,14 +320,11 @@ def server(sock):
322320
sock.close()
323321

324322
async def client(addr):
325-
extras = {}
326-
extras = dict(ssl_handshake_timeout=support.LONG_TIMEOUT)
327-
328323
reader, writer = await asyncio.open_connection(
329324
*addr,
330325
ssl=client_sslctx,
331326
server_hostname='',
332-
**extras)
327+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
333328

334329
writer.write(A_DATA)
335330
self.assertEqual(await reader.readexactly(2), b'OK')
@@ -350,7 +345,7 @@ async def client_sock(addr):
350345
sock=sock,
351346
ssl=client_sslctx,
352347
server_hostname='',
353-
ssl_handshake_timeout=support.LONG_TIMEOUT)
348+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
354349

355350
writer.write(A_DATA)
356351
self.assertEqual(await reader.readexactly(2), b'OK')
@@ -449,7 +444,7 @@ async def client(addr):
449444
*addr,
450445
ssl=client_sslctx,
451446
server_hostname='',
452-
ssl_handshake_timeout=support.LONG_TIMEOUT)
447+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
453448
writer.close()
454449
await self.wait_closed(writer)
455450

@@ -611,7 +606,7 @@ def client():
611606

612607
extras = {}
613608
if server_ssl:
614-
extras = dict(ssl_handshake_timeout=support.LONG_TIMEOUT)
609+
extras = dict(ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
615610

616611
f = loop.create_task(
617612
loop.connect_accepted_socket(
@@ -660,7 +655,8 @@ async def client(addr):
660655
reader, writer = await asyncio.open_connection(
661656
*addr,
662657
ssl=client_sslctx,
663-
server_hostname='')
658+
server_hostname='',
659+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
664660

665661
self.assertEqual(await reader.readline(), b'A\n')
666662
writer.write(b'B')
@@ -1153,14 +1149,11 @@ def do(func, *args):
11531149
await fut
11541150

11551151
async def start_server():
1156-
extras = {}
1157-
11581152
srv = await self.loop.create_server(
11591153
server_protocol_factory,
11601154
'127.0.0.1', 0,
11611155
family=socket.AF_INET,
1162-
ssl=sslctx_1,
1163-
**extras)
1156+
ssl=sslctx_1)
11641157

11651158
try:
11661159
srv_socks = srv.sockets
@@ -1210,14 +1203,11 @@ def server(sock):
12101203
sock.close()
12111204

12121205
async def client(addr):
1213-
extras = {}
1214-
extras = dict(ssl_handshake_timeout=support.LONG_TIMEOUT)
1215-
12161206
reader, writer = await asyncio.open_connection(
12171207
*addr,
12181208
ssl=client_sslctx,
12191209
server_hostname='',
1220-
**extras)
1210+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
12211211

12221212
writer.write(A_DATA)
12231213
self.assertEqual(await reader.readexactly(2), b'OK')
@@ -1287,7 +1277,8 @@ async def client(addr):
12871277
reader, writer = await asyncio.open_connection(
12881278
*addr,
12891279
ssl=client_sslctx,
1290-
server_hostname='')
1280+
server_hostname='',
1281+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
12911282
sslprotocol = writer.transport._ssl_protocol
12921283
writer.write(b'ping')
12931284
data = await reader.readexactly(4)
@@ -1399,7 +1390,8 @@ async def client(addr):
13991390
reader, writer = await asyncio.open_connection(
14001391
*addr,
14011392
ssl=client_sslctx,
1402-
server_hostname='')
1393+
server_hostname='',
1394+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
14031395
writer.write(b'ping')
14041396
data = await reader.readexactly(4)
14051397
self.assertEqual(data, b'pong')
@@ -1530,7 +1522,8 @@ async def client(addr):
15301522
reader, writer = await asyncio.open_connection(
15311523
*addr,
15321524
ssl=client_sslctx,
1533-
server_hostname='')
1525+
server_hostname='',
1526+
ssl_handshake_timeout=HANDSHAKE_TIMEOUT)
15341527
writer.write(b'ping')
15351528
data = await reader.readexactly(4)
15361529
self.assertEqual(data, b'pong')

0 commit comments

Comments
 (0)