Skip to content

Commit be1b72c

Browse files
Remove TODOs per PR feedback, remove this as required CI job
1 parent 3850ba0 commit be1b72c

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,6 @@ jobs:
354354
- name: Install dependencies
355355
run: sudo ./.github/workflows/posix-deps-apt.sh
356356
- name: Configure SSL lib env vars
357-
# TODO [childw] do we need to re-specify the env vars here after L330's configuration?
358357
run: |
359358
echo "MULTISSL_DIR=${GITHUB_WORKSPACE}/multissl" >> "$GITHUB_ENV"
360359
echo "OPENSSL_DIR=${GITHUB_WORKSPACE}/multissl/aws-lc/${AWSLC_VER}" >> "$GITHUB_ENV"
@@ -365,7 +364,6 @@ jobs:
365364
with:
366365
path: ./multissl/aws-lc/${{ matrix.awslc_ver }}
367366
key: ${{ matrix.os }}-multissl-aws-lc-${{ matrix.awslc_ver }}
368-
# TODO [childw] can we use env.* instead of env vars here?
369367
- name: Install AWS-LC
370368
if: steps.cache-aws-lc.outputs.cache-hit != 'true'
371369
run: |
@@ -697,7 +695,6 @@ jobs:
697695
- build-windows-msi
698696
- build-macos
699697
- build-ubuntu
700-
- build-ubuntu-ssltests-awslc
701698
- build-ubuntu-ssltests-openssl
702699
- build-wasi
703700
- test-hypothesis
@@ -713,7 +710,6 @@ jobs:
713710
with:
714711
allowed-failures: >-
715712
build-windows-msi,
716-
build-ubuntu-ssltests-awslc
717713
build-ubuntu-ssltests-openssl
718714
test-hypothesis,
719715
cifuzz,
@@ -732,7 +728,6 @@ jobs:
732728
check-generated-files,
733729
build-macos,
734730
build-ubuntu,
735-
build-ubuntu-ssltests-awslc,
736731
build-ubuntu-ssltests-openssl,
737732
build-wasi,
738733
test-hypothesis,

0 commit comments

Comments
 (0)