gh-136523: fix Wave_write.__del__ raise after wb open

Author: inventshah

Lib/test/support/os_helper.py

@@ -169,6 +169,26 @@ def make_bad_fd():
         unlink(TESTFN)
 
 
+@contextlib.contextmanager
+def unwritable_filepath():
+    """
+    Create a filepath that is not writable by the current user.
+    """
+    import tempfile
+    fd, path = tempfile.mkstemp()
+    original_permissions = stat.S_IMODE(os.lstat(path).st_mode)
+    os.close(fd)
+
+    try:
+        os.chmod(path, stat.S_IRUSR | stat.S_IRGRP | stat.S_IROTH)
+        yield path
+    finally:
+        try:
+            os.chmod(path, original_permissions)
+            os.remove(path)
+        except OSError as e:
+            pass
+
 _can_symlink = None
 
 

Lib/test/test_wave.py

@@ -1,6 +1,7 @@
 import unittest
 from test import audiotests
 from test import support
+from test.support.os_helper import unwritable_filepath
 import io
 import struct
 import sys
@@ -196,6 +197,21 @@ def test_read_wrong_sample_width(self):
         with self.assertRaisesRegex(wave.Error, 'bad sample width'):
             wave.open(io.BytesIO(b))
 
+    def test_write_to_protected_file(self):
+        # gh-136523: Wave_write.__del__ should not throw
+        stderr = io.StringIO()
+        sys.stderr = stderr
+        try:
+            try:
+                with unwritable_filepath() as path:
+                    with wave.open(path, "wb"):
+                        pass
+            except PermissionError:
+                pass
+            self.assertEqual(stderr.getvalue(), "")
+        finally:
+            sys.stderr = sys.__stderr__
+
 
 if __name__ == '__main__':
     unittest.main()

Lib/wave.py

@@ -429,15 +429,15 @@ class Wave_write:
 
     def __init__(self, f):
         self._i_opened_the_file = None
-        if isinstance(f, str):
-            f = builtins.open(f, 'wb')
-            self._i_opened_the_file = f
         try:
-            self.initfp(f)
+            if isinstance(f, str):
+                f = builtins.open(f, 'wb')
+                self._i_opened_the_file = f
         except:
-            if self._i_opened_the_file:
-                f.close()
+            f = None
             raise
+        finally:
+            self.initfp(f)
 
     def initfp(self, file):
         self._file = file