The implementation for suggestions in "ModuleNotFoundError"

[Locked-chess-official]

Feature or enhancement

Previous discussion here. This issue for the implemention of the idea.

Before all, I find a better way to get the list of the module:

import os
import sys
from importlib import machinery

def scan_dir(path):
    """
    Return all of the packages in the path without import
    contains：
      - .py file
      - directory with "__init__.py"
      - the .pyd/so file that has right ABI
    """
    if not os.path.isdir(path):
        return []

    suffixes = machinery.EXTENSION_SUFFIXES
    result = []

    for name in os.listdir(path):
        full_path = os.path.join(path, name)

        # .py file
        if name.endswith(".py") and os.path.isfile(full_path):
            modname = name[:-3]
            if modname.isidentifier():
                result.append(modname)

        # directory with "__init__.py"
        elif os.path.isdir(full_path):
            init_file = os.path.join(full_path, "__init__.py")
            if os.path.isfile(init_file) and name.isidentifier():
                result.append(name)

        # the .pyd/so file that has right ABI
        elif os.path.isfile(full_path):
            for suf in suffixes:
                if name.endswith(suf):
                    modname = name[:-len(suf)]
                    if modname.isidentifier():
                        result.append(modname)
                    break

    return sorted(result)

def find_all_packages():
    return sorted(sum([scan_dir(i) if i and
                isinstance(i, str) and not
                i.endswith("idlelib") else []
                for i in sys.path ], []) + 
                list(sys.builtin_module_names))

# example
if __name__ == "__main__":
    print(find_all_packages())

The new test for test here:

No.	number of entries	used time(/s)	average time(/s)	result
1	5	0.064	0.013	success
2	5	0.072	0.014	success
3	5	0.052	0.010	success
4	5	0.056	0.011	success
5	5	0.057	0.011	success
6	6	0.081	0.014	success
7	6	0.062	0.010	success
8	6	0.091	0.015	success
9	6	0.064	0.011	success
10	6	0.064	0.011	success

The speed test here:

tool	function	arg	number	average time(/ms)
timeit	find_all_packages	(no args)	1000	8.567
timeit	scan_dir	path/to/site-packages	1000	4.845

And the script behaves better in finding ".pyd" modules.

Linked PRs

• gh-137671 suggest name for "ModuleNotFoundError" #137678

[StanFromIreland]

CC @ambv (from your Discourse messages)

[terryjreedy]

title edited. Exception hints are not, and generally should not, be limit to the default REPL. For instance,

F:\dev\3x>python -c "a = ing"
Running Debug|x64 interpreter...
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    a = ing
        ^^^
NameError: name 'ing' is not defined. Did you mean: 'int'?

Same if run in IDLE from file or in its shell.

[AA-Turner]

It's unclear what this issue actually proposes doing?

[picnixz]

And this issue should have linked the two now closed issues and the existing Dpo thread where I highlighted the issues of this approach.

[AA-Turner]

@Locked-chess-official please don't open duplicate issues, especially if a core developer has highlighted problems on the Discourse topic.

A

[Locked-chess-official]

@Locked-chess-official please don't open duplicate issues, especially if a core developer has highlighted problems on the Discourse topic.

No. The things that what @picnixz 's reason to close those two issues is not problem are there in the discussion and here in the data. Before the data I had even been mislead by the reason to write C extends

[terryjreedy]

I oppose doing anything more that suggesting names from the stdlib, which are available in sys. We should not be officially involved with 3rd party modules and indefinite searches and side-effects.

[Locked-chess-official]

I oppose doing anything more that suggesting names from the stdlib, which are available in sys. We should not be officially involved with 3rd party modules and indefinite searches and side-effects.

In fact, the indefinite searches is not exist in the PR: only "for" cricle. And @picnixz said that he didn't want to make the half-feature that without site-packages.