Fix NO_COLOR on TUI detail screens and add ROBOREV_COLOR_MODE env var (#566)

## Summary

- Fix `NO_COLOR=1` not working on TUI review/prompt detail screens
(glamour was ignoring it)
- Add `ROBOREV_COLOR_MODE` env var (`auto`|`dark`|`light`|`none`) for
explicit TUI color theme control
- Apply color mode to both glamour (markdown) and lipgloss
(AdaptiveColor) layers
- `NO_COLOR` takes precedence over `ROBOREV_COLOR_MODE` at all layers

## Problem

glamour's `NewTermRenderer` defaults to `TrueColor` profile regardless
of `NO_COLOR`. The main queue screen (lipgloss only) correctly respected
`NO_COLOR`, but review/prompt detail screens (glamour-rendered markdown)
always emitted ANSI color sequences.

Additionally, there was no way to force a dark/light theme when terminal
background auto-detection failed.

## Changes

### Core fix
- Pass `glamour.WithColorProfile()` to all `glamour.NewTermRenderer`
calls in both `cmd/roborev/tui/helpers.go` and
`internal/streamfmt/render.go`
- Fix `stripTrailingPadding`/`StripTrailingPadding` to skip the
`\x1b[0m` reset suffix in no-color mode

### ROBOREV_COLOR_MODE env var
- `auto` (default): auto-detect terminal background
- `dark`: force dark color palette
- `light`: force light color palette  
- `none`: strip all colors (same as `NO_COLOR=1`)

### Lipgloss integration
- Call `lipgloss.SetHasDarkBackground()` / `lipgloss.SetColorProfile()`
in TUI startup so `AdaptiveColor` styles on the queue screen also
respect the env var
- Check `NO_COLOR` first to ensure it always takes precedence

### Consolidation
- Remove duplicate `resolveColorMode()` from TUI helpers; delegate to
`streamfmt.GlamourStyle()` + `streamfmt.ResolveColorProfile()`
- Update `GlamourStyle()` to check `NO_COLOR` (previously skipped,
causing unnecessary terminal background queries)

### Documentation
- Add `ROBOREV_COLOR_MODE` and `NO_COLOR` to README.md, AGENTS.md, and
CLAUDE.md

## Testing

- All existing tests pass (`go test ./...`)
- New tests: `TestResolveColorProfile`,
`TestRenderMarkdownLinesNoColor`, `TestGlamourStyleRespectsColorMode`
with proper dark/light style differentiation
- Manual testing confirmed: `NO_COLOR=1`, `ROBOREV_COLOR_MODE=none`,
`=dark`, `=light` all work on both queue and detail screens

---------

Co-authored-by: Sergey Trofimovsky <sergey.trofimovsky@trulioo.com>
Co-authored-by: Wes McKinney <wesmckinn+git@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 4 people

AGENTS.md

@@ -128,6 +128,7 @@ CLI (roborev) -> HTTP API -> Daemon -> Worker Pool -> Agent adapters
 - Runtime info: `~/.roborev/daemon.json`
 - SQLite DB: `~/.roborev/reviews.db` using WAL mode
 - Data dir override: `ROBOREV_DATA_DIR`
+- Color mode: `ROBOREV_COLOR_MODE` env var (`auto`, `dark`, `light`, `none`); `NO_COLOR=1` also supported
 - Global config: `~/.roborev/config.toml`
 - Repo config: `.roborev.toml` at repo root
 - Config precedence is generally: CLI flags -> repo config -> global config -> defaults

CLAUDE.md

@@ -35,6 +35,7 @@ CLI (roborev) → HTTP API → Daemon (roborev daemon run) → Worker Pool → A
 - **Storage**: SQLite at `~/.roborev/reviews.db` with WAL mode
 - **Config**: Global at `~/.roborev/config.toml`, per-repo at `.roborev.toml`
 - **Data dir**: Set `ROBOREV_DATA_DIR` env var to override `~/.roborev`
+- **Color mode**: `ROBOREV_COLOR_MODE=auto|dark|light|none` controls TUI color theme; `NO_COLOR=1` strips all colors
 - **Runtime info**: Daemon writes PID/addr/port to `~/.roborev/daemon.json`
 
 ## Package Map

README.md

@@ -162,6 +162,14 @@ Project-specific review instructions here.
 
 See [configuration guide](https://roborev.io/configuration/) for all options.
 
+### Environment Variables
+
+| Variable | Description |
+|----------|-------------|
+| `ROBOREV_DATA_DIR` | Override default data directory (`~/.roborev`) |
+| `ROBOREV_COLOR_MODE` | TUI color theme: `auto` (default), `dark`, `light`, `none` |
+| `NO_COLOR` | Set to any value to disable all color output ([no-color.org](https://no-color.org)) |
+
 ## Supported Agents
 
 | Agent | Install |

cmd/roborev/tui/helpers.go

@@ -8,11 +8,11 @@ import (
 	tea "github.com/charmbracelet/bubbletea"
 	"github.com/charmbracelet/glamour"
 	gansi "github.com/charmbracelet/glamour/ansi"
-	"github.com/charmbracelet/glamour/styles"
 	xansi "github.com/charmbracelet/x/ansi"
 	"github.com/mattn/go-runewidth"
 	"github.com/muesli/termenv"
 	"github.com/roborev-dev/roborev/internal/storage"
+	"github.com/roborev-dev/roborev/internal/streamfmt"
 )
 
 // Filter type constants used in filterStack and popFilter/pushFilter.
@@ -299,6 +299,7 @@ func wrapLine(line string, width int) []string {
 // which blocks for seconds inside bubbletea's raw-mode input loop.
 type markdownCache struct {
 	glamourStyle gansi.StyleConfig // custom style derived from dark/light, detected once at init
+	colorProfile termenv.Profile   // color profile for glamour rendering (Ascii when NO_COLOR)
 	tabWidth     int               // tab expansion width (default 2)
 
 	reviewLines []string
@@ -320,26 +321,17 @@ type markdownCache struct {
 
 // newMarkdownCache creates a markdownCache, detecting terminal background
 // color now (before bubbletea enters raw mode and takes over stdin).
-// Builds a custom style with zero margins to avoid extra padding.
+// Delegates style and color profile resolution to the streamfmt package,
+// which respects ROBOREV_COLOR_MODE env var and NO_COLOR convention.
 func newMarkdownCache(tabWidth int) *markdownCache {
-	style := styles.LightStyleConfig
-	if termenv.HasDarkBackground() {
-		style = styles.DarkStyleConfig
-	}
-	// Remove document and code block margins that add extra indentation.
-	zeroMargin := uint(0)
-	style.Document.Margin = &zeroMargin
-	style.CodeBlock.Margin = &zeroMargin
-	// Remove inline code prefix/suffix spaces (rendered as visible
-	// colored blocks around `backtick` content).
-	style.Code.Prefix = ""
-	style.Code.Suffix = ""
+	style := streamfmt.GlamourStyle()
+	profile := streamfmt.ResolveColorProfile()
 	if tabWidth <= 0 {
 		tabWidth = 2
 	} else if tabWidth > 16 {
 		tabWidth = 16
 	}
-	return &markdownCache{glamourStyle: style, tabWidth: tabWidth}
+	return &markdownCache{glamourStyle: style, colorProfile: profile, tabWidth: tabWidth}
 }
 
 // truncateLongLines normalizes tabs and truncates lines inside fenced code
@@ -479,24 +471,35 @@ func sanitizeLines(lines []string) []string {
 // the wrap width. Stripping this padding prevents overflow on narrow terminals.
 var trailingPadRe = regexp.MustCompile(`(\s|\x1b\[[0-9;]*m)+$`)
 
+// allSGRRe matches any ANSI SGR escape sequence.
+var allSGRRe = regexp.MustCompile(`\x1b\[[0-9;]*m`)
+
 // stripTrailingPadding removes trailing whitespace and ANSI SGR codes from a
 // glamour output line, then appends a reset to ensure clean color state.
-func stripTrailingPadding(line string) string {
-	return trailingPadRe.ReplaceAllString(line, "") + "\x1b[0m"
+// When noColor is true, all SGR sequences are stripped to prevent open
+// attributes (bold, underline) from bleeding across lines.
+func stripTrailingPadding(line string, noColor bool) string {
+	line = trailingPadRe.ReplaceAllString(line, "")
+	if noColor {
+		return allSGRRe.ReplaceAllString(line, "")
+	}
+	return line + "\x1b[0m"
 }
 
 // renderMarkdownLines renders markdown text using glamour and splits into lines.
 // wrapWidth controls glamour's word-wrap column (capped for readability).
 // maxWidth controls line truncation (actual terminal width).
+// colorProfile controls glamour's color output (use termenv.Ascii to suppress colors).
 // Falls back to wrapText if glamour rendering fails.
-func renderMarkdownLines(text string, wrapWidth, maxWidth int, glamourStyle gansi.StyleConfig, tabWidth int) []string {
+func renderMarkdownLines(text string, wrapWidth, maxWidth int, glamourStyle gansi.StyleConfig, tabWidth int, colorProfile termenv.Profile) []string {
 	// Truncate long lines before glamour so they don't get word-wrapped.
 	// Use maxWidth (terminal width) so content fills the available space.
 	text = truncateLongLines(text, maxWidth, tabWidth)
 	r, err := glamour.NewTermRenderer(
 		glamour.WithStyles(glamourStyle),
 		glamour.WithWordWrap(wrapWidth),
 		glamour.WithPreservedNewLines(),
+		glamour.WithColorProfile(colorProfile),
 	)
 	if err != nil {
 		return sanitizeLines(wrapText(text, wrapWidth))
@@ -505,9 +508,10 @@ func renderMarkdownLines(text string, wrapWidth, maxWidth int, glamourStyle gans
 	if err != nil {
 		return sanitizeLines(wrapText(text, wrapWidth))
 	}
+	noColor := colorProfile == termenv.Ascii
 	lines := strings.Split(strings.TrimRight(out, "\n"), "\n")
 	for i, line := range lines {
-		line = stripTrailingPadding(line)
+		line = stripTrailingPadding(line, noColor)
 		line = sanitizeEscapes(line)
 		// Truncate output lines that still exceed maxWidth (glamour can add
 		// indentation for block quotes, lists, etc. beyond the wrap width).
@@ -526,7 +530,7 @@ func (c *markdownCache) getReviewLines(text string, wrapWidth, maxWidth int, rev
 	if c.reviewID == reviewID && c.reviewWidth == maxWidth && c.reviewText == text {
 		return c.reviewLines
 	}
-	c.reviewLines = renderMarkdownLines(text, wrapWidth, maxWidth, c.glamourStyle, c.tabWidth)
+	c.reviewLines = renderMarkdownLines(text, wrapWidth, maxWidth, c.glamourStyle, c.tabWidth, c.colorProfile)
 	c.reviewID = reviewID
 	c.reviewWidth = maxWidth
 	c.reviewText = text
@@ -540,7 +544,7 @@ func (c *markdownCache) getPromptLines(text string, wrapWidth, maxWidth int, rev
 	if c.promptID == reviewID && c.promptWidth == maxWidth && c.promptText == text {
 		return c.promptLines
 	}
-	c.promptLines = renderMarkdownLines(text, wrapWidth, maxWidth, c.glamourStyle, c.tabWidth)
+	c.promptLines = renderMarkdownLines(text, wrapWidth, maxWidth, c.glamourStyle, c.tabWidth, c.colorProfile)
 	c.promptID = reviewID
 	c.promptWidth = maxWidth
 	c.promptText = text

cmd/roborev/tui/helpers_test.go

@@ -10,6 +10,7 @@ import (
 	tea "github.com/charmbracelet/bubbletea"
 	"github.com/charmbracelet/glamour/styles"
 	"github.com/mattn/go-runewidth"
+	"github.com/muesli/termenv"
 	"github.com/roborev-dev/roborev/internal/storage"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -23,7 +24,7 @@ func stripTestANSI(s string) string {
 
 func TestRenderMarkdownLinesPreservesNewlines(t *testing.T) {
 	// Verify that single newlines in plain text are preserved (not collapsed into one paragraph)
-	lines := renderMarkdownLines("Line 1\nLine 2\nLine 3", 80, 80, styles.DarkStyleConfig, 2)
+	lines := renderMarkdownLines("Line 1\nLine 2\nLine 3", 80, 80, styles.DarkStyleConfig, 2, termenv.TrueColor)
 
 	found := 0
 	for _, line := range lines {
@@ -36,7 +37,7 @@ func TestRenderMarkdownLinesPreservesNewlines(t *testing.T) {
 }
 
 func TestRenderMarkdownLinesFallsBackOnEmpty(t *testing.T) {
-	lines := renderMarkdownLines("", 80, 80, styles.DarkStyleConfig, 2)
+	lines := renderMarkdownLines("", 80, 80, styles.DarkStyleConfig, 2, termenv.TrueColor)
 	// Should not panic and should produce some output (even if empty)
 	assert.NotNil(t, lines)
 }
@@ -304,7 +305,7 @@ func TestRenderMarkdownLinesPreservesLongProse(t *testing.T) {
 	// Long prose lines should be word-wrapped by glamour, not truncated.
 	// All words must appear in the rendered output.
 	longProse := "This is a very long prose line with important content that should be word-wrapped by glamour rather than truncated so that no information is lost from the rendered output"
-	lines := renderMarkdownLines(longProse, 60, 80, styles.DarkStyleConfig, 2)
+	lines := renderMarkdownLines(longProse, 60, 80, styles.DarkStyleConfig, 2, termenv.TrueColor)
 
 	var combined strings.Builder
 	for _, line := range lines {
@@ -423,7 +424,7 @@ func TestRenderMarkdownLinesNoOverflow(t *testing.T) {
 	longLine := strings.Repeat("x", 200)
 	text := "Review:\n\n```\n" + longLine + "\n```\n"
 	width := 76
-	lines := renderMarkdownLines(text, width, width, styles.DarkStyleConfig, 2)
+	lines := renderMarkdownLines(text, width, width, styles.DarkStyleConfig, 2, termenv.TrueColor)
 
 	for i, line := range lines {
 		stripped := stripTestANSI(line)
@@ -433,6 +434,19 @@ func TestRenderMarkdownLinesNoOverflow(t *testing.T) {
 	}
 }
 
+func TestRenderMarkdownLinesNoColor(t *testing.T) {
+	// When colorProfile is Ascii, stripTrailingPadding removes all SGR
+	// sequences (colors, bold, underline, reset) so no formatting can
+	// bleed across lines.
+	text := "# Heading\n\nSome **bold** text and `code`."
+	lines := renderMarkdownLines(text, 80, 80, styles.DarkStyleConfig, 2, termenv.Ascii)
+
+	combined := strings.Join(lines, "\n")
+	allSGR := regexp.MustCompile(`\x1b\[[0-9;]*m`)
+	matches := allSGR.FindAllString(combined, -1)
+	assert.Empty(t, matches, "expected no SGR sequences with Ascii profile, got: %v", matches)
+}
+
 func TestReflowHelpRows(t *testing.T) {
 
 	tests := []struct {
@@ -912,3 +926,66 @@ func TestWrapLine(t *testing.T) {
 		})
 	}
 }
+
+func TestStripTrailingPadding(t *testing.T) {
+	bold := "\x1b[1m"
+	underline := "\x1b[4m"
+	reset := "\x1b[0m"
+	red := "\x1b[31m"
+
+	tests := []struct {
+		name    string
+		line    string
+		noColor bool
+		want    string
+	}{
+		{
+			name:    "color mode appends reset",
+			line:    red + "hello" + reset,
+			noColor: false,
+			want:    red + "hello" + reset,
+		},
+		{
+			name:    "color mode strips trailing padding",
+			line:    red + "hello" + reset + "   " + reset,
+			noColor: false,
+			want:    red + "hello" + reset,
+		},
+		{
+			name:    "noColor strips mid-line bold",
+			line:    bold + "hello" + reset,
+			noColor: true,
+			want:    "hello",
+		},
+		{
+			name:    "noColor strips mid-line underline",
+			line:    underline + "text" + reset,
+			noColor: true,
+			want:    "text",
+		},
+		{
+			name:    "noColor strips mixed SGR sequences",
+			line:    bold + underline + "mixed" + reset + " plain",
+			noColor: true,
+			want:    "mixed plain",
+		},
+		{
+			name:    "noColor preserves plain text",
+			line:    "no formatting here",
+			noColor: true,
+			want:    "no formatting here",
+		},
+		{
+			name:    "noColor strips trailing padding and all SGR",
+			line:    bold + "word" + reset + "   ",
+			noColor: true,
+			want:    "word",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := stripTrailingPadding(tt.line, tt.noColor)
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}

cmd/roborev/tui/tui.go

@@ -18,6 +18,7 @@ import (
 	"github.com/charmbracelet/lipgloss"
 	"github.com/charmbracelet/lipgloss/table"
 	"github.com/mattn/go-runewidth"
+	"github.com/muesli/termenv"
 	"github.com/roborev-dev/roborev/internal/config"
 	"github.com/roborev-dev/roborev/internal/daemon"
 	"github.com/roborev-dev/roborev/internal/git"
@@ -527,6 +528,23 @@ func newModel(ep daemon.DaemonEndpoint, opts ...option) model {
 		filterStack = append(filterStack, filterTypeBranch)
 	}
 
+	// Apply ROBOREV_COLOR_MODE to the lipgloss default renderer so that
+	// AdaptiveColor styles on the queue screen respect the env var.
+	// NO_COLOR takes precedence per the convention.
+	// The glamour/markdown layer is handled separately via streamfmt.
+	if termenv.EnvNoColor() {
+		lipgloss.SetColorProfile(termenv.Ascii)
+	} else {
+		switch strings.ToLower(os.Getenv("ROBOREV_COLOR_MODE")) {
+		case "dark":
+			lipgloss.SetHasDarkBackground(true)
+		case "light":
+			lipgloss.SetHasDarkBackground(false)
+		case "none":
+			lipgloss.SetColorProfile(termenv.Ascii)
+		}
+	}
+
 	return model{
 		endpoint:            ep,
 		daemonVersion:       daemonVersion,

internal/streamfmt/render.go

@@ -8,6 +8,7 @@ import (
 	gansi "github.com/charmbracelet/glamour/ansi"
 	xansi "github.com/charmbracelet/x/ansi"
 	"github.com/mattn/go-runewidth"
+	"github.com/muesli/termenv"
 )
 
 // ansiEscapePattern matches ANSI escape sequences (colors, cursor
@@ -86,11 +87,20 @@ func SanitizeLines(lines []string) []string {
 // terminals.
 var trailingPadRe = regexp.MustCompile(`(\s|\x1b\[[0-9;]*m)+$`)
 
+// allSGRRe matches any ANSI SGR escape sequence.
+var allSGRRe = regexp.MustCompile(`\x1b\[[0-9;]*m`)
+
 // StripTrailingPadding removes trailing whitespace and ANSI SGR codes
 // from a glamour output line, then appends a reset to ensure clean
-// color state.
-func StripTrailingPadding(line string) string {
-	return trailingPadRe.ReplaceAllString(line, "") + "\x1b[0m"
+// color state. When noColor is true, all SGR sequences are stripped
+// to prevent open attributes (bold, underline) from bleeding across
+// lines.
+func StripTrailingPadding(line string, noColor bool) string {
+	line = trailingPadRe.ReplaceAllString(line, "")
+	if noColor {
+		return allSGRRe.ReplaceAllString(line, "")
+	}
+	return line + "\x1b[0m"
 }
 
 // WrapText wraps text to the specified width, preserving existing
@@ -233,17 +243,20 @@ func ParseFence(line string) (byte, int, bool) {
 
 // RenderMarkdownLines renders markdown text using glamour and splits
 // into lines. wrapWidth controls glamour's word-wrap column.
-// maxWidth controls line truncation (actual terminal width). Falls
-// back to WrapText if glamour rendering fails.
+// maxWidth controls line truncation (actual terminal width).
+// colorProfile controls glamour's color output (use termenv.Ascii to suppress colors).
+// Falls back to WrapText if glamour rendering fails.
 func RenderMarkdownLines(
 	text string, wrapWidth, maxWidth int,
 	glamourStyle gansi.StyleConfig, tabWidth int,
+	colorProfile termenv.Profile,
 ) []string {
 	text = TruncateLongLines(text, maxWidth, tabWidth)
 	r, err := glamour.NewTermRenderer(
 		glamour.WithStyles(glamourStyle),
 		glamour.WithWordWrap(wrapWidth),
 		glamour.WithPreservedNewLines(),
+		glamour.WithColorProfile(colorProfile),
 	)
 	if err != nil {
 		return SanitizeLines(WrapText(text, wrapWidth))
@@ -252,9 +265,10 @@ func RenderMarkdownLines(
 	if err != nil {
 		return SanitizeLines(WrapText(text, wrapWidth))
 	}
+	noColor := colorProfile == termenv.Ascii
 	lines := strings.Split(strings.TrimRight(out, "\n"), "\n")
 	for i, line := range lines {
-		line = StripTrailingPadding(line)
+		line = StripTrailingPadding(line, noColor)
 		line = SanitizeEscapes(line)
 		if xansi.StringWidth(line) > maxWidth {
 			line = xansi.Truncate(line, maxWidth, "")