Address PR review feedback: fix bin/ci, puma, ActionCable, and config defaults

justin808 · claude · justin808 · commit 182bb69c56b7 · 2026-03-24T21:00:32.000-10:00
- Rewrite bin/ci to use plain Ruby (TutorialCI module) instead of
  non-existent ActiveSupport::ContinuousIntegration DSL
- Add test asset build step to CI pipeline
- Use bin/conductor-exec wrapper for all CI commands
- Restore worker_timeout 3600 for development in puma.rb
- Restore default thread count to 5 in puma.rb
- Comment out solid_queue plugin (gem not in Gemfile)
- Make PRODUCTION_HOST optional with conditional guard
- Make deprecation reporting configurable via RAILS_REPORT_DEPRECATIONS env var
- Restore conditional cache store toggle in development.rb
- Preserve to_time_preserves_timezone = false in application.rb
- Use action_cable_meta_tag for client-side WebSocket URL construction
- Add actionCableUrl.js helper to read cable URL from meta tag

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -25,6 +25,7 @@
   <%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>
 
   <%= csrf_meta_tags %>
+  <%= action_cable_meta_tag %>
 </head>
 <body class="min-h-screen flex flex-col bg-sky-50 text-gray-700">
   <%= yield :body_content %>
diff --git a/bin/ci b/bin/ci
@@ -1,6 +1,21 @@
 #!/usr/bin/env ruby
-require_relative "../config/boot"
-require "active_support/continuous_integration"
+# frozen_string_literal: true
 
-CI = ActiveSupport::ContinuousIntegration
-require_relative "../config/ci.rb"
+require "English"
+require_relative "../config/ci"
+
+def run_step(name, command)
+  puts "\n== #{name} =="
+  puts "$ #{command}"
+  system(command)
+  return if $CHILD_STATUS.success?
+
+  warn "\nStep failed: #{name}"
+  exit($CHILD_STATUS.exitstatus || 1)
+end
+
+TutorialCI::STEPS.each do |name, command|
+  run_step(name, command)
+end
+
+puts "\nAll CI steps passed."
diff --git a/client/app/bundles/comments/components/CommentBox/CommentBox.jsx b/client/app/bundles/comments/components/CommentBox/CommentBox.jsx
@@ -2,8 +2,10 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import Immutable from 'immutable';
 import _ from 'lodash';
+import * as ActionCable from '@rails/actioncable';
 import { injectIntl } from 'react-intl';
 import BaseComponent from 'libs/components/BaseComponent';
+import actionCableUrl from 'libs/actionCableUrl';
 import SelectLanguage from 'libs/i18n/selectLanguage';
 import { defaultMessages, defaultLocale } from 'libs/i18n/default';
 import CommentForm from './CommentForm/CommentForm';
@@ -34,11 +36,7 @@ class CommentBox extends BaseComponent {
 
   subscribeChannel() {
     const { messageReceived } = this.props.actions;
-    const protocol = window.location.protocol === 'https:' ? 'wss://' : 'ws://';
-    const cableUrl = `${protocol}${window.location.hostname}:${window.location.port}/cable`;
-    // ActionCable is a global added through webpack.providePlugin
-    // eslint-disable-next-line no-undef
-    this.cable = ActionCable.createConsumer(cableUrl);
+    this.cable = ActionCable.createConsumer(actionCableUrl());
 
     /* eslint no-console: ["error", { allow: ["log"] }] */
     this.cable.subscriptions.create(
diff --git a/client/app/controllers/comments_controller.js b/client/app/controllers/comments_controller.js
@@ -3,6 +3,7 @@ import * as ActionCable from '@rails/actioncable';
 import * as marked from 'marked';
 import { gfmHeadingId } from 'marked-gfm-heading-id';
 import { mangle } from 'marked-mangle';
+import actionCableUrl from 'libs/actionCableUrl';
 
 marked.use(gfmHeadingId());
 marked.use(mangle());
@@ -47,10 +48,7 @@ export default class CommentsController extends Controller {
   connect() {
     console.log('connected to Stimulus comments_controller');
 
-    const protocol = window.location.protocol === 'https:' ? 'wss://' : 'ws://';
-    const cableUrl = `${protocol}${window.location.hostname}:${window.location.port}/cable`;
-
-    this.cable = ActionCable.createConsumer(cableUrl);
+    this.cable = ActionCable.createConsumer(actionCableUrl());
 
     this.cable.subscriptions.create('CommentsChannel', {
       connected: () => {
diff --git a/client/app/libs/actionCableUrl.js b/client/app/libs/actionCableUrl.js
@@ -0,0 +1,4 @@
+export default function actionCableUrl() {
+  const cableMetaTag = document.querySelector("meta[name='action-cable-url']");
+  return cableMetaTag ? cableMetaTag.getAttribute('content') : undefined;
+}
diff --git a/config/application.rb b/config/application.rb
@@ -13,6 +13,9 @@ class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.
     config.load_defaults 8.1
 
+    # Preserve historical app behavior for Time#to_time conversions.
+    config.active_support.to_time_preserves_timezone = false
+
     # Please, add to the `ignore` list any other `lib` subdirectories that do
     # not contain `.rb` files, or that should not be reloaded or eager loaded.
     # Common ones are `templates`, `generators`, or `middleware`, for example.
diff --git a/config/ci.rb b/config/ci.rb
@@ -1,24 +1,17 @@
 # frozen_string_literal: true
 
-# Run using bin/ci
-
-CI.run do
-  step "Setup", "bin/setup --skip-server"
-
-  step "Style: Ruby", "bin/rubocop"
-  step "Style: JavaScript", "yarn lint:eslint"
-
-  step "Tests: RSpec", "bin/rspec"
-  step "Tests: Jest", "yarn test:client"
-
-  # Optional: Run system tests
-  # step "Tests: System", "bin/rails test:system"
-
-  # Optional: set a green GitHub commit status to unblock PR merge.
-  # Requires the `gh` CLI and `gh extension install basecamp/gh-signoff`.
-  # if success?
-  #   step "Signoff: All systems go. Ready for merge and deploy.", "gh signoff"
-  # else
-  #   failure "Signoff: CI failed. Do not merge or deploy.", "Fix the issues and try again."
-  # end
+module TutorialCI
+  STEPS = [
+    ["Setup", "bin/conductor-exec bin/setup --skip-server"],
+    ["Style: Ruby", "bin/conductor-exec bin/rubocop"],
+    ["Style: JavaScript", "bin/conductor-exec yarn lint:eslint"],
+    [
+      "Build: Test assets",
+      "RAILS_ENV=test bin/conductor-exec bin/rails react_on_rails:generate_packs && " \
+      "bin/conductor-exec yarn res:build && " \
+      "bin/conductor-exec yarn build:test",
+    ],
+    ["Tests: RSpec", "bin/conductor-exec bin/rspec"],
+    ["Tests: Jest", "bin/conductor-exec yarn test:client"],
+  ].freeze
 end
diff --git a/config/environments/development.rb b/config/environments/development.rb
@@ -23,13 +23,12 @@
     config.action_controller.perform_caching = true
     config.action_controller.enable_fragment_cache_logging = true
     config.public_file_server.headers = { "cache-control" => "public, max-age=#{2.days.to_i}" }
+    config.cache_store = :memory_store
   else
     config.action_controller.perform_caching = false
+    config.cache_store = :null_store
   end
 
-  # Change to :null_store to avoid any caching.
-  config.cache_store = :memory_store
-
   # Store uploaded files on the local file system (see config/storage.yml for options).
   config.active_storage.service = :local
 
diff --git a/config/environments/production.rb b/config/environments/production.rb
@@ -48,8 +48,8 @@
   # Prevent health checks from clogging up the logs.
   config.silence_healthcheck_path = "/up"
 
-  # Don't log any deprecations.
-  config.active_support.report_deprecations = false
+  # Keep deprecations visible by default so upgrades don't hide breaking changes.
+  config.active_support.report_deprecations = ENV["RAILS_REPORT_DEPRECATIONS"] != "false"
 
   # Replace the default in-process memory cache store with a durable alternative.
   # config.cache_store = :mem_cache_store
@@ -93,6 +93,9 @@
   # config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
 
   # Action Cable endpoint configuration
-  config.action_cable.url = "wss://#{ENV.fetch('PRODUCTION_HOST')}/cable"
-  config.action_cable.allowed_request_origins = ["https://#{ENV.fetch('PRODUCTION_HOST')}"]
+  production_host = ENV["PRODUCTION_HOST"]
+  if production_host.present?
+    config.action_cable.url = "wss://#{production_host}/cable"
+    config.action_cable.allowed_request_origins = ["https://#{production_host}"]
+  end
 end
diff --git a/config/puma.rb b/config/puma.rb
@@ -21,23 +21,25 @@
 # Global VM Lock (GVL) it has diminishing returns and will degrade the
 # response time (latency) of the application.
 #
-# The default is set to 3 threads as it's deemed a decent compromise between
-# throughput and latency for the average Rails application.
+# The default is 5 threads in the Rails template.
 #
 # Any libraries that use a connection pool or another resource pool should
 # be configured to provide at least as many connections as the number of
 # threads. This includes Active Record's `pool` parameter in `database.yml`.
-threads_count = ENV.fetch("RAILS_MAX_THREADS", 3)
+threads_count = ENV.fetch("RAILS_MAX_THREADS", 5)
 threads threads_count, threads_count
 
+# Allow long-running requests in development (e.g. debugger breakpoints).
+worker_timeout 3600 if ENV.fetch("RAILS_ENV", "development") == "development"
+
 # Specifies the `port` that Puma will listen on to receive requests; default is 3000.
 port ENV.fetch("PORT", 3000)
 
 # Allow puma to be restarted by `bin/rails restart` command.
 plugin :tmp_restart
 
 # Run the Solid Queue supervisor inside of Puma for single-server deployments.
-plugin :solid_queue if ENV["SOLID_QUEUE_IN_PUMA"]
+# plugin :solid_queue if ENV["SOLID_QUEUE_IN_PUMA"]
 
 # Specify the PID file. Defaults to tmp/pids/server.pid in development.
 # In other environments, only set the PID file if requested.
