Skip to content

Commit 584921b

Browse files
ihabadhamclaude
andcommitted
Fix env var name mismatch: NODE_RENDERER_CONCURRENCY → RENDERER_WORKERS_COUNT
The launcher was reading NODE_RENDERER_CONCURRENCY (inherited from PR #723's f55dcc2), but app.yml sets RENDERER_WORKERS_COUNT (canonical per marketplace + Pro renderer library). Result: prod/staging would ignore the deployed value and always use the launcher default. RENDERER_WORKERS_COUNT is the canonical env var name per: - docs/oss/building-features/node-renderer/js-configuration.md "workersCount (default: process.env.RENDERER_WORKERS_COUNT ...)" - packages/react-on-rails-pro-node-renderer/src/shared/configBuilder.ts:200 "workersCount: env.RENDERER_WORKERS_COUNT ? parseInt(...) : defaultWorkersCount()" - react-server-components-marketplace-demo/node-renderer.js NODE_RENDERER_CONCURRENCY was a non-canonical name invented by PR #723. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0f2bcd4 commit 584921b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

renderer/node-renderer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const config = {
3333
password: rendererPassword,
3434
port: parseIntegerEnv('RENDERER_PORT', 3800, { min: 1, max: 65535 }),
3535
supportModules: true,
36-
workersCount: parseIntegerEnv('NODE_RENDERER_CONCURRENCY', 3, { min: 0 }),
36+
workersCount: parseIntegerEnv('RENDERER_WORKERS_COUNT', 3, { min: 0 }),
3737
// Expose globals the VM sandbox doesn't auto-provide but that downstream
3838
// deps rely on during SSR. Without URL, react-router-dom's NavLink throws
3939
// `ReferenceError: URL is not defined` via encodeLocation.
@@ -42,7 +42,7 @@ const config = {
4242

4343
// CI hosts report more CPUs than allocated to the container; cap workers to
4444
// avoid oversubscribing memory.
45-
if (process.env.CI && process.env.NODE_RENDERER_CONCURRENCY == null) {
45+
if (process.env.CI && process.env.RENDERER_WORKERS_COUNT == null) {
4646
config.workersCount = 2;
4747
}
4848

0 commit comments

Comments
 (0)