Skip to content

Commit 92e89e0

Browse files
committed
Fix final homepage review issues
1 parent faa8363 commit 92e89e0

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

app/views/pages/_header.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<p class="mt-2 text-sm leading-6 text-slate-600">The library behind this project’s review-app workflow.</p>
2727
<% end %>
2828

29-
<%= link_to "#review-app-commands",
29+
<%= link_to root_path(anchor: "review-app-commands"),
3030
class: "rounded-3xl border border-slate-200 bg-slate-50/80 p-5 transition hover:-translate-y-0.5 hover:border-sky-300 hover:bg-white hover:no-underline hover:shadow-lg hover:shadow-sky-100" do %>
3131
<p class="text-sm font-semibold uppercase tracking-[0.22em] text-sky-700">Review Apps</p>
3232
<p class="mt-3 text-xl font-semibold text-slate-900">Quick PR Commands</p>

client/app/bundles/comments/components/NavigationBar/NavigationBar.jsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ function NavigationBar(props) {
2222

2323
const [isOpen, setIsOpen] = useState(false);
2424

25-
const menuWrapperClasses =
26-
'flex flex-col gap-1 pb-4 lg:visible lg:flex-row lg:flex-wrap lg:items-center lg:pb-0';
25+
const menuWrapperClasses = 'flex-col gap-1 pb-4 lg:flex lg:flex-row lg:flex-wrap lg:items-center lg:pb-0';
2726

2827
return (
2928
<nav className="border-b border-white/70 bg-white/80 backdrop-blur">
@@ -64,7 +63,7 @@ function NavigationBar(props) {
6463
</button>
6564
</div>
6665

67-
<ul className={`${menuWrapperClasses} ${isOpen ? '' : ' collapse'}`}>
66+
<ul className={`${menuWrapperClasses} ${isOpen ? 'flex' : 'hidden'}`}>
6867
<li>
6968
<a
7069
className={navItemClassName(

0 commit comments

Comments
 (0)