Skip to content

Commit b0a8dff

Browse files
ihabadhamclaude
andcommitted
Reframe shakapacker bundler note as TODO
"Tactical:" read as a weird label; "TODO:" is the standard signal that the current state is meant to be reverted once the upstream blocker (shakacode/react_on_rails_rsc#29) ships. Same content, leads with the action. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 55b8fb2 commit b0a8dff

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

config/shakapacker.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@ default: &default
99
webpack_compile_output: true
1010
nested_entries: true
1111
javascript_transpiler: swc
12-
# Tactical: running on webpack during the Pro RSC migration. The project will
13-
# flip back to rspack once react_on_rails_rsc ships a native rspack RSC plugin
14-
# (tracked at shakacode/react_on_rails_rsc#29). The rspack 2.0.0-beta.7 webpack
15-
# compatibility layer doesn't cover the APIs the upstream webpack RSC plugin
16-
# requires (contextModuleFactory.resolveDependencies, ModuleDependency), so the
17-
# upstream RSCWebpackPlugin can't run on rspack yet.
12+
# TODO: flip back to rspack once shakacode/react_on_rails_rsc#29 ships a
13+
# native rspack RSC plugin. On webpack for now because rspack
14+
# 2.0.0-beta.7's webpack-compat layer doesn't cover the APIs the upstream
15+
# RSCWebpackPlugin needs (contextModuleFactory.resolveDependencies,
16+
# ModuleDependency).
1817
assets_bundler: webpack
1918

2019
# Additional paths webpack should lookup modules

0 commit comments

Comments
 (0)